Add assertions on OpenSearch results

diff --git a/projects/stargazer/plugins/authorization/ao/ao.cpp b/projects/stargazer/plugins/authorization/ao/ao.cpp
index 004210d2b5b030f18c13496e2906704f804af45c..bdbfe3a9bfa1c911741ba41a984fc0e0d71ce4f5 100644 (file)
--- a/projects/stargazer/plugins/authorization/ao/ao.cpp
+++ b/projects/stargazer/plugins/authorization/ao/ao.cpp
@@ -27,6 +27,7 @@ $Author: faust $
 #include <unistd.h>
 
 #include <csignal>
 #include <unistd.h>
 
 #include <csignal>

+#include <cassert>

 #include <algorithm> // for_each
 #include <functional> // mem_fun_ref
 
 #include <algorithm> // for_each
 #include <functional> // mem_fun_ref
 


@@ -200,11 +201,7 @@ void AUTH_AO::GetUsers()
 {
 USER_PTR u;
 int h = users->OpenSearch();
 {
 USER_PTR u;
 int h = users->OpenSearch();

-if (!h)
-    {
-    printfd(__FILE__, "users->OpenSearch() error\n");
-    return;
-    }
+assert(h && "USERS::OpenSearch is always correct");

 
 while (!users->SearchNext(h, &u))
     {
 
 while (!users->SearchNext(h, &u))
     {

diff --git a/projects/stargazer/plugins/other/ping/ping.cpp b/projects/stargazer/plugins/other/ping/ping.cpp
index 7abc53b9f5b1757b3157754255f788c69ee4e05b..2968082ae64fe5ad44954ae86d25f699af502cb5 100644 (file)
--- a/projects/stargazer/plugins/other/ping/ping.cpp
+++ b/projects/stargazer/plugins/other/ping/ping.cpp
@@ -1,6 +1,6 @@
-#include <stdio.h>
-#include <signal.h>
-
+#include <cstdio>
+#include <cassert>
+#include <csignal>

 #include <ctime>
 #include <algorithm>
 
 #include <ctime>
 #include <algorithm>
 


@@ -296,11 +296,7 @@ STG_LOCKER lock(&mutex, __FILE__, __LINE__);
 
 USER_PTR u;
 int h = users->OpenSearch();
 
 USER_PTR u;
 int h = users->OpenSearch();

-if (!h)
-    {
-    printfd(__FILE__, "users->OpenSearch() error\n");
-    return;
-    }
+assert(h && "USERS::OpenSearch is always correct");

 
 while (users->SearchNext(h, &u) == 0)
     {
 
 while (users->SearchNext(h, &u) == 0)
     {

diff --git a/projects/stargazer/traffcounter_impl.cpp b/projects/stargazer/traffcounter_impl.cpp
index 237799f5e22a56fc083419ff2aadb9726dd0508c..ff18a5e2f17c36ee4e17adaccf3cba80793063c9 100644 (file)
--- a/projects/stargazer/traffcounter_impl.cpp
+++ b/projects/stargazer/traffcounter_impl.cpp
@@ -100,13 +100,8 @@ if (ReadRules())
 
 printfd(__FILE__, "TRAFFCOUNTER::Start()\n");
 int h = users->OpenSearch();
 
 printfd(__FILE__, "TRAFFCOUNTER::Start()\n");
 int h = users->OpenSearch();

+assert(h && "USERS::OpenSearch is always correct");

 USER_IMPL * u;
 USER_IMPL * u;

-if (!h)
-    {
-    printfd(__FILE__, "TRAFFCOUNTER_IMPL::Start() - Cannot get users\n");
-    WriteServLog("TRAFFCOUNTER: Cannot get users.");
-    return -1;
-    }

 
 while (users->SearchNext(h, &u) == 0)
     {
 
 while (users->SearchNext(h, &u) == 0)
     {


@@ -132,11 +127,7 @@ if (stopped)
 running = false;
 
 int h = users->OpenSearch();
 running = false;
 
 int h = users->OpenSearch();

-if (!h)
-    {
-    WriteServLog("TRAFFCOUNTER: Fatal error: Cannot get users.");
-    return -1;
-    }
+assert(h && "USERS::OpenSearch is always correct");

 
 USER_IMPL * u;
 while (users->SearchNext(h, &u) == 0)
 
 USER_IMPL * u;
 while (users->SearchNext(h, &u) == 0)