Merge branch 'master' into full-month-stats

diff --git a/doc/help.odt b/doc/help.odt
index cc9e93731d957657d3d4c78a82da3028009c1621..24c5382aafa5acbbf5147f086797cebd203dcc66 100644 (file)
Binary files a/doc/help.odt and b/doc/help.odt differ

diff --git a/doc/help/ch4.xml b/doc/help/ch4.xml
index aba9c84bc0ef83587ffc8ef217b890595862967a..fe2c185ecef6c58c3d8b0710d43674a06b9cd348 100644 (file)
--- a/doc/help/ch4.xml
+++ b/doc/help/ch4.xml
@@ -228,7 +228,8 @@
                                        <listitem><para>passiveUsers (8) — параметр, описывающий количество «замороженных» абонентов;</para></listitem>
                                        <listitem><para>creditUsers (9) — параметр, описывающий количество абонентов с положительным кредитом;</para></listitem>
                                        <listitem><para>freeMbUsers (10) — параметр, описывающий количество абонентов с неизрасходованными «бесплатными мегабайтами»;</para></listitem>
-                                       <listitem><para>tariffChangeUsers (11) — параметр, описывающий количество абонентов у которых с началом месяца будет изменен тариф.</para></listitem>
+                                       <listitem><para>tariffChangeUsers (11) — параметр, описывающий количество абонентов у которых с началом месяца будет изменен тариф;</para></listitem>
+                                       <listitem><para>activeUsers (12) — параметр, описывающий количество абонентов у которых имеется посчитанный трафик за сессию.</para></listitem>
                                </itemizedlist>
                        </listitem>
                        <listitem><para>tariffs (2) — секция, содержащая параметры относящиеся к тарифам:</para>
@@ -276,6 +277,7 @@
    |  +-- -R-- Integer32 creditUsers(9)
    |  +-- -R-- Integer32 freeMbUsers(10)
    |  +-- -R-- Integer32 tariffChangeUsers(11)
+   |  +-- -R-- Integer32 activeUsers(12)
    |
    +--tariffs(2)
    |  |

diff --git a/doc/xmlrpc/.gitignore b/doc/xmlrpc/.gitignore
new file mode 100644 (file)
index 0000000..2379867
--- /dev/null
+++ b/doc/xmlrpc/.gitignore
@@ -0,0 +1 @@
+book/*html

diff --git a/include/stg/user_ips.h b/include/stg/user_ips.h
index 8fada63b1bfa685a38d544fd9d6e844ad27b0b63..a29e28128c07f5a651df94e839128fe4bf2df70e 100644 (file)
--- a/include/stg/user_ips.h
+++ b/include/stg/user_ips.h
@@ -202,7 +202,6 @@ USER_IPS ips;
 char * paddr;
 IP_MASK im;
 std::vector<std::string> ipMask;
-std::string err;
 if (ipsStr.empty())
     {
     return ips;
@@ -236,7 +235,6 @@ for (unsigned int i = 0; i < ipMask.size(); i++)
     strIp = strtok(str, "/");
     if (strIp == NULL)
         {
-        err = "Incorrect IP address " + ipsStr;
         return ips;
         }
     strMask = strtok(NULL, "/");
@@ -244,7 +242,6 @@ for (unsigned int i = 0; i < ipMask.size(); i++)
     im.ip = inet_addr(strIp);
     if (im.ip == INADDR_NONE)
         {
-        err = "Incorrect IP address: " + std::string(strIp);
         return ips;
         }
 
@@ -254,20 +251,17 @@ for (unsigned int i = 0; i < ipMask.size(); i++)
         int m = 0;
         if (str2x(strMask, m) != 0)
             {
-            err = "Incorrect mask: " + std::string(strMask);
             return ips;
             }
         im.mask = m;
 
         if (im.mask > 32)
             {
-            err = "Incorrect mask: " + std::string(strMask);
             return ips;
             }
 
         if ((im.ip & ips.CalcMask(im.mask)) != im.ip)
             {
-            err = "Address does'n match mask: " + std::string(strIp) + "/" + std::string(strMask);
             return ips;
             }
         }

diff --git a/include/stg/user_property.h b/include/stg/user_property.h
index bdad48b0883ddc994bd80ccce428d6d011c47bfc..fbd6aa4668ed2d351bfc6615badfeff3190aefdb 100644 (file)
--- a/include/stg/user_property.h
+++ b/include/stg/user_property.h
@@ -286,8 +286,6 @@ bool USER_PROPERTY_LOGGED<varT>::Set(const varT & val,
                                      const std::string & msg)
 {
 const PRIV * priv = admin->GetPriv();
-std::string adm_login = admin->GetLogin();
-std::string adm_ip = admin->GetIPStr();
 
 if ((priv->userConf && !isStat) ||
     (priv->userStat && isStat) ||

diff --git a/include/stg/version.h b/include/stg/version.h
index 293f67d337b2278252ebea100a35f2061bebc3ce..9b94ca1282986bf89452542b22ff508ec92552b7 100644 (file)
--- a/include/stg/version.h
+++ b/include/stg/version.h
@@ -27,6 +27,6 @@
 #define __VERSION_H__
 
 // Stargazer version
-#define SERVER_VERSION "2.408-rc2" 
+#define SERVER_VERSION "2.408" 
 
 #endif

diff --git a/projects/convertor/Makefile b/projects/convertor/Makefile
index 4417e970133b3859a15f7063d5264401d320395f..efacbb64f927c6edf9096ca0654a834b7c63a7c9 100644 (file)
--- a/projects/convertor/Makefile
+++ b/projects/convertor/Makefile
@@ -70,6 +70,13 @@ deps:        $(SRCS) ../../Makefile.conf
        $(MAKE) -C $(DIR_LIBSRC)
        @>deps ;\
        for file in $(SRCS); do\
-         echo "`$(CC) $(CXXFLAGS) -MM $$file` Makefile" >> deps ;\
-         printf '%b\n' '\t$$(CC) -c $$< $(CXXFLAGS)' >> deps ;\
+         echo "$$file" | grep ".c$$" > /dev/null;\
+         if [ $$? -eq 0 ];\
+         then\
+           echo "`$(CC) $(CFLAGS) -MM $$file` Makefile" >> deps ;\
+           printf '%b\n' '\t$$(CC) $(CFLAGS) -c $$<' >> deps ;\
+         else\
+           echo "`$(CXX) $(CXXFLAGS) -MM $$file` Makefile" >> deps ;\
+           printf '%b\n' '\t$$(CXX) $(CXXFLAGS) -c $$<' >> deps ;\
+         fi;\
        done

diff --git a/projects/convertor/build b/projects/convertor/build
index c1e2ce786268ccf56b4d6873554a8dd80934115a..0144b0f1596031b5854b9dff1aa644ba28db1756 100755 (executable)
--- a/projects/convertor/build
+++ b/projects/convertor/build
@@ -36,6 +36,7 @@ then
         6) OS=bsd5;;
         7) OS=bsd7;;
         8) OS=bsd7;;
+        9) OS=bsd7;;
         *) OS=unknown;;
     esac
     MAKE="gmake"

diff --git a/projects/rlm_stg/Makefile b/projects/rlm_stg/Makefile
index da25f599d49c8f5a7cfae1917daa6f7c3a533b9b..9d51021bbf74820ed17b680788fb15247dcb81ed 100644 (file)
--- a/projects/rlm_stg/Makefile
+++ b/projects/rlm_stg/Makefile
@@ -76,6 +76,13 @@ deps:        $(SRCS) ../../Makefile.conf
        $(MAKE) -C $(DIR_LIBSRC)
        @>deps ;\
        for file in $(SRCS); do\
-         echo "`$(CC) $(CXXFLAGS) -MM $$file` Makefile" >> deps ;\
-         printf '%b\n' '\t$$(CC) -c $$< $(CXXFLAGS)' >> deps ;\
+         echo "$$file" | grep ".c$$" > /dev/null;\
+         if [ $$? -eq 0 ];\
+         then\
+           echo "`$(CC) $(CFLAGS) -MM $$file` Makefile" >> deps ;\
+           printf '%b\n' '\t$$(CC) $(CFLAGS) -c $$<' >> deps ;\
+         else\
+           echo "`$(CXX) $(CXXFLAGS) -MM $$file` Makefile" >> deps ;\
+           printf '%b\n' '\t$$(CXX) $(CXXFLAGS) -c $$<' >> deps ;\
+         fi;\
        done

diff --git a/projects/rlm_stg/build b/projects/rlm_stg/build
index fa846085b4ac90f4290344d3752a424243e6d8e5..0145d0388fd79e7e45326ce4375d597edaa9e711 100755 (executable)
--- a/projects/rlm_stg/build
+++ b/projects/rlm_stg/build
@@ -48,6 +48,7 @@ then
         6) OS=bsd5;;
         7) OS=bsd7;;
         8) OS=bsd7;;
+        9) OS=bsd7;;
         *) OS=unknown;;
     esac
     MAKE="gmake"

diff --git a/projects/rscriptd/Makefile b/projects/rscriptd/Makefile
index 581b3275acc52d9d874186497dc5b6717b3e9c7e..0912be081cc26b33cc1ad1afa8a95b7bf623dbd6 100644 (file)
--- a/projects/rscriptd/Makefile
+++ b/projects/rscriptd/Makefile
@@ -62,8 +62,8 @@ install-bin:
 
 install-data:
        # Install etc
-       mkdir -m $(DIR_MODE) -p $(PREFIX)/etc/stargazer
-       install -m $(DATA_MODE) -o $(OWNER) ./rscriptd.conf $(PREFIX)/etc/stargazer/rscriptd.conf
+       mkdir -m $(DIR_MODE) -p $(PREFIX)/etc/rscriptd
+       install -m $(DATA_MODE) -o $(OWNER) ./rscriptd.conf $(PREFIX)/etc/rscriptd/rscriptd.conf
 
 uninstall: uninstall-bin uninstall-data
 
@@ -72,7 +72,7 @@ uninstall-bin:
 
 uninstall-data:
        # Uninstall etc
-       rm -f $(PREFIX)/etc/stragazer/rscriptd.conf
+       rm -f $(PREFIX)/etc/rscriptd/rscriptd.conf
 
 
 ifneq ($(MAKECMDGOALS),distclean)
@@ -87,6 +87,13 @@ deps:        $(SRCS) ../../Makefile.conf
        $(MAKE) -C $(DIR_LIBSRC)
        @>deps ;\
        for file in $(SRCS); do\
-         echo "`$(CC) $(CXXFLAGS) -MM $$file` Makefile" >> deps ;\
-         printf '%b\n' '\t$$(CC) -c $$< $(CXXFLAGS)' >> deps ;\
+         echo "$$file" | grep ".c$$" > /dev/null;\
+         if [ $$? -eq 0 ];\
+         then\
+           echo "`$(CC) $(CFLAGS) -MM $$file` Makefile" >> deps ;\
+           printf '%b\n' '\t$$(CC) $(CFLAGS) -c $$<' >> deps ;\
+         else\
+           echo "`$(CXX) $(CXXFLAGS) -MM $$file` Makefile" >> deps ;\
+           printf '%b\n' '\t$$(CXX) $(CXXFLAGS) -c $$<' >> deps ;\
+         fi;\
        done

diff --git a/projects/rscriptd/build b/projects/rscriptd/build
index 3aa8799b77d5ae0d64b12e9b0339e8a3a475548f..885eef76558f36c88353c0ff33300d20bfa54561 100755 (executable)
--- a/projects/rscriptd/build
+++ b/projects/rscriptd/build
@@ -48,6 +48,7 @@ then
         6) OS=bsd5;;
         7) OS=bsd7;;
         8) OS=bsd7;;
+        9) OS=bsd7;;
         *) OS=unknown;;
     esac
     MAKE="gmake"

diff --git a/projects/sgauth/.gitignore b/projects/sgauth/.gitignore
new file mode 100644 (file)
index 0000000..f4bcc89
--- /dev/null
+++ b/projects/sgauth/.gitignore
@@ -0,0 +1,2 @@
+css.h
+sgauth

diff --git a/projects/sgauth/Makefile b/projects/sgauth/Makefile
index 5565199b95b98e6acd4df37765d97aec1c77cd5d..99cd0e47e71755345350886711884d84a42ab668 100644 (file)
--- a/projects/sgauth/Makefile
+++ b/projects/sgauth/Makefile
@@ -87,8 +87,15 @@ endif
 deps:  $(SRCS) ../../Makefile.conf sgauth.css
        $(MAKE) -C $(DIR_LIBSRC)
        @>deps ;\
-       ./make_css.sh
+       ./make_css.sh ;\
        for file in $(SRCS); do\
-         echo "`$(CC) $(CXXFLAGS) -MM $$file` Makefile" >> deps ;\
-         printf '%b\n' '\t$$(CC) -c $$< $(CXXFLAGS)' >> deps ;\
+         echo "$$file" | grep ".c$$" > /dev/null;\
+         if [ $$? -eq 0 ];\
+         then\
+           echo "`$(CC) $(CFLAGS) -MM $$file` Makefile" >> deps ;\
+           printf '%b\n' '\t$$(CC) $(CFLAGS) -c $$<' >> deps ;\
+         else\
+           echo "`$(CXX) $(CXXFLAGS) -MM $$file` Makefile" >> deps ;\
+           printf '%b\n' '\t$$(CXX) $(CXXFLAGS) -c $$<' >> deps ;\
+         fi;\
        done

diff --git a/projects/sgauth/build b/projects/sgauth/build
index 51401204664e3bba6a284b71991224f1c95d2bc5..ec747e2aad38a1c00860f62d972a76062f0f479e 100755 (executable)
--- a/projects/sgauth/build
+++ b/projects/sgauth/build
@@ -48,6 +48,7 @@ then
         6) OS=bsd5;;
         7) OS=bsd7;;
         8) OS=bsd7;;
+        9) OS=bsd7;;
         *) OS=unknown;;
     esac
     MAKE="gmake"

diff --git a/projects/sgauthstress/Makefile b/projects/sgauthstress/Makefile
index f688cffaf07fd17f74950ceffed6ea0da6abab7d..4474e77fd13c9aa2f9903144d3de30e55636b735 100644 (file)
--- a/projects/sgauthstress/Makefile
+++ b/projects/sgauthstress/Makefile
@@ -66,6 +66,13 @@ deps:        $(SRCS) ../../Makefile.conf
        $(MAKE) -C $(DIR_LIBSRC)
        @>deps ;\
        for file in $(SRCS); do\
-         echo "`$(CC) $(CXXFLAGS) -MM $$file` Makefile ../../Makefile.conf" >> deps ;\
-         printf '%b\n' '\t$$(CC) -c $$< $(CXXFLAGS)' >> deps ;\
+         echo "$$file" | grep ".c$$" > /dev/null;\
+         if [ $$? -eq 0 ];\
+         then\
+           echo "`$(CC) $(CFLAGS) -MM $$file` Makefile" >> deps ;\
+           printf '%b\n' '\t$$(CC) $(CFLAGS) -c $$<' >> deps ;\
+         else\
+           echo "`$(CXX) $(CXXFLAGS) -MM $$file` Makefile" >> deps ;\
+           printf '%b\n' '\t$$(CXX) $(CXXFLAGS) -c $$<' >> deps ;\
+         fi;\
        done

diff --git a/projects/sgauthstress/build b/projects/sgauthstress/build
index 05aba51bf078faa15881319d306dfc75d648ad14..d2cdf77065dcc0e53f3bea30279a79458ad9e6b3 100755 (executable)
--- a/projects/sgauthstress/build
+++ b/projects/sgauthstress/build
@@ -48,6 +48,7 @@ then
         6) OS=bsd5;;
         7) OS=bsd7;;
         8) OS=bsd7;;
+        9) OS=bsd7;;
         *) OS=unknown;;
     esac
     MAKE="gmake"

diff --git a/projects/sgconf/Makefile b/projects/sgconf/Makefile
index 0697b32996118dd8793ada7784f8cc409e704075..4d62bb536c998b0d29752f88148cb6f4fa14753c 100644 (file)
--- a/projects/sgconf/Makefile
+++ b/projects/sgconf/Makefile
@@ -87,6 +87,13 @@ deps:        $(SRCS) ../../Makefile.conf
        $(MAKE) -C $(DIR_LIBSRC)
        @>deps ;\
        for file in $(SRCS); do\
-         echo "`$(CC) $(CXXFLAGS) -MM $$file` Makefile" >> deps ;\
-         printf '%b\n' '\t$$(CC) -c $$< $(CXXFLAGS)' >> deps ;\
+         echo "$$file" | grep ".c$$" > /dev/null;\
+         if [ $$? -eq 0 ];\
+         then\
+           echo "`$(CC) $(CFLAGS) -MM $$file` Makefile" >> deps ;\
+           printf '%b\n' '\t$$(CC) $(CFLAGS) -c $$<' >> deps ;\
+         else\
+           echo "`$(CXX) $(CXXFLAGS) -MM $$file` Makefile" >> deps ;\
+           printf '%b\n' '\t$$(CXX) $(CXXFLAGS) -c $$<' >> deps ;\
+         fi;\
        done

diff --git a/projects/sgconf/build b/projects/sgconf/build
index 27f7539905572bd7b3ddffb937a9a00f27f3a344..1f6c0a0c95e7b1ad807e48f167e89ce10c623e2d 100755 (executable)
--- a/projects/sgconf/build
+++ b/projects/sgconf/build
@@ -48,6 +48,7 @@ then
         6) OS=bsd5;;
         7) OS=bsd7;;
         8) OS=bsd7;;
+        9) OS=bsd7;;
         *) OS=unknown;;
     esac
     MAKE="gmake"

diff --git a/projects/sgconf/parser.cpp b/projects/sgconf/parser.cpp
index 8e1e3cf1fe5c7e4b6fa8595f5b7864658116db14..82b7ca9e5819e3ecb1de1f96c994c28ca67ec9d9 100644 (file)
--- a/projects/sgconf/parser.cpp
+++ b/projects/sgconf/parser.cpp
@@ -111,8 +111,7 @@ while (n != ans->end())
 
     if (XML_Parse(parser, n->c_str(), len, done) == XML_STATUS_ERROR)
         {
-        char s[128];
-        printf(s, "Parse error at line %d:\n%s\n",
+        printf("Parse error at line %d:\n%s\n",
                XML_GetCurrentLineNumber(parser),
                XML_ErrorString(XML_GetErrorCode(parser)));
         exit(UNKNOWN_ERR_CODE);

diff --git a/projects/sgconf_xml/Makefile b/projects/sgconf_xml/Makefile
index aefe7c12e1cd8db58b7d3156b4a82983ec31ed3f..b7ebca0addfb67ba8950e00ba94087d9383ea135 100644 (file)
--- a/projects/sgconf_xml/Makefile
+++ b/projects/sgconf_xml/Makefile
@@ -87,6 +87,13 @@ deps:        $(SRCS) ../../Makefile.conf
        $(MAKE) -C $(DIR_LIBSRC)
        @>deps ;\
        for file in $(SRCS); do\
-         echo "`$(CC) $(CXXFLAGS) -MM $$file` Makefile" >> deps ;\
-         printf '%b\n' '\t$$(CC) -c $$< $(CXXFLAGS)' >> deps ;\
+         echo "$$file" | grep ".c$$" > /dev/null;\
+         if [ $$? -eq 0 ];\
+         then\
+           echo "`$(CC) $(CFLAGS) -MM $$file` Makefile" >> deps ;\
+           printf '%b\n' '\t$$(CC) $(CFLAGS) -c $$<' >> deps ;\
+         else\
+           echo "`$(CXX) $(CXXFLAGS) -MM $$file` Makefile" >> deps ;\
+           printf '%b\n' '\t$$(CXX) $(CXXFLAGS) -c $$<' >> deps ;\
+         fi;\
        done

diff --git a/projects/sgconf_xml/build b/projects/sgconf_xml/build
index c4ff46b55b14967da3d8219d956d2a3bdc546f23..f78e6f70ccbf41c58dd25f26030ac699b31d3c25 100755 (executable)
--- a/projects/sgconf_xml/build
+++ b/projects/sgconf_xml/build
@@ -48,6 +48,7 @@ then
         6) OS=bsd5;;   
         7) OS=bsd7;;
         8) OS=bsd7;;
+        9) OS=bsd7;;
         *) OS=unknown;;
     esac
     MAKE="gmake"

diff --git a/projects/sgconf_xml/parser.cpp b/projects/sgconf_xml/parser.cpp
index 99b48a7b19d865fdef5299e3d1519f50ad278bda..f2d5993bb9bf2fa86eaf21178e8056c539248a9c 100644 (file)
--- a/projects/sgconf_xml/parser.cpp
+++ b/projects/sgconf_xml/parser.cpp
@@ -166,8 +166,7 @@ while (n != ans->end())
 
     if (XML_Parse(parser, n->c_str(), len, done) == XML_STATUS_ERROR)
         {
-        char s[128];
-        printf(s, "Parse error at line %d: %s",
+        printf("Parse error at line %d: %s",
                XML_GetCurrentLineNumber(parser),
                XML_ErrorString(XML_GetErrorCode(parser)));
         return st_xml_parse_error;

diff --git a/projects/stargazer/Makefile b/projects/stargazer/Makefile
index 893265414a949b5c53515962ba14a3d84d994681..44ae35ec3007ebae87f6cef197526972043ae013 100644 (file)
--- a/projects/stargazer/Makefile
+++ b/projects/stargazer/Makefile
@@ -93,6 +93,7 @@ install-data:
        ln -sf ../conf-available.d/mod_ia.conf $(PREFIX)/etc/stargazer/conf-enabled.d/mod_ia.conf
        ln -sf ../conf-available.d/mod_ping.conf $(PREFIX)/etc/stargazer/conf-enabled.d/mod_ping.conf
        ln -sf ../conf-available.d/mod_sg.conf $(PREFIX)/etc/stargazer/conf-enabled.d/mod_sg.conf
+       ln -sf ../conf-available.d/store_files.conf $(PREFIX)/etc/stargazer/conf-enabled.d/store_files.conf
 
 ifeq ($(OS),linux)
        ln -sf ../conf-available.d/mod_cap_ether.conf $(PREFIX)/etc/stargazer/conf-enabled.d/mod_cap_ether.conf
@@ -138,6 +139,13 @@ deps: $(SRCS) ../../Makefile.conf
        $(MAKE) -C $(DIR_LIBSRC)
        @>deps ;\
        for file in $(SRCS); do\
-         echo "`$(CC) $(CXXFLAGS) -MM $$file` Makefile ../../Makefile.conf" >> deps ;\
-         printf '%b\n' '\t$$(CC) -c $$< $(CXXFLAGS)' >> deps ;\
+         echo "$$file" | grep ".c$$" > /dev/null;\
+         if [ $$? -eq 0 ];\
+         then\
+           echo "`$(CC) $(CFLAGS) -MM $$file` Makefile" >> deps ;\
+           printf '%b\n' '\t$$(CC) $(CFLAGS) -c $$<' >> deps ;\
+         else\
+           echo "`$(CXX) $(CXXFLAGS) -MM $$file` Makefile" >> deps ;\
+           printf '%b\n' '\t$$(CXX) $(CXXFLAGS) -c $$<' >> deps ;\
+         fi;\
        done

diff --git a/projects/stargazer/build b/projects/stargazer/build
index 23d6677ee6d68b4b25513d6b169efc6b1d99c8ad..60c8e1ff035e4c07008c3cec1c62146fbf9f084a 100755 (executable)
--- a/projects/stargazer/build
+++ b/projects/stargazer/build
@@ -70,6 +70,7 @@ then
         6) OS=bsd5;;
         7) OS=bsd7;;
         8) OS=bsd7;;
+        9) OS=bsd7;;
         *) OS=unknown;;
     esac
     ETC_DIR="./inst/freebsd/etc/stargazer"

diff --git a/projects/stargazer/plugins/capture/divert_freebsd/divert_cap.cpp b/projects/stargazer/plugins/capture/divert_freebsd/divert_cap.cpp
index 60672048a6ce00e3e6ad243526d3f14878a45898..a949433e762dab509be7475f348d3d567fdb378c 100644 (file)
--- a/projects/stargazer/plugins/capture/divert_freebsd/divert_cap.cpp
+++ b/projects/stargazer/plugins/capture/divert_freebsd/divert_cap.cpp
@@ -54,7 +54,6 @@ $Date: 2010/09/10 06:43:03 $
 struct DIVERT_DATA {
 int sock;
 short int port;
-unsigned char buffer[BUFF_LEN];
 char iface[10];
 };
 //-----------------------------------------------------------------------------

diff --git a/projects/stargazer/plugins/capture/ether_freebsd/ether_cap.cpp b/projects/stargazer/plugins/capture/ether_freebsd/ether_cap.cpp
index 5835d077acf6899b9c9cc3231d8d115e4d5c0209..247051114511f74801fab94dc600cc07e8597428 100644 (file)
--- a/projects/stargazer/plugins/capture/ether_freebsd/ether_cap.cpp
+++ b/projects/stargazer/plugins/capture/ether_freebsd/ether_cap.cpp
@@ -73,8 +73,6 @@ return bcc.GetPlugin();
 //-----------------------------------------------------------------------------
 int BPF_CAP_SETTINGS::ParseSettings(const MODULE_SETTINGS & s)
 {
-std::string ifaces;
-
 iface.erase(iface.begin(), iface.end());
 
 if (s.moduleParams.empty())

diff --git a/projects/stargazer/plugins/capture/ether_linux/ether_cap.cpp b/projects/stargazer/plugins/capture/ether_linux/ether_cap.cpp
index 632c18468f4f670061521f32615f64db8582e375..093aea7231d425d9666a53a63cec3d15d83e637f 100644 (file)
--- a/projects/stargazer/plugins/capture/ether_linux/ether_cap.cpp
+++ b/projects/stargazer/plugins/capture/ether_linux/ether_cap.cpp
@@ -154,7 +154,7 @@ sigset_t signalSet;
 sigfillset(&signalSet);
 pthread_sigmask(SIG_BLOCK, &signalSet, NULL);
 
-ETHER_CAP * dc = (ETHER_CAP *)d;
+ETHER_CAP * dc = static_cast<ETHER_CAP *>(d);
 dc->isRunning = true;
 
 struct ETH_IP

diff --git a/projects/stargazer/plugins/configuration/rpcconfig/tariffs_methods.cpp b/projects/stargazer/plugins/configuration/rpcconfig/tariffs_methods.cpp
index 0b110d542b833c93f81e19952f713594f7512b75..1643fbef2b2e2c667bd1771bf8318dad763dcdd0 100644 (file)
--- a/projects/stargazer/plugins/configuration/rpcconfig/tariffs_methods.cpp
+++ b/projects/stargazer/plugins/configuration/rpcconfig/tariffs_methods.cpp
@@ -125,7 +125,6 @@ void METHOD_TARIFF_ADD::execute(xmlrpc_c::paramList const & paramList,
 {
 std::string cookie = paramList.getString(0);
 std::string tariff = paramList.getString(1);
-std::string enc;
 paramList.verifyEnd(2);
 
 ADMIN_INFO adminInfo;

diff --git a/projects/stargazer/plugins/configuration/rpcconfig/user_helper.cpp b/projects/stargazer/plugins/configuration/rpcconfig/user_helper.cpp
index 00711e3df2f77853c99a783e4bad9af7b54d59af..fceaa3abe8f8f7e102dcc4cd1277da5ee3025a10 100644 (file)
--- a/projects/stargazer/plugins/configuration/rpcconfig/user_helper.cpp
+++ b/projects/stargazer/plugins/configuration/rpcconfig/user_helper.cpp
@@ -12,8 +12,6 @@
 void USER_HELPER::GetUserInfo(xmlrpc_c::value * info,
                               bool hidePassword)
 {
-std::string enc;
-
 std::map<std::string, xmlrpc_c::value> structVal;
 
 structVal["result"] = xmlrpc_c::value_boolean(true);

diff --git a/projects/stargazer/plugins/configuration/rpcconfig/users_methods.cpp b/projects/stargazer/plugins/configuration/rpcconfig/users_methods.cpp
index 4932e146ccfefce2d89428e3ef9de3c89297a931..48ef3103123515633614d073fa2b0f9b445cefc7 100644 (file)
--- a/projects/stargazer/plugins/configuration/rpcconfig/users_methods.cpp
+++ b/projects/stargazer/plugins/configuration/rpcconfig/users_methods.cpp
@@ -19,7 +19,6 @@ void METHOD_USER_GET::execute(xmlrpc_c::paramList const & paramList,
 {
 std::string cookie = paramList.getString(0);
 std::string login = paramList.getString(1);
-std::string enc;
 paramList.verifyEnd(2);
 
 std::map<std::string, xmlrpc_c::value> structVal;
@@ -59,7 +58,6 @@ void METHOD_USER_ADD::execute(xmlrpc_c::paramList const & paramList,
 {
 std::string cookie = paramList.getString(0);
 std::string login = paramList.getString(1);
-std::string enc;
 paramList.verifyEnd(2);
 
 ADMIN_INFO adminInfo;
@@ -103,7 +101,6 @@ void METHOD_USER_DEL::execute(xmlrpc_c::paramList const & paramList,
 {
 std::string cookie = paramList.getString(0);
 std::string login = paramList.getString(1);
-std::string enc;
 paramList.verifyEnd(2);
 
 ADMIN_INFO adminInfo;
@@ -141,7 +138,6 @@ void METHOD_USERS_GET::execute(xmlrpc_c::paramList const & paramList,
                                xmlrpc_c::value *   const   retvalPtr)
 {
 std::string cookie = paramList.getString(0);
-std::string enc;
 paramList.verifyEnd(1);
 
 std::map<std::string, xmlrpc_c::value> structVal;
@@ -195,7 +191,6 @@ void METHOD_USER_CHG::execute(xmlrpc_c::paramList const & paramList,
 std::string cookie = paramList.getString(0);
 std::string login = paramList.getString(1);
 xmlrpc_c::value_struct info(paramList.getStruct(2));
-std::string enc;
 paramList.verifyEnd(3);
 
 ADMIN_INFO adminInfo;
@@ -248,7 +243,6 @@ std::string cookie = paramList.getString(0);
 std::string login = paramList.getString(1);
 double amount = paramList.getDouble(2);
 std::string comment = IconvString(paramList.getString(3), "UTF-8", "KOI8-R");
-std::string enc;
 paramList.verifyEnd(4);
 
 ADMIN_INFO adminInfo;
@@ -298,7 +292,6 @@ std::string cookie = paramList.getString(0);
 std::string login = paramList.getString(1);
 double cash = paramList.getDouble(2);
 std::string comment = IconvString(paramList.getString(3), "UTF-8", "KOI8-R");
-std::string enc;
 paramList.verifyEnd(4);
 
 ADMIN_INFO adminInfo;
@@ -346,7 +339,6 @@ std::string login = paramList.getString(1);
 std::string tariff = paramList.getString(2);
 bool delayed = paramList.getBoolean(3);
 std::string comment = IconvString(paramList.getString(4), "UTF-8", "KOI8-R");
-std::string enc;
 paramList.verifyEnd(5);
 
 ADMIN_INFO adminInfo;
@@ -380,7 +372,8 @@ if (tariffs->FindByName(tariff))
         if (u->GetProperty().nextTariff.Set(tariff,
                                             admin,
                                             login,
-                                            store))
+                                            store,
+                                            comment))
             {
             u->WriteConf();
             *retvalPtr = xmlrpc_c::value_boolean(true);
@@ -392,7 +385,8 @@ if (tariffs->FindByName(tariff))
         if (u->GetProperty().tariffName.Set(tariff,
                                             admin,
                                             login,
-                                            store))
+                                            store,
+                                            comment))
             {
             u->ResetNextTariff();
             u->WriteConf();

diff --git a/projects/stargazer/plugins/store/mysql/mysql_store.cpp b/projects/stargazer/plugins/store/mysql/mysql_store.cpp
index e52c055d8925d7676f2e9e700fb01e2e8ffdb0b4..9d8f9c8348dfc5700c2473dd33d46922b90a91d8 100644 (file)
--- a/projects/stargazer/plugins/store/mysql/mysql_store.cpp
+++ b/projects/stargazer/plugins/store/mysql/mysql_store.cpp
@@ -163,11 +163,11 @@ MYSQL_STORE::MYSQL_STORE()
 //-----------------------------------------------------------------------------
 int    MYSQL_STORE::MysqlQuery(const char* sQuery,MYSQL * sock) const
 {
-    int ret,i;
+    int ret;
 
     if( (ret = mysql_query(sock,sQuery)) )
     {
-        for(i=0; i<RepitTimes; i++)
+        for(int i=0; i<RepitTimes; i++)
         {
             if( (ret = mysql_query(sock,sQuery)) )
                 ;//need to send error result

diff --git a/projects/stargazer/users_impl.cpp b/projects/stargazer/users_impl.cpp
index 61ee90ff7e0ad6379f2f9faed6a3d1c7c4c10d74..fc2b8d2fcdc4f5889793658d0373718c5bb7fc21 100644 (file)
--- a/projects/stargazer/users_impl.cpp
+++ b/projects/stargazer/users_impl.cpp
@@ -359,7 +359,7 @@ sigfillset(&signalSet);
 pthread_sigmask(SIG_BLOCK, &signalSet, NULL);
 
 printfd(__FILE__, "=====================| pid: %d |===================== \n", getpid());
-USERS_IMPL * us = (USERS_IMPL*) d;
+USERS_IMPL * us = static_cast<USERS_IMPL *>(d);
 
 struct tm t;
 time_t tt = stgTime;

diff --git a/tests/.gitignore b/tests/.gitignore
new file mode 100644 (file)
index 0000000..25ff3f8
--- /dev/null
+++ b/tests/.gitignore
@@ -0,0 +1,2 @@
+*.d
+tests