Apply some Clang Tidy suggestions.

[stg.git] / projects / stargazer / plugins / capture / ether_freebsd / ether_cap.cpp

diff --git a/projects/stargazer/plugins/capture/ether_freebsd/ether_cap.cpp b/projects/stargazer/plugins/capture/ether_freebsd/ether_cap.cpp
index 07e3857713c8ba4204c0823960226a1ac6da65f9..aa10327cf41ff09db42abfb0f3d7168002d1003f 100644 (file)
--- a/projects/stargazer/plugins/capture/ether_freebsd/ether_cap.cpp
+++ b/projects/stargazer/plugins/capture/ether_freebsd/ether_cap.cpp
@@ -28,72 +28,43 @@ $Date: 2009/03/24 11:20:15 $
 $Author: faust $
 */
 
 $Author: faust $
 */
 

+#include "ether_cap.h"
+
+#include "stg/common.h"
+#include "stg/raw_ip_packet.h"
+#include "stg/traffcounter.h"
+
+#include <cerrno>
+#include <cstdio>
+#include <cstring>
+#include <cstdlib>
+#include <csignal>
+

 #include <sys/types.h>
 #include <sys/uio.h>
 #include <sys/socket.h>
 #include <sys/time.h>
 #include <sys/ioctl.h>
 #include <sys/types.h>
 #include <sys/uio.h>
 #include <sys/socket.h>
 #include <sys/time.h>
 #include <sys/ioctl.h>

-#include <sys/poll.h>

 
 #include <net/bpf.h>
 #include <net/if.h>
 #include <netinet/in.h>
 #include <arpa/inet.h>
 
 #include <net/bpf.h>
 #include <net/if.h>
 #include <netinet/in.h>
 #include <arpa/inet.h>

-
-#include <errno.h>

 #include <fcntl.h>
 #include <fcntl.h>

-#include <stdio.h>
-#include <string.h>
-#include <stdlib.h>
-#include <signal.h>

 #include <unistd.h>
 
 #include <unistd.h>
 

-#include "ether_cap.h"
-#include "stg/common.h"
-#include "stg/raw_ip_packet.h"
-#include "stg/traffcounter.h"
-

 //#define CAP_DEBUG 1
 //#define CAP_DEBUG 1

-//-----------------------------------------------------------------------------
-
-//-----------------------------------------------------------------------------
-class BPF_CAP_CREATOR {
-private:
-    BPF_CAP * bpfc;
-
-public:
-    BPF_CAP_CREATOR()
-        : bpfc(new BPF_CAP())
-        {
-        }
-    ~BPF_CAP_CREATOR()
-        {
-        delete bpfc;
-        }

 
 

-    BPF_CAP * GetCapturer()
-    {
-    return bpfc;
-    }
-};
-//-----------------------------------------------------------------------------
-//-----------------------------------------------------------------------------
-//-----------------------------------------------------------------------------
-BPF_CAP_CREATOR bcc;
-//-----------------------------------------------------------------------------
-//-----------------------------------------------------------------------------
-//-----------------------------------------------------------------------------
-PLUGIN * GetPlugin()
+extern "C" STG::Plugin* GetPlugin()

 {
 {

-return bcc.GetCapturer();
+    static BPF_CAP plugin;
+    return &plugin;

 }
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 }
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------

-int BPF_CAP_SETTINGS::ParseSettings(const MODULE_SETTINGS & s)
+int BPF_CAP_SETTINGS::ParseSettings(const STG::ModuleSettings & s)

 {
 {

-std::string ifaces;
-

 iface.erase(iface.begin(), iface.end());
 
 if (s.moduleParams.empty())
 iface.erase(iface.begin(), iface.end());
 
 if (s.moduleParams.empty())


@@ -131,16 +102,16 @@ return iface[num];
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------

-const std::string BPF_CAP::GetVersion() const
+std::string BPF_CAP::GetVersion() const

 {
 {

-return "bpf_cap v.1.0";
+return "cap_bpf v.1.0";

 }
 //-----------------------------------------------------------------------------
 BPF_CAP::BPF_CAP()
 }
 //-----------------------------------------------------------------------------
 BPF_CAP::BPF_CAP()

-    : nonstop(false),
-      isRunning(false),
+    : isRunning(false),

       capSock(-1),
       capSock(-1),

-      traffCnt(NULL)
+      traffCnt(NULL),
+      logger(STG::PluginLogger::get("cap_bpf"))

 {
 }
 //-----------------------------------------------------------------------------
 {
 }
 //-----------------------------------------------------------------------------


@@ -166,16 +137,9 @@ if (BPFCapOpen() < 0)
     return -1;
     }
 
     return -1;
     }
 

-nonstop = true;
+m_thread = std::jthread([this](auto token){ Run(std::move(token)); });

 
 

-if (pthread_create(&thread, NULL, Run, this) == 0)
-    {
-    return 0;
-    }
-
-errorStr = "Cannot create thread.";
-printfd(__FILE__, "Cannot create thread\n");
-return -1;
+return 0;

 }
 //-----------------------------------------------------------------------------
 int BPF_CAP::Stop()
 }
 //-----------------------------------------------------------------------------
 int BPF_CAP::Stop()


@@ -185,7 +149,7 @@ if (!isRunning)
 
 BPFCapClose();
 
 
 BPFCapClose();
 

-nonstop = false;
+m_thread.request_stop();

 
 //5 seconds to thread stops itself
 int i;
 
 //5 seconds to thread stops itself
 int i;


@@ -194,51 +158,47 @@ for (i = 0; i < 25; i++)
     if (!isRunning)
         break;
 
     if (!isRunning)
         break;
 

-    usleep(200000);
+    struct timespec ts = {0, 200000000};
+    nanosleep(&ts, NULL);

     }
 
 //after 5 seconds waiting thread still running. now killing it
 if (isRunning)
     }
 
 //after 5 seconds waiting thread still running. now killing it
 if (isRunning)

-    {
-    //TODO pthread_cancel()
-    if (pthread_kill(thread, SIGINT))
-        {
-        errorStr = "Cannot kill thread.";
-        printfd(__FILE__, "Cannot kill thread\n");
-        return -1;
-        }
-    }
+    m_thread.detach();
+else
+    m_thread.join();

 
 return 0;
 }
 //-----------------------------------------------------------------------------
 
 return 0;
 }
 //-----------------------------------------------------------------------------

-void * BPF_CAP::Run(void * d)
+void BPF_CAP::Run(std::stop_token token)

 {
 {

-BPF_CAP * dc = (BPF_CAP *)d;
-dc->isRunning = true;
+sigset_t signalSet;
+sigfillset(&signalSet);
+pthread_sigmask(SIG_BLOCK, &signalSet, NULL);
+
+isRunning = true;

 
 uint8_t hdr[96]; //68 + 14 + 4(size) + 9(SYS_IFACE) + 1(align to 4) = 96
 
 
 uint8_t hdr[96]; //68 + 14 + 4(size) + 9(SYS_IFACE) + 1(align to 4) = 96
 

-RAW_PACKET *  rpp = (RAW_PACKET *)&hdr[14];
+STG::RawPacket *  rpp = (STG::RawPacket *)&hdr[14];

 memset(hdr, 0, sizeof(hdr));
 
 rpp->dataLen = -1;
 char * iface;
 
 memset(hdr, 0, sizeof(hdr));
 
 rpp->dataLen = -1;
 char * iface;
 

-while (dc->nonstop)
+while (!token.stop_requested())

     {
     {

-    dc->BPFCapRead((char*)&hdr, 68 + 14, &iface);
+    if (BPFCapRead((char*)&hdr, 68 + 14, &iface))
+        continue;

 
     if (!(hdr[12] == 0x8 && hdr[13] == 0x0))
 
     if (!(hdr[12] == 0x8 && hdr[13] == 0x0))

-    {

         continue;
         continue;

-    }

 
 

-    dc->traffCnt->Process(*rpp);
+    traffCnt->process(*rpp);

     }
 
     }
 

-dc->isRunning = false;
-return NULL;
+isRunning = false;

 }
 //-----------------------------------------------------------------------------
 int BPF_CAP::BPFCapOpen()
 }
 //-----------------------------------------------------------------------------
 int BPF_CAP::BPFCapOpen()


@@ -282,6 +242,7 @@ do
 if (bd->fd < 0)
     {
     errorStr = "Can't capture packets. Open bpf device for " + bd->iface + " error.";
 if (bd->fd < 0)
     {
     errorStr = "Can't capture packets. Open bpf device for " + bd->iface + " error.";

+    logger("Cannot open device for interface '%s': %s", bd->iface.c_str(), strerror(errno));

     printfd(__FILE__, "Cannot open BPF device\n");
     return -1;
     }
     printfd(__FILE__, "Cannot open BPF device\n");
     return -1;
     }


@@ -291,6 +252,7 @@ strncpy(ifr.ifr_name, bd->iface.c_str(), sizeof(ifr.ifr_name));
 if (ioctl(bd->fd, BIOCSBLEN, (caddr_t)&l) < 0)
     {
     errorStr = bd->iface + " BIOCSBLEN " + std::string(strerror(errno));
 if (ioctl(bd->fd, BIOCSBLEN, (caddr_t)&l) < 0)
     {
     errorStr = bd->iface + " BIOCSBLEN " + std::string(strerror(errno));

+    logger("ioctl (BIOCSBLEN) error for interface '%s': %s", bd->iface.c_str(), strerror(errno));

     printfd(__FILE__, "ioctl failed: '%s'\n", errorStr.c_str());
     return -1;
     }
     printfd(__FILE__, "ioctl failed: '%s'\n", errorStr.c_str());
     return -1;
     }


@@ -298,6 +260,7 @@ if (ioctl(bd->fd, BIOCSBLEN, (caddr_t)&l) < 0)
 if (ioctl(bd->fd, BIOCSETIF, (caddr_t)&ifr) < 0)
     {
     errorStr = bd->iface + " BIOCSETIF " + std::string(strerror(errno));
 if (ioctl(bd->fd, BIOCSETIF, (caddr_t)&ifr) < 0)
     {
     errorStr = bd->iface + " BIOCSETIF " + std::string(strerror(errno));

+    logger("ioctl (BIOCSETIF) error for interface '%s': %s", bd->iface.c_str(), strerror(errno));

     printfd(__FILE__, "ioctl failed: '%s'\n", errorStr.c_str());
     return -1;
     }
     printfd(__FILE__, "ioctl failed: '%s'\n", errorStr.c_str());
     return -1;
     }


@@ -305,6 +268,7 @@ if (ioctl(bd->fd, BIOCSETIF, (caddr_t)&ifr) < 0)
 if (ioctl(bd->fd, BIOCIMMEDIATE, &im) < 0)
     {
     errorStr = bd->iface + " BIOCIMMEDIATE " + std::string(strerror(errno));
 if (ioctl(bd->fd, BIOCIMMEDIATE, &im) < 0)
     {
     errorStr = bd->iface + " BIOCIMMEDIATE " + std::string(strerror(errno));

+    logger("ioctl (BIOCIMMEDIATE) error for interface '%s': %s", bd->iface.c_str(), strerror(errno));

     printfd(__FILE__, "ioctl failed: '%s'\n", errorStr.c_str());
     return -1;
     }
     printfd(__FILE__, "ioctl failed: '%s'\n", errorStr.c_str());
     return -1;
     }


@@ -327,12 +291,16 @@ for (unsigned int i = 0; i < polld.size(); i++)
     {
     if (polld[i].revents & POLLIN)
         {
     {
     if (polld[i].revents & POLLIN)
         {

-        BPFCapRead(buffer, blen, capIface, &bpfData[i]);
+        if (BPFCapRead(buffer, blen, capIface, &bpfData[i]))
+            {
+            polld[i].revents = 0;
+            continue;
+            }

         polld[i].revents = 0;
         return 0;
         }
     }
         polld[i].revents = 0;
         return 0;
         }
     }

-return 0;
+return -1;

 }
 //-----------------------------------------------------------------------------
 int BPF_CAP::BPFCapRead(char * buffer, int blen, char **, BPF_DATA * bd)
 }
 //-----------------------------------------------------------------------------
 int BPF_CAP::BPFCapRead(char * buffer, int blen, char **, BPF_DATA * bd)


@@ -342,8 +310,10 @@ if (bd->canRead)
     bd->r = read(bd->fd, bd->buffer, BUFF_LEN);
     if (bd->r < 0)
         {
     bd->r = read(bd->fd, bd->buffer, BUFF_LEN);
     if (bd->r < 0)
         {

-        //printfd(__FILE__, " error read\n");
-        usleep(20000);
+        logger("read error: %s", strerror(errno));
+        struct timespec ts = {0, 20000000};
+        nanosleep(&ts, NULL);
+        return -1;

         }
 
     bd->p = bd->buffer;
         }
 
     bd->p = bd->buffer;