Change map<std::string, USER_PROPERTY_BASE *> on REGISTRY in USER_PROPERTY_LOGGED

[stg.git] / projects / stargazer / plugins / configuration / sgconfig / parser.cpp

diff --git a/projects/stargazer/plugins/configuration/sgconfig/parser.cpp b/projects/stargazer/plugins/configuration/sgconfig/parser.cpp
index 05c16b10bac8c4c77cff51096128e4d4445ffdb2..a7c79c00d5df90f09685a7a7f535882eff233db9 100644 (file)
--- a/projects/stargazer/plugins/configuration/sgconfig/parser.cpp
+++ b/projects/stargazer/plugins/configuration/sgconfig/parser.cpp
@@ -9,11 +9,12 @@
 #include <cerrno>
 #include <sstream>
 
 #include <cerrno>
 #include <sstream>
 

+#include "stg/version.h"
+#include "stg/tariffs.h"
+#include "stg/user_property.h"
+#include "stg/settings.h"
+#include "stg/logger.h"

 #include "parser.h"
 #include "parser.h"

-#include "version.h"
-#include "tariffs.h"
-#include "../../../settings.h"
-#include "../../../user_property.h"

 
 #define  UNAME_LEN      (256)
 //-----------------------------------------------------------------------------
 
 #define  UNAME_LEN      (256)
 //-----------------------------------------------------------------------------


@@ -63,13 +64,13 @@ answerList->push_back("<ServerInfo>");
 sprintf(s, "<version value=\"%s\"/>", SERVER_VERSION);
 answerList->push_back(s);
 
 sprintf(s, "<version value=\"%s\"/>", SERVER_VERSION);
 answerList->push_back(s);
 

-sprintf(s, "<tariff_num value=\"%d\"/>", tariffs->GetTariffsNum());
+sprintf(s, "<tariff_num value=\"%llu\"/>", static_cast<unsigned long long>(tariffs->Count()));

 answerList->push_back(s);
 
 sprintf(s, "<tariff value=\"%d\"/>", 2);
 answerList->push_back(s);
 
 answerList->push_back(s);
 
 sprintf(s, "<tariff value=\"%d\"/>", 2);
 answerList->push_back(s);
 

-sprintf(s, "<users_num value=\"%d\"/>", users->GetUserNum());
+sprintf(s, "<users_num value=\"%llu\"/>", static_cast<unsigned long long>(users->Count()));

 answerList->push_back(s);
 
 sprintf(s, "<uname value=\"%s\"/>", un);
 answerList->push_back(s);
 
 sprintf(s, "<uname value=\"%s\"/>", un);


@@ -83,7 +84,7 @@ answerList->push_back(s);
 
 for (int i = 0; i< DIR_NUM; i++)
     {
 
 for (int i = 0; i< DIR_NUM; i++)
     {

-    string dn2e;
+    std::string dn2e;

     Encode12str(dn2e, settings->GetDirName(i));
     sprintf(s, "<dir_name_%d value=\"%s\"/>", i, dn2e.c_str());
     answerList->push_back(s);
     Encode12str(dn2e, settings->GetDirName(i));
     sprintf(s, "<dir_name_%d value=\"%s\"/>", i, dn2e.c_str());
     answerList->push_back(s);


@@ -94,11 +95,6 @@ answerList->push_back("</ServerInfo>");
 //-----------------------------------------------------------------------------
 //  GET USER
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 //  GET USER
 //-----------------------------------------------------------------------------

-PARSER_GET_USER::PARSER_GET_USER()
-{
-
-}
-//-----------------------------------------------------------------------------

 int PARSER_GET_USER::ParseStart(void *, const char *el, const char **attr)
 {
 if (strcasecmp(el, "GetUser") == 0)
 int PARSER_GET_USER::ParseStart(void *, const char *el, const char **attr)
 {
 if (strcasecmp(el, "GetUser") == 0)


@@ -128,8 +124,8 @@ return -1;
 //-----------------------------------------------------------------------------
 void PARSER_GET_USER::CreateAnswer()
 {
 //-----------------------------------------------------------------------------
 void PARSER_GET_USER::CreateAnswer()
 {

-string s;
-string enc;
+std::string s;
+std::string enc;

 
 USER_PTR u;
 
 
 USER_PTR u;
 


@@ -137,8 +133,7 @@ answerList->erase(answerList->begin(), answerList->end());
 
 if (users->FindByName(login, &u))
     {
 
 if (users->FindByName(login, &u))
     {

-    s = "<user result=\"error\"/>";
-    answerList->push_back(s);
+    answerList->push_back("<user result=\"error\" reason=\"User not found.\"/>");

     return;
     }
 
     return;
     }
 


@@ -194,7 +189,7 @@ s = "<email value=\"" + enc + "\" />";
 answerList->push_back(s);
 
 
 answerList->push_back(s);
 
 

-vector<USER_PROPERTY_LOGGED<string> *> userdata;
+std::vector<USER_PROPERTY_LOGGED<std::string> *> userdata;

 userdata.push_back(u->GetProperty().userdata0.GetPointer());
 userdata.push_back(u->GetProperty().userdata1.GetPointer());
 userdata.push_back(u->GetProperty().userdata2.GetPointer());
 userdata.push_back(u->GetProperty().userdata0.GetPointer());
 userdata.push_back(u->GetProperty().userdata1.GetPointer());
 userdata.push_back(u->GetProperty().userdata2.GetPointer());


@@ -206,7 +201,7 @@ userdata.push_back(u->GetProperty().userdata7.GetPointer());
 userdata.push_back(u->GetProperty().userdata8.GetPointer());
 userdata.push_back(u->GetProperty().userdata9.GetPointer());
 
 userdata.push_back(u->GetProperty().userdata8.GetPointer());
 userdata.push_back(u->GetProperty().userdata9.GetPointer());
 

-string tmpI;
+std::string tmpI;

 for (unsigned i = 0; i < userdata.size(); i++)
     {
     Encode12str(enc, userdata[i]->Get());
 for (unsigned i = 0; i < userdata.size(); i++)
     {
     Encode12str(enc, userdata[i]->Get());


@@ -234,7 +229,7 @@ answerList->push_back(s);
 strprintf(&s, "<PingTime value=\"%lu\" />", u->GetPingTime());
 answerList->push_back(s);
 
 strprintf(&s, "<PingTime value=\"%lu\" />", u->GetPingTime());
 answerList->push_back(s);
 

-stringstream sstr;
+std::ostringstream sstr;

 sstr << u->GetProperty().ips.Get();
 strprintf(&s, "<ip value=\"%s\" />", sstr.str().c_str());
 answerList->push_back(s);
 sstr << u->GetProperty().ips.Get();
 strprintf(&s, "<ip value=\"%s\" />", sstr.str().c_str());
 answerList->push_back(s);


@@ -250,7 +245,7 @@ upload = u->GetProperty().up.Get();
 
 for (int j = 0; j < DIR_NUM; j++)
     {
 
 for (int j = 0; j < DIR_NUM; j++)
     {

-    string s;
+    std::string s;

     x2str(upload[j], s);
     sprintf(st, " MU%d=\"%s\"", j, s.c_str());
     strcat(ss, st);
     x2str(upload[j], s);
     sprintf(st, " MU%d=\"%s\"", j, s.c_str());
     strcat(ss, st);


@@ -290,18 +285,19 @@ answerList->push_back(s);
 strprintf(&s, "<CreditExpire value=\"%ld\" />", u->GetProperty().creditExpire.Get());
 answerList->push_back(s);
 
 strprintf(&s, "<CreditExpire value=\"%ld\" />", u->GetProperty().creditExpire.Get());
 answerList->push_back(s);
 

+s = "<AuthorizedBy>";
+std::vector<std::string> list(u->GetAuthorizers());
+for (std::vector<std::string>::const_iterator it = list.begin(); it != list.end(); ++it)
+    s += "<Auth name=\"" + *it + "\"/>";
+s += "</AuthorizedBy>";
+answerList->push_back(s);
+

 strprintf(&s, "</user>");
 answerList->push_back(s);
 }
 //-----------------------------------------------------------------------------
 //  GET USERS
 //-----------------------------------------------------------------------------
 strprintf(&s, "</user>");
 answerList->push_back(s);
 }
 //-----------------------------------------------------------------------------
 //  GET USERS
 //-----------------------------------------------------------------------------

-PARSER_GET_USERS::PARSER_GET_USERS()
-    : lastUserUpdateTime(0),
-      lastUpdateFound(false)
-{
-}
-//-----------------------------------------------------------------------------

 int PARSER_GET_USERS::ParseStart(void *, const char *el, const char ** attr)
 {
 /*if (attr && *attr && *(attr+1))
 int PARSER_GET_USERS::ParseStart(void *, const char *el, const char ** attr)
 {
 /*if (attr && *attr && *(attr+1))


@@ -352,16 +348,16 @@ void PARSER_GET_USERS::CreateAnswer()
 {
 answerList->erase(answerList->begin(), answerList->end());
 
 {
 answerList->erase(answerList->begin(), answerList->end());
 

-string s;
-string userStart;
-string traffStart;
-string traffMiddle;
-string traffFinish;
-string middle;
-string userFinish;
+std::string s;
+std::string userStart;
+std::string traffStart;
+std::string traffMiddle;
+std::string traffFinish;
+std::string middle;
+std::string userFinish;

 
 
 
 

-string enc;
+std::string enc;

 
 USER_PTR u;
 
 
 USER_PTR u;
 


@@ -372,7 +368,7 @@ if (!h)
     users->CloseSearch(h);
     return;
     }
     users->CloseSearch(h);
     return;
     }

-string updateTime;
+std::string updateTime;

 x2str(time(NULL), updateTime);
 
 if (lastUpdateFound)
 x2str(time(NULL), updateTime);
 
 if (lastUpdateFound)


@@ -468,7 +464,7 @@ while (1)
         middle += s;
         }
 
         middle += s;
         }
 

-    vector<USER_PROPERTY_LOGGED<string> *> userdata;
+    std::vector<USER_PROPERTY_LOGGED<std::string> *> userdata;

     userdata.push_back(u->GetProperty().userdata0.GetPointer());
     userdata.push_back(u->GetProperty().userdata1.GetPointer());
     userdata.push_back(u->GetProperty().userdata2.GetPointer());
     userdata.push_back(u->GetProperty().userdata0.GetPointer());
     userdata.push_back(u->GetProperty().userdata1.GetPointer());
     userdata.push_back(u->GetProperty().userdata2.GetPointer());


@@ -480,7 +476,7 @@ while (1)
     userdata.push_back(u->GetProperty().userdata8.GetPointer());
     userdata.push_back(u->GetProperty().userdata9.GetPointer());
 
     userdata.push_back(u->GetProperty().userdata8.GetPointer());
     userdata.push_back(u->GetProperty().userdata9.GetPointer());
 

-    string tmpI;
+    std::string tmpI;

     for (unsigned i = 0; i < userdata.size(); i++)
         {
         if (userdata[i]->ModificationTime() > lastUserUpdateTime)
     for (unsigned i = 0; i < userdata.size(); i++)
         {
         if (userdata[i]->ModificationTime() > lastUserUpdateTime)


@@ -532,7 +528,7 @@ while (1)
 
     if (u->GetProperty().ips.ModificationTime() > lastUserUpdateTime)
         {
 
     if (u->GetProperty().ips.ModificationTime() > lastUserUpdateTime)
         {

-        stringstream sstr;
+        std::ostringstream sstr;

         sstr << u->GetProperty().ips.Get();
         strprintf(&s, "<ip value=\"%s\" />", sstr.str().c_str());
         middle += s;
         sstr << u->GetProperty().ips.Get();
         strprintf(&s, "<ip value=\"%s\" />", sstr.str().c_str());
         middle += s;


@@ -550,7 +546,7 @@ while (1)
         {
         for (int j = 0; j < DIR_NUM; j++)
             {
         {
         for (int j = 0; j < DIR_NUM; j++)
             {

-            string s;
+            std::string s;

             x2str(upload[j], s);
             sprintf(st, " MU%d=\"%s\" ", j, s.c_str());
             traffMiddle += st;
             x2str(upload[j], s);
             sprintf(st, " MU%d=\"%s\" ", j, s.c_str());
             traffMiddle += st;


@@ -643,11 +639,6 @@ answerList->push_back("</Users>");
 //-----------------------------------------------------------------------------
 //  ADD USER
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 //  ADD USER
 //-----------------------------------------------------------------------------

-PARSER_ADD_USER::PARSER_ADD_USER()
-{
-depth = 0;
-}
-//-----------------------------------------------------------------------------

 int PARSER_ADD_USER::ParseStart(void *, const char *el, const char **attr)
 {
 depth++;
 int PARSER_ADD_USER::ParseStart(void *, const char *el, const char **attr)
 {
 depth++;


@@ -712,7 +703,7 @@ int PARSER_ADD_USER::CheckUserData()
 USER_PTR u;
 if (users->FindByName(login, &u))
     {
 USER_PTR u;
 if (users->FindByName(login, &u))
     {

-    return users->Add(login, *currAdmin);
+    return users->Add(login, currAdmin);

     }
 return -1;
 }
     }
 return -1;
 }


@@ -720,10 +711,13 @@ return -1;
 //  PARSER CHG USER
 //-----------------------------------------------------------------------------
 PARSER_CHG_USER::PARSER_CHG_USER()
 //  PARSER CHG USER
 //-----------------------------------------------------------------------------
 PARSER_CHG_USER::PARSER_CHG_USER()

-    : usr(NULL),
+    : BASE_PARSER(),
+      usr(NULL),

       ucr(NULL),
       upr(NULL),
       downr(NULL),
       ucr(NULL),
       upr(NULL),
       downr(NULL),

+      cashMsg(),
+      login(),

       cashMustBeAdded(false),
       res(0)
 {
       cashMustBeAdded(false),
       res(0)
 {


@@ -754,11 +748,11 @@ ucr = new USER_CONF_RES;
 
 upr = new RESETABLE<uint64_t>[DIR_NUM];
 downr = new RESETABLE<uint64_t>[DIR_NUM];
 
 upr = new RESETABLE<uint64_t>[DIR_NUM];
 downr = new RESETABLE<uint64_t>[DIR_NUM];

-};
+}

 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------

-string PARSER_CHG_USER::EncChar2String(const char * strEnc)
+std::string PARSER_CHG_USER::EncChar2String(const char * strEnc)

 {
 {

-string str;
+std::string str;

 Decode21str(str, strEnc);
 return str;
 }
 Decode21str(str, strEnc);
 return str;
 }


@@ -929,7 +923,7 @@ else
         int dir;
         DIR_TRAFF dtu;
         DIR_TRAFF dtd;
         int dir;
         DIR_TRAFF dtu;
         DIR_TRAFF dtd;

-        unsigned long long t = 0;
+        uint64_t t = 0;

         while (attr[j])
             {
             dir = attr[j][2] - '0';
         while (attr[j])
             {
             dir = attr[j][2] - '0';


@@ -948,8 +942,6 @@ else
                 }
             j+=2;
             }
                 }
             j+=2;
             }

-        usr->down = dtd;
-        usr->up = dtu;

         return 0;
         }
 
         return 0;
         }
 


@@ -1009,6 +1001,7 @@ switch (res)
 //-----------------------------------------------------------------------------
 int PARSER_CHG_USER::AplayChanges()
 {
 //-----------------------------------------------------------------------------
 int PARSER_CHG_USER::AplayChanges()
 {

+printfd(__FILE__, "PARSER_CHG_USER::AplayChanges()\n");

 USER_PTR u;
 
 res = 0;
 USER_PTR u;
 
 res = 0;


@@ -1018,53 +1011,88 @@ if (users->FindByName(login, &u))
     return -1;
     }
 
     return -1;
     }
 

-if (!ucr->ips.res_empty())
-    if (!u->GetProperty().ips.Set(ucr->ips.const_data(), *currAdmin, login, store))
+bool check = false;
+bool alwaysOnline = u->GetProperty().alwaysOnline;
+if (!ucr->alwaysOnline.empty())
+    {
+    check = true;
+    alwaysOnline = ucr->alwaysOnline.const_data();
+    }
+bool onlyOneIP = u->GetProperty().ips.ConstData().OnlyOneIP();
+if (!ucr->ips.empty())
+    {
+    check = true;
+    onlyOneIP = ucr->ips.const_data().OnlyOneIP();
+    }
+
+if (check && alwaysOnline && !onlyOneIP)
+    {
+    printfd(__FILE__, "Requested change leads to a forbidden state: AlwaysOnline with multiple IP's\n");
+    GetStgLogger()("%s Requested change leads to a forbidden state: AlwaysOnline with multiple IP's", currAdmin->GetLogStr().c_str());
+    res = -1;
+    return -1;
+    }
+
+for (size_t i = 0; i < ucr->ips.const_data().Count(); ++i)
+    {
+    CONST_USER_PTR user;
+    uint32_t ip = ucr->ips.const_data().operator[](i).ip;
+    if (users->IsIPInUse(ip, login, &user))
+        {
+        printfd(__FILE__, "Trying to assign an IP %s to '%s' that is already in use by '%s'\n", inet_ntostring(ip).c_str(), login.c_str(), user->GetLogin().c_str());
+        GetStgLogger()("%s trying to assign an IP %s to '%s' that is currently in use by '%s'", currAdmin->GetLogStr().c_str(), inet_ntostring(ip).c_str(), login.c_str(), user->GetLogin().c_str());

         res = -1;
         res = -1;

+        return -1;
+        }
+    }

 
 

-if (!ucr->address.res_empty())
-    if (!u->GetProperty().address.Set(ucr->address.const_data(), *currAdmin, login, store))
+if (!ucr->ips.empty())
+    if (!u->GetProperty().ips.Set(ucr->ips.const_data(), currAdmin, login, store))

         res = -1;
 
         res = -1;
 

-if (!ucr->alwaysOnline.res_empty())
+if (!ucr->alwaysOnline.empty())

     if (!u->GetProperty().alwaysOnline.Set(ucr->alwaysOnline.const_data(),
     if (!u->GetProperty().alwaysOnline.Set(ucr->alwaysOnline.const_data(),

-                                      *currAdmin, login, store))
+                                      currAdmin, login, store))
+        res = -1;
+
+if (!ucr->address.empty())
+    if (!u->GetProperty().address.Set(ucr->address.const_data(), currAdmin, login, store))

         res = -1;
 
         res = -1;
 

-if (!ucr->creditExpire.res_empty())
+if (!ucr->creditExpire.empty())

     if (!u->GetProperty().creditExpire.Set(ucr->creditExpire.const_data(),
     if (!u->GetProperty().creditExpire.Set(ucr->creditExpire.const_data(),

-                                      *currAdmin, login, store))
+                                      currAdmin, login, store))

         res = -1;
 
         res = -1;
 

-if (!ucr->credit.res_empty())
-    if (!u->GetProperty().credit.Set(ucr->credit.const_data(), *currAdmin, login, store))
+if (!ucr->credit.empty())
+    if (!u->GetProperty().credit.Set(ucr->credit.const_data(), currAdmin, login, store))

         res = -1;
 
         res = -1;
 

-if (!usr->freeMb.res_empty())
-    if (!u->GetProperty().freeMb.Set(usr->freeMb.const_data(), *currAdmin, login, store))
+if (!usr->freeMb.empty())
+    if (!u->GetProperty().freeMb.Set(usr->freeMb.const_data(), currAdmin, login, store))

         res = -1;
 
         res = -1;
 

-if (!ucr->disabled.res_empty())
-    if (!u->GetProperty().disabled.Set(ucr->disabled.const_data(), *currAdmin, login, store))
+if (!ucr->disabled.empty())
+    if (!u->GetProperty().disabled.Set(ucr->disabled.const_data(), currAdmin, login, store))

         res = -1;
 
         res = -1;
 

-if (!ucr->disabledDetailStat.res_empty())
-    if (!u->GetProperty().disabledDetailStat.Set(ucr->disabledDetailStat.const_data(), *currAdmin, login, store))
+if (!ucr->disabledDetailStat.empty())
+    if (!u->GetProperty().disabledDetailStat.Set(ucr->disabledDetailStat.const_data(), currAdmin, login, store))

         res = -1;
 
         res = -1;
 

-if (!ucr->email.res_empty())
-    if (!u->GetProperty().email.Set(ucr->email.const_data(), *currAdmin, login, store))
+if (!ucr->email.empty())
+    if (!u->GetProperty().email.Set(ucr->email.const_data(), currAdmin, login, store))

         res = -1;
 
         res = -1;
 

-if (!ucr->group.res_empty())
-    if (!u->GetProperty().group.Set(ucr->group.const_data(), *currAdmin, login, store))
+if (!ucr->group.empty())
+    if (!u->GetProperty().group.Set(ucr->group.const_data(), currAdmin, login, store))

         res = -1;
 
         res = -1;
 

-if (!ucr->note.res_empty())
-    if (!u->GetProperty().note.Set(ucr->note.const_data(), *currAdmin, login, store))
+if (!ucr->note.empty())
+    if (!u->GetProperty().note.Set(ucr->note.const_data(), currAdmin, login, store))

         res = -1;
 
         res = -1;
 

-vector<USER_PROPERTY_LOGGED<string> *> userdata;
+std::vector<USER_PROPERTY_LOGGED<std::string> *> userdata;

 userdata.push_back(u->GetProperty().userdata0.GetPointer());
 userdata.push_back(u->GetProperty().userdata1.GetPointer());
 userdata.push_back(u->GetProperty().userdata2.GetPointer());
 userdata.push_back(u->GetProperty().userdata0.GetPointer());
 userdata.push_back(u->GetProperty().userdata1.GetPointer());
 userdata.push_back(u->GetProperty().userdata2.GetPointer());


@@ -1078,57 +1106,57 @@ userdata.push_back(u->GetProperty().userdata9.GetPointer());
 
 for (int i = 0; i < (int)userdata.size(); i++)
     {
 
 for (int i = 0; i < (int)userdata.size(); i++)
     {

-    if (!ucr->userdata[i].res_empty())
+    if (!ucr->userdata[i].empty())

         {
         {

-        if(!userdata[i]->Set(ucr->userdata[i].const_data(), *currAdmin, login, store))
+        if(!userdata[i]->Set(ucr->userdata[i].const_data(), currAdmin, login, store))

             res = -1;
         }
     }
 
             res = -1;
         }
     }
 

-if (!ucr->passive.res_empty())
-    if (!u->GetProperty().passive.Set(ucr->passive.const_data(), *currAdmin, login, store))
+if (!ucr->passive.empty())
+    if (!u->GetProperty().passive.Set(ucr->passive.const_data(), currAdmin, login, store))

         res = -1;
 
         res = -1;
 

-if (!ucr->password.res_empty())
-    if (!u->GetProperty().password.Set(ucr->password.const_data(), *currAdmin, login, store))
+if (!ucr->password.empty())
+    if (!u->GetProperty().password.Set(ucr->password.const_data(), currAdmin, login, store))

         res = -1;
 
         res = -1;
 

-if (!ucr->phone.res_empty())
-    if (!u->GetProperty().phone.Set(ucr->phone.const_data(), *currAdmin, login, store))
+if (!ucr->phone.empty())
+    if (!u->GetProperty().phone.Set(ucr->phone.const_data(), currAdmin, login, store))

         res = -1;
 
         res = -1;
 

-if (!ucr->realName.res_empty())
-    if (!u->GetProperty().realName.Set(ucr->realName.const_data(), *currAdmin, login, store))
+if (!ucr->realName.empty())
+    if (!u->GetProperty().realName.Set(ucr->realName.const_data(), currAdmin, login, store))

         res = -1;
 
 
         res = -1;
 
 

-if (!usr->cash.res_empty())
+if (!usr->cash.empty())

     {
     //if (*currAdmin->GetPriv()->userCash)
         {
         if (cashMustBeAdded)
             {
             if (!u->GetProperty().cash.Set(usr->cash.const_data() + u->GetProperty().cash,
     {
     //if (*currAdmin->GetPriv()->userCash)
         {
         if (cashMustBeAdded)
             {
             if (!u->GetProperty().cash.Set(usr->cash.const_data() + u->GetProperty().cash,

-                                      *currAdmin,
-                                      login,
-                                      store,
-                                      cashMsg))
+                                           currAdmin,
+                                           login,
+                                           store,
+                                           cashMsg))

                 res = -1;
             }
         else
             {
                 res = -1;
             }
         else
             {

-            if (!u->GetProperty().cash.Set(usr->cash.const_data(), *currAdmin, login, store, cashMsg))
+            if (!u->GetProperty().cash.Set(usr->cash.const_data(), currAdmin, login, store, cashMsg))

                 res = -1;
             }
         }
     }
 
 
                 res = -1;
             }
         }
     }
 
 

-if (!ucr->tariffName.res_empty())
+if (!ucr->tariffName.empty())

     {
     if (tariffs->FindByName(ucr->tariffName.const_data()))
         {
     {
     if (tariffs->FindByName(ucr->tariffName.const_data()))
         {

-        if (!u->GetProperty().tariffName.Set(ucr->tariffName.const_data(), *currAdmin, login, store))
+        if (!u->GetProperty().tariffName.Set(ucr->tariffName.const_data(), currAdmin, login, store))

             res = -1;
         u->ResetNextTariff();
         }
             res = -1;
         u->ResetNextTariff();
         }


@@ -1139,11 +1167,11 @@ if (!ucr->tariffName.res_empty())
         }
     }
 
         }
     }
 

-if (!ucr->nextTariff.res_empty())
+if (!ucr->nextTariff.empty())

     {
     if (tariffs->FindByName(ucr->nextTariff.const_data()))
         {
     {
     if (tariffs->FindByName(ucr->nextTariff.const_data()))
         {

-        if (!u->GetProperty().nextTariff.Set(ucr->nextTariff.const_data(), *currAdmin, login, store))
+        if (!u->GetProperty().nextTariff.Set(ucr->nextTariff.const_data(), currAdmin, login, store))

             res = -1;
         }
     else
             res = -1;
         }
     else


@@ -1159,35 +1187,26 @@ int upCount = 0;
 int downCount = 0;
 for (int i = 0; i < DIR_NUM; i++)
     {
 int downCount = 0;
 for (int i = 0; i < DIR_NUM; i++)
     {

-    if (!upr[i].res_empty())
+    if (!upr[i].empty())

         {
         {

-        up[i] = upr[i];
+        up[i] = upr[i].data();

         upCount++;
         }
         upCount++;
         }

-    if (!downr[i].res_empty())
+    if (!downr[i].empty())

         {
         {

-        down[i] = downr[i];
+        down[i] = downr[i].data();

         downCount++;
         }
     }
 
 if (upCount)
         downCount++;
         }
     }
 
 if (upCount)

-    if (!u->GetProperty().up.Set(up, *currAdmin, login, store))
+    if (!u->GetProperty().up.Set(up, currAdmin, login, store))

         res = -1;
 
 if (downCount)
         res = -1;
 
 if (downCount)

-    if (!u->GetProperty().down.Set(down, *currAdmin, login, store))
+    if (!u->GetProperty().down.Set(down, currAdmin, login, store))

         res = -1;
 
         res = -1;
 

-/*if (!usr->down.res_empty())
-    {
-    u->GetProperty().down.Set(usr->down.const_data(), *currAdmin, login, store);
-    }
-if (!usr->up.res_empty())
-    {
-    u->GetProperty().up.Set(usr->up.const_data(), *currAdmin, login, store);
-    }*/
-

 u->WriteConf();
 u->WriteStat();
 
 u->WriteConf();
 u->WriteStat();
 


@@ -1278,7 +1297,7 @@ if (strcasecmp(el, "Message") == 0)
             printfd(__FILE__, "User not found. %s\n", logins[i].c_str());
             continue;
             }
             printfd(__FILE__, "User not found. %s\n", logins[i].c_str());
             continue;
             }

-        msg.header.creationTime = stgTime;
+        msg.header.creationTime = static_cast<unsigned int>(stgTime);

         u->AddMessage(&msg);
         result = res_ok;
         }
         u->AddMessage(&msg);
         result = res_ok;
         }


@@ -1332,11 +1351,11 @@ switch (result)
         break;
     case res_params_error:
         printfd(__FILE__, "res_params_error\n");
         break;
     case res_params_error:
         printfd(__FILE__, "res_params_error\n");

-        answerList->push_back("<SendMessageResult value=\"Parameters error\"/>");
+        answerList->push_back("<SendMessageResult value=\"Parameters error.\"/>");

         break;
     case res_unknown:
         printfd(__FILE__, "res_unknown\n");
         break;
     case res_unknown:
         printfd(__FILE__, "res_unknown\n");

-        answerList->push_back("<SendMessageResult value=\"Unknown user\"/>");
+        answerList->push_back("<SendMessageResult value=\"Unknown user.\"/>");

         break;
     default:
         printfd(__FILE__, "res_default\n");
         break;
     default:
         printfd(__FILE__, "res_default\n");


@@ -1375,7 +1394,7 @@ int PARSER_DEL_USER::ParseEnd(void *, const char *el)
 if (strcasecmp(el, "DelUser") == 0)
     {
     if (!res)
 if (strcasecmp(el, "DelUser") == 0)
     {
     if (!res)

-        users->Del(u->GetLogin(), *currAdmin);
+        users->Del(u->GetLogin(), currAdmin);

 
     return 0;
     }
 
     return 0;
     }


@@ -1390,30 +1409,17 @@ else
     answerList->push_back("<DelUser value=\"ok\"/>");
 }
 //-----------------------------------------------------------------------------
     answerList->push_back("<DelUser value=\"ok\"/>");
 }
 //-----------------------------------------------------------------------------

-/*void PARSERDELUSER::CreateAnswer(char * mes)
-{
-//answerList->clear();
-answerList->erase(answerList->begin(), answerList->end());
-
-char str[255];
-sprintf(str, "<DelUser value=\"%s\"/>", mes);
-answerList->push_back(str);
-}*/
-//-----------------------------------------------------------------------------

 //  CHECK USER
 // <checkuser login="vasya" password=\"123456\"/>
 //-----------------------------------------------------------------------------
 int PARSER_CHECK_USER::ParseStart(void *, const char *el, const char **attr)
 {
 //  CHECK USER
 // <checkuser login="vasya" password=\"123456\"/>
 //-----------------------------------------------------------------------------
 int PARSER_CHECK_USER::ParseStart(void *, const char *el, const char **attr)
 {

-result = false;
-

 if (strcasecmp(el, "CheckUser") == 0)
     {
     if (attr[0] == NULL || attr[1] == NULL
      || attr[2] == NULL || attr[3] == NULL)
         {
 if (strcasecmp(el, "CheckUser") == 0)
     {
     if (attr[0] == NULL || attr[1] == NULL
      || attr[2] == NULL || attr[3] == NULL)
         {

-        result = false;
-        CreateAnswer();
+        CreateAnswer("Invalid parameters.");

         printfd(__FILE__, "PARSER_CHECK_USER - attr err\n");
         return 0;
         }
         printfd(__FILE__, "PARSER_CHECK_USER - attr err\n");
         return 0;
         }


@@ -1421,22 +1427,19 @@ if (strcasecmp(el, "CheckUser") == 0)
     USER_PTR user;
     if (users->FindByName(attr[1], &user))
         {
     USER_PTR user;
     if (users->FindByName(attr[1], &user))
         {

-        result = false;
-        CreateAnswer();
+        CreateAnswer("User not found.");

         printfd(__FILE__, "PARSER_CHECK_USER - login err\n");
         return 0;
         }
 
     if (strcmp(user->GetProperty().password.Get().c_str(), attr[3]))
         {
         printfd(__FILE__, "PARSER_CHECK_USER - login err\n");
         return 0;
         }
 
     if (strcmp(user->GetProperty().password.Get().c_str(), attr[3]))
         {

-        result = false;
-        CreateAnswer();
+        CreateAnswer("Wrong password.");

         printfd(__FILE__, "PARSER_CHECK_USER - passwd err\n");
         return 0;
         }
 
         printfd(__FILE__, "PARSER_CHECK_USER - passwd err\n");
         return 0;
         }
 

-    result = true;
-    CreateAnswer();
+    CreateAnswer(NULL);

     return 0;
     }
 return -1;
     return 0;
     }
 return -1;


@@ -1451,12 +1454,12 @@ if (strcasecmp(el, "CheckUser") == 0)
 return -1;
 }
 //-----------------------------------------------------------------------------
 return -1;
 }
 //-----------------------------------------------------------------------------

-void PARSER_CHECK_USER::CreateAnswer()
+void PARSER_CHECK_USER::CreateAnswer(const char * error)

 {
 {

-if (result)
-    answerList->push_back("<CheckUser value=\"Ok\"/>");
+if (error)
+    answerList->push_back(std::string("<CheckUser value=\"Err\" reason=\"") + error + "\"/>");

 else
 else

-    answerList->push_back("<CheckUser value=\"Err\"/>");
+    answerList->push_back("<CheckUser value=\"Ok\"/>");

 }
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 }
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------