Fixed error handling in SetUser.

[stg.git] / stglibs / srvconf.lib / netunit.cpp

diff --git a/stglibs/srvconf.lib/netunit.cpp b/stglibs/srvconf.lib/netunit.cpp
index ec796f7f1506a40885b041d74d5e86146675c268..aaba3df6afc4aedbd2d7aafb3b74331472ba1017 100644 (file)
--- a/stglibs/srvconf.lib/netunit.cpp
+++ b/stglibs/srvconf.lib/netunit.cpp
@@ -25,15 +25,18 @@
  */
 
 //---------------------------------------------------------------------------
  */
 
 //---------------------------------------------------------------------------

-#include <stdio.h>
-#include <string.h>
+
+#include "stg/netunit.h"
+#include "stg/common.h"
+
+#include <cstdio>
+#include <cerrno>
+#include <cstring>
+

 #include <netdb.h>
 #include <arpa/inet.h>
 #include <unistd.h>
 
 #include <netdb.h>
 #include <arpa/inet.h>
 #include <unistd.h>
 

-#include "netunit.h"
-#include "common.h"
-

 //---------------------------------------------------------------------------
 
 #define SEND_DATA_ERROR             "Send data error!"
 //---------------------------------------------------------------------------
 
 #define SEND_DATA_ERROR             "Send data error!"


@@ -56,15 +59,11 @@ NETTRANSACT::NETTRANSACT()
       RxCallBack(NULL),
       dataRxCallBack(NULL)
 {
       RxCallBack(NULL),
       dataRxCallBack(NULL)
 {

-    memset(server, 0, SERVER_NAME_LEN);
-    memset(login, 0, ADM_LOGIN_LEN);
-    memset(password, 0, ADM_PASSWD_LEN);
-    memset(errorMsg, 0, MAX_ERR_STR_LEN);

 }
 //-----------------------------------------------------------------------------
 void NETTRANSACT::EnDecryptInit(const char * passwd, int, BLOWFISH_CTX *ctx)
 {
 }
 //-----------------------------------------------------------------------------
 void NETTRANSACT::EnDecryptInit(const char * passwd, int, BLOWFISH_CTX *ctx)
 {

-unsigned char * keyL = NULL; // ��� ������
+unsigned char * keyL = NULL;

 
 keyL = new unsigned char[PASSWD_LEN];
 
 
 keyL = new unsigned char[PASSWD_LEN];
 


@@ -94,7 +93,7 @@ int ret;
 outerSocket = socket(PF_INET, SOCK_STREAM, 0);
 if (outerSocket < 0)
     {
 outerSocket = socket(PF_INET, SOCK_STREAM, 0);
 if (outerSocket < 0)
     {

-    strcpy(errorMsg, CREATE_SOCKET_ERROR);
+    errorMsg = CREATE_SOCKET_ERROR;

     return st_conn_fail;
     }
 
     return st_conn_fail;
     }
 


@@ -105,14 +104,14 @@ struct hostent he;
 struct hostent * phe;
 
 unsigned long ip;
 struct hostent * phe;
 
 unsigned long ip;

-ip = inet_addr(server);
+ip = inet_addr(server.c_str());

 
 if (ip == INADDR_NONE)
     {
 
 if (ip == INADDR_NONE)
     {

-    phe = gethostbyname(server);
+    phe = gethostbyname(server.c_str());

     if (phe == NULL)
         {
     if (phe == NULL)
         {

-        sprintf(errorMsg, "DNS error.\nCan not reslove %s", server);
+        errorMsg = "DNS error.\nCan not reslove " + server;

         return st_dns_err;
         }
 
         return st_dns_err;
         }
 


@@ -127,7 +126,7 @@ ret = connect(outerSocket, (struct sockaddr*)&outerAddr, sizeof(outerAddr));
 
 if (ret < 0)
     {
 
 if (ret < 0)
     {

-    strcpy(errorMsg, CONNECT_FAILED);
+    errorMsg = CONNECT_FAILED;

     close(outerSocket);
     return st_conn_fail;
     }
     close(outerSocket);
     return st_conn_fail;
     }


@@ -200,7 +199,7 @@ int ret;
 ret = send(outerSocket, STG_HEADER, strlen(STG_HEADER), 0);
 if (ret <= 0)
     {
 ret = send(outerSocket, STG_HEADER, strlen(STG_HEADER), 0);
 if (ret <= 0)
     {

-    strcpy(errorMsg, SEND_HEADER_ERROR);
+    errorMsg = SEND_HEADER_ERROR;

     return st_send_fail;
     }
 
     return st_send_fail;
     }
 


@@ -215,7 +214,8 @@ int ret;
 ret = recv(outerSocket, buffer, strlen(OK_HEADER), 0);
 if (ret <= 0)
     {
 ret = recv(outerSocket, buffer, strlen(OK_HEADER), 0);
 if (ret <= 0)
     {

-    strcpy(errorMsg, RECV_HEADER_ANSWER_ERROR);
+    printf("Receive header answer error: '%s'\n", strerror(errno));
+    errorMsg = RECV_HEADER_ANSWER_ERROR;

     return st_recv_fail;
     }
 
     return st_recv_fail;
     }
 


@@ -227,12 +227,12 @@ else
     {
     if (strncmp(ERR_HEADER, buffer, strlen(ERR_HEADER)) == 0)
         {
     {
     if (strncmp(ERR_HEADER, buffer, strlen(ERR_HEADER)) == 0)
         {

-        strcpy(errorMsg, INCORRECT_HEADER);
+        errorMsg = INCORRECT_HEADER;

         return st_header_err;
         }
     else
         {
         return st_header_err;
         }
     else
         {

-        strcpy(errorMsg, UNKNOWN_ERROR);
+        errorMsg = UNKNOWN_ERROR;

         return st_unknown_err;
         }
     }
         return st_unknown_err;
         }
     }


@@ -244,12 +244,12 @@ char loginZ[ADM_LOGIN_LEN];
 int ret;
 
 memset(loginZ, 0, ADM_LOGIN_LEN);
 int ret;
 
 memset(loginZ, 0, ADM_LOGIN_LEN);

-strncpy(loginZ, login, ADM_LOGIN_LEN);
+strncpy(loginZ, login.c_str(), ADM_LOGIN_LEN);

 ret = send(outerSocket, loginZ, ADM_LOGIN_LEN, 0);
 
 if (ret <= 0)
     {
 ret = send(outerSocket, loginZ, ADM_LOGIN_LEN, 0);
 
 if (ret <= 0)
     {

-    strcpy(errorMsg, SEND_LOGIN_ERROR);
+    errorMsg = SEND_LOGIN_ERROR;

     return st_send_fail;
     }
 
     return st_send_fail;
     }
 


@@ -259,12 +259,13 @@ return st_ok;
 int NETTRANSACT::RxLoginAnswer()
 {
 char buffer[sizeof(OK_LOGIN)+1];
 int NETTRANSACT::RxLoginAnswer()
 {
 char buffer[sizeof(OK_LOGIN)+1];

-int ret;//, we;
+int ret;

 
 ret = recv(outerSocket, buffer, strlen(OK_LOGIN), 0);
 if (ret <= 0)
     {
 
 ret = recv(outerSocket, buffer, strlen(OK_LOGIN), 0);
 if (ret <= 0)
     {

-    strcpy(errorMsg, RECV_LOGIN_ANSWER_ERROR);
+    printf("Receive login answer error: '%s'\n", strerror(errno));
+    errorMsg = RECV_LOGIN_ANSWER_ERROR;

     return st_recv_fail;
     }
 
     return st_recv_fail;
     }
 


@@ -276,12 +277,12 @@ else
     {
     if (strncmp(ERR_LOGIN, buffer, strlen(ERR_LOGIN)) == 0)
         {
     {
     if (strncmp(ERR_LOGIN, buffer, strlen(ERR_LOGIN)) == 0)
         {

-        strcpy(errorMsg, INCORRECT_LOGIN);
+        errorMsg = INCORRECT_LOGIN;

         return st_login_err;
         }
     else
         {
         return st_login_err;
         }
     else
         {

-        strcpy(errorMsg, UNKNOWN_ERROR);
+        errorMsg = UNKNOWN_ERROR;

         return st_unknown_err;
         }
     }
         return st_unknown_err;
         }
     }


@@ -294,10 +295,10 @@ char ct[ENC_MSG_LEN];
 int ret;
 
 memset(loginZ, 0, ADM_LOGIN_LEN);
 int ret;
 
 memset(loginZ, 0, ADM_LOGIN_LEN);

-strncpy(loginZ, login, ADM_LOGIN_LEN);
+strncpy(loginZ, login.c_str(), ADM_LOGIN_LEN);

 
 BLOWFISH_CTX ctx;
 
 BLOWFISH_CTX ctx;

-EnDecryptInit(password, PASSWD_LEN, &ctx);
+EnDecryptInit(password.c_str(), PASSWD_LEN, &ctx);

 
 for (int j = 0; j < ADM_LOGIN_LEN / ENC_MSG_LEN; j++)
     {
 
 for (int j = 0; j < ADM_LOGIN_LEN / ENC_MSG_LEN; j++)
     {


@@ -305,7 +306,7 @@ for (int j = 0; j < ADM_LOGIN_LEN / ENC_MSG_LEN; j++)
     ret = send(outerSocket, ct, ENC_MSG_LEN, 0);
     if (ret <= 0)
         {
     ret = send(outerSocket, ct, ENC_MSG_LEN, 0);
     if (ret <= 0)
         {

-        strcpy(errorMsg, SEND_LOGIN_ERROR);
+        errorMsg = SEND_LOGIN_ERROR;

         return st_send_fail;
         }
     }
         return st_send_fail;
         }
     }


@@ -321,7 +322,8 @@ int ret;
 ret = recv(outerSocket, buffer, strlen(OK_LOGINS), 0);
 if (ret <= 0)
     {
 ret = recv(outerSocket, buffer, strlen(OK_LOGINS), 0);
 if (ret <= 0)
     {

-    strcpy(errorMsg, RECV_LOGIN_ANSWER_ERROR);
+    printf("Receive secret login answer error: '%s'\n", strerror(errno));
+    errorMsg = RECV_LOGIN_ANSWER_ERROR;

     return st_recv_fail;
     }
 
     return st_recv_fail;
     }
 


@@ -333,12 +335,12 @@ else
     {
     if (strncmp(ERR_LOGINS, buffer, strlen(ERR_LOGINS)) == 0)
         {
     {
     if (strncmp(ERR_LOGINS, buffer, strlen(ERR_LOGINS)) == 0)
         {

-        strcpy(errorMsg, INCORRECT_LOGIN);
+        errorMsg = INCORRECT_LOGIN;

         return st_logins_err;
         }
     else
         {
         return st_logins_err;
         }
     else
         {

-        strcpy(errorMsg, UNKNOWN_ERROR);
+        errorMsg = UNKNOWN_ERROR;

         return st_unknown_err;
         }
     }
         return st_unknown_err;
         }
     }


@@ -355,7 +357,7 @@ int n = strlen(text) / ENC_MSG_LEN;
 int r = strlen(text) % ENC_MSG_LEN;
 
 BLOWFISH_CTX ctx;
 int r = strlen(text) % ENC_MSG_LEN;
 
 BLOWFISH_CTX ctx;

-EnDecryptInit(password, PASSWD_LEN, &ctx);
+EnDecryptInit(password.c_str(), PASSWD_LEN, &ctx);

 
 for (j = 0; j < n; j++)
     {
 
 for (j = 0; j < n; j++)
     {


@@ -364,7 +366,7 @@ for (j = 0; j < n; j++)
     ret = send(outerSocket, ct, ENC_MSG_LEN, 0);
     if (ret <= 0)
         {
     ret = send(outerSocket, ct, ENC_MSG_LEN, 0);
     if (ret <= 0)
         {

-        strcpy(errorMsg, SEND_DATA_ERROR);
+        errorMsg = SEND_DATA_ERROR;

         return st_send_fail;
         }
     }
         return st_send_fail;
         }
     }


@@ -373,13 +375,13 @@ memset(textZ, 0, ENC_MSG_LEN);
 if (r)
     strncpy(textZ, text + j*ENC_MSG_LEN, ENC_MSG_LEN);
 
 if (r)
     strncpy(textZ, text + j*ENC_MSG_LEN, ENC_MSG_LEN);
 

-EnDecryptInit(password, PASSWD_LEN, &ctx);
+EnDecryptInit(password.c_str(), PASSWD_LEN, &ctx);

 
 Encrypt(ct, textZ, &ctx);
 ret = send(outerSocket, ct, ENC_MSG_LEN, 0);
 if (ret <= 0)
     {
 
 Encrypt(ct, textZ, &ctx);
 ret = send(outerSocket, ct, ENC_MSG_LEN, 0);
 if (ret <= 0)
     {

-    strcpy(errorMsg, SEND_DATA_ERROR);
+    errorMsg = SEND_DATA_ERROR;

     return st_send_fail;
     }
 
     return st_send_fail;
     }
 


@@ -393,7 +395,7 @@ char buffS[ENC_MSG_LEN];
 char passwd[ADM_PASSWD_LEN];
 
 memset(passwd, 0, ADM_PASSWD_LEN);
 char passwd[ADM_PASSWD_LEN];
 
 memset(passwd, 0, ADM_PASSWD_LEN);

-strncpy(passwd, password, ADM_PASSWD_LEN);
+strncpy(passwd, password.c_str(), ADM_PASSWD_LEN);

 memset(buff, 0, ENC_MSG_LEN);
 
 int l = strlen(data)/ENC_MSG_LEN;
 memset(buff, 0, ENC_MSG_LEN);
 
 int l = strlen(data)/ENC_MSG_LEN;


@@ -421,36 +423,37 @@ char bufferS[ENC_MSG_LEN];
 char buffer[ENC_MSG_LEN + 1];
 
 BLOWFISH_CTX ctx;
 char buffer[ENC_MSG_LEN + 1];
 
 BLOWFISH_CTX ctx;

-EnDecryptInit(password, PASSWD_LEN, &ctx);
+EnDecryptInit(password.c_str(), PASSWD_LEN, &ctx);

 
 while (1)
     {
     ret = recv(outerSocket, &bufferS[n++], 1, 0);
     if (ret <= 0)
         {
 
 while (1)
     {
     ret = recv(outerSocket, &bufferS[n++], 1, 0);
     if (ret <= 0)
         {

+        printf("Receive data error: '%s'\n", strerror(errno));

         close(outerSocket);
         close(outerSocket);

-        strcpy(errorMsg, RECV_DATA_ANSWER_ERROR);
+        errorMsg = RECV_DATA_ANSWER_ERROR;

         return st_recv_fail;
         }
 
     if (n == ENC_MSG_LEN)
         {
         return st_recv_fail;
         }
 
     if (n == ENC_MSG_LEN)
         {

-

         n = 0;
         Decrypt(buffer, bufferS, &ctx);
         buffer[ENC_MSG_LEN] = 0;
 
         n = 0;
         Decrypt(buffer, bufferS, &ctx);
         buffer[ENC_MSG_LEN] = 0;
 

+        printf("%s", buffer);
+

         answerList.push_back(buffer);
 
         for (int j = 0; j < ENC_MSG_LEN; j++)
             {
             if (buffer[j] == 0)
                 {
         answerList.push_back(buffer);
 
         for (int j = 0; j < ENC_MSG_LEN; j++)
             {
             if (buffer[j] == 0)
                 {

+                printf("\n");

                 if (RxCallBack)
                     if (st_ok != RxCallBack(dataRxCallBack, &answerList))
                 if (RxCallBack)
                     if (st_ok != RxCallBack(dataRxCallBack, &answerList))

-                        {

                         return st_xml_parse_error;
                         return st_xml_parse_error;

-                        }

                 return st_ok;
                 }
             }
                 return st_ok;
                 }
             }


@@ -460,17 +463,17 @@ while (1)
 //---------------------------------------------------------------------------
 void NETTRANSACT::SetLogin(const char * l)
 {
 //---------------------------------------------------------------------------
 void NETTRANSACT::SetLogin(const char * l)
 {

-strncpy(login, l, ADM_LOGIN_LEN);
+login = l;

 }
 //---------------------------------------------------------------------------
 void NETTRANSACT::SetPassword(const char * p)
 {
 }
 //---------------------------------------------------------------------------
 void NETTRANSACT::SetPassword(const char * p)
 {

-strncpy(password, p, ADM_PASSWD_LEN);
+password = p;

 }
 //---------------------------------------------------------------------------
 void NETTRANSACT::SetServer(const char * serverName)
 {
 }
 //---------------------------------------------------------------------------
 void NETTRANSACT::SetServer(const char * serverName)
 {

-strncpy(server, serverName, SERVER_NAME_LEN);
+server = serverName;

 }
 //---------------------------------------------------------------------------
 void NETTRANSACT::SetServerPort(short unsigned p)
 }
 //---------------------------------------------------------------------------
 void NETTRANSACT::SetServerPort(short unsigned p)


@@ -484,7 +487,7 @@ RxCallBack = cb;
 dataRxCallBack = data;
 }
 //---------------------------------------------------------------------------
 dataRxCallBack = data;
 }
 //---------------------------------------------------------------------------

-char * NETTRANSACT::GetError()
+const std::string & NETTRANSACT::GetError() const

 {
 return errorMsg;
 }
 {
 return errorMsg;
 }