Оптимизация CONFIGFILE

[stg.git] / stglibs / conffiles.lib / conffiles.cpp

diff --git a/stglibs/conffiles.lib/conffiles.cpp b/stglibs/conffiles.lib/conffiles.cpp
index 549cb22d4e6d6533cdc7af55a9eaa0f1128e41ce..b247d041d675da7a37e5d4973de8cbd1b44503c7 100644 (file)
--- a/stglibs/conffiles.lib/conffiles.cpp
+++ b/stglibs/conffiles.lib/conffiles.cpp
@@ -28,11 +28,12 @@
  */
 
 //---------------------------------------------------------------------------
-#include <errno.h>
-#include <string.h>
-#include <stdlib.h>
+#include <cerrno>
+#include <cstring>
+#include <cstdlib>
+
 #include <fstream>
-#include <algorithm>
+
 #include "conffiles.h"
 #include "common.h"
 
@@ -44,81 +45,46 @@ bool StringCaseCmp(const string & str1, const string & str2)
 return (strcasecmp(str1.c_str(), str2.c_str()) < 0);
 }
 //---------------------------------------------------------------------------
-CONFIGFILE::CONFIGFILE(const string &fn):
-param_val(StringCaseCmp)
+CONFIGFILE::CONFIGFILE(const string & fn, bool nook)
+    : param_val(StringCaseCmp),
+      fileName(fn),
+      error(0)
 {
-fileName = fn;
-f = fopen(fn.c_str(), "rt");
-
-error = 0;
-param_val.clear();
+ifstream f(fileName.c_str());
 
 if (!f)
     {
-    error = -1;
+    if (!nook)
+        error = -1;
     return;
     }
 
-string line, parameter, value;
-
-unsigned long pos;
-bool emptyLine;
-unsigned char c;
-
-while (!feof(f))
+string line;
+while (getline(f, line))
     {
-    line.erase(line.begin(), line.end());
-
-    c = fgetc(f);
-    while (!feof(f))
-        {
-        //printf("%c", c);
-        if (c == '\n')
-            break;
-        line.push_back(c);
-        c = fgetc(f);
-        }
-
-    pos = line.find('#');
+    size_t pos = line.find('#');
     if (pos != string::npos)
         line.resize(pos);
 
-    emptyLine = true;
-    for (unsigned int i = 0; i < line.size(); i++)
-        {
-        if (line[i] != ' ' && line[i] != '\t' && line[i] != '\n' && line[i] != '\r')
-            {
-            emptyLine = false;
-            break;
-            }
-        }
-    if (emptyLine)
-        {
+    if (line.find_first_not_of(" \t\r") == string::npos)
         continue;
-        }
 
-    pos = line.find("=");
+    pos = line.find_first_of('=');
     if (pos == string::npos)
         {
-        fclose(f);
         error = -1;
-        //printf("%s find(=) error\n", __FILE__);
         return;
         }
-    parameter = line.substr(0, pos);
-    //transform(parameter.begin(), parameter.end(), parameter.begin(), tolower);
-    value = line.substr(pos + 1);
-    //cout << parameter << "==" << value << endl;
+
+    string parameter = line.substr(0, pos);
+    string value = line.substr(pos + 1);
     param_val[parameter] = value;
-    //cout << parameter << "==" << param_val[parameter] << endl;
     }
-
-fclose(f);
 }
 //---------------------------------------------------------------------------
 CONFIGFILE::~CONFIGFILE()
 {
-
+Flush();
 }
 //---------------------------------------------------------------------------
 const string & CONFIGFILE::GetFileName() const
@@ -126,44 +92,34 @@ const string & CONFIGFILE::GetFileName() const
 return fileName;
 }
 //---------------------------------------------------------------------------
-int CONFIGFILE::Error()
+int CONFIGFILE::Error() const
 {
 int e = error;
 error = 0;
 return e;
 }
 //---------------------------------------------------------------------------
-int CONFIGFILE::FindParameter(const string &parameter, string * value) const
+int CONFIGFILE::Flush() const
 {
-it = param_val.find(parameter);
-if (it == param_val.end())
-    return -1;
-
-*value = param_val[parameter];
-return 0;
-}
-//---------------------------------------------------------------------------
-int CONFIGFILE::Flush()
-{
-fstream f(fileName.c_str(), ios::out);
+ofstream f(fileName.c_str());
 if (!f.is_open())
     {
     error = EIO;
     return EIO;
     }
 
-it = param_val.begin();
+map<string, string>::const_iterator it = param_val.begin();
 while (it != param_val.end())
     {
-    f << it->first << "=" << it->second << endl;
-    it++;
+    f << it->first << "=" << it->second << "\n";
+    ++it;
     }
 
 f.close();
 
 return 0;
 }
-//---------------------------------------------------------------------------
+/*//---------------------------------------------------------------------------
 int CONFIGFILE::ReadString(const string & param, char * str, int * maxLen, const char * defaultVal) const
 {
 it = param_val.find(param);
@@ -180,17 +136,17 @@ if (it != param_val.end())
 strncpy(str, defaultVal, *maxLen);
 *maxLen = strlen(defaultVal);
 return -1;
-}
+}*/
 //---------------------------------------------------------------------------
 int CONFIGFILE::ReadString(const string & param, string * val, const string & defaultVal) const
 {
-it = param_val.find(param);
+const map<string, string>::const_iterator it(param_val.find(param));
 // îÁÛÌÉ ÎÕÖÎÕÀ ÐÅÒÅÍÅÎÎÕÀ
 
 if (it != param_val.end())
     {
     // þÔÏ-ÔÏ ÓÔÏÉÔ
-    *val = param_val[param];
+    *val = it->second;
     return 0;
     }
 
@@ -198,27 +154,19 @@ if (it != param_val.end())
 return -1;
 }
 //---------------------------------------------------------------------------
-int CONFIGFILE::WriteString(const string & param, const char * val)
-{
-WriteString(param, string(val));
-return 0;
-}
-//---------------------------------------------------------------------------
-int CONFIGFILE::WriteString(const string & param, const string &val)
+void CONFIGFILE::WriteString(const string & param, const string &val)
 {
 param_val[param] = val;
-Flush();
-return 0;
 }
 //---------------------------------------------------------------------------
 int CONFIGFILE::ReadTime(const string & param, time_t * val, time_t defaultVal) const
 {
-it = param_val.find(param);
+const map<string, string>::const_iterator it(param_val.find(param));
 
 if (it != param_val.end())
     {
     char *res;
-    *val = strtol(param_val[param].c_str(), &res, 10);
+    *val = strtol(it->second.c_str(), &res, 10);
     if (*res != 0)
         {
         *val = defaultVal; //Error!
@@ -233,14 +181,14 @@ return -1;
 //---------------------------------------------------------------------------
 int CONFIGFILE::ReadInt(const string & param, int * val, int defaultVal) const
 {
-it = param_val.find(param);
+const map<string, string>::const_iterator it(param_val.find(param));
 // îÁÛÌÉ ÎÕÖÎÕÀ ÐÅÒÅÍÅÎÎÕÀ
 
 if (it != param_val.end())
     {
     // þÔÏ-ÔÏ ÓÔÏÉÔ
     char *res;
-    *val = strtol(param_val[param].c_str(), &res, 10);
+    *val = strtol(it->second.c_str(), &res, 10);
     if (*res != 0)
         {
         *val = defaultVal; //Error!
@@ -255,14 +203,14 @@ return -1;
 //---------------------------------------------------------------------------
 int CONFIGFILE::ReadUInt(const string & param, unsigned int * val, unsigned int defaultVal) const
 {
-it = param_val.find(param);
+const map<string, string>::const_iterator it(param_val.find(param));
 // îÁÛÌÉ ÎÕÖÎÕÀ ÐÅÒÅÍÅÎÎÕÀ
 
 if (it != param_val.end())
     {
     // þÔÏ-ÔÏ ÓÔÏÉÔ
     char *res;
-    *val = strtoul(param_val[param].c_str(), &res, 10);
+    *val = strtoul(it->second.c_str(), &res, 10);
     if (*res != 0)
         {
         *val = defaultVal; //Error!
@@ -277,14 +225,14 @@ return -1;
 //---------------------------------------------------------------------------
 int CONFIGFILE::ReadLongInt(const string & param, long int * val, long int defaultVal) const
 {
-it = param_val.find(param);
+const map<string, string>::const_iterator it(param_val.find(param));
 // îÁÛÌÉ ÎÕÖÎÕÀ ÐÅÒÅÍÅÎÎÕÀ
 
 if (it != param_val.end())
     {
     // þÔÏ-ÔÏ ÓÔÏÉÔ
     char *res;
-    *val = strtol(param_val[param].c_str(), &res, 10);
+    *val = strtol(it->second.c_str(), &res, 10);
     if (*res != 0)
         {
         *val = defaultVal; //Error!
@@ -299,14 +247,14 @@ return -1;
 //---------------------------------------------------------------------------
 int CONFIGFILE::ReadULongInt(const string & param, unsigned long int * val, unsigned long int defaultVal) const
 {
-it = param_val.find(param);
+const map<string, string>::const_iterator it(param_val.find(param));
 // îÁÛÌÉ ÎÕÖÎÕÀ ÐÅÒÅÍÅÎÎÕÀ
 
 if (it != param_val.end())
     {
     // þÔÏ-ÔÏ ÓÔÏÉÔ
     char *res;
-    *val = strtoul(param_val[param].c_str(), &res, 10);
+    *val = strtoul(it->second.c_str(), &res, 10);
     if (*res != 0)
         {
         *val = defaultVal; //Error!
@@ -321,14 +269,14 @@ return -1;
 //---------------------------------------------------------------------------
 int CONFIGFILE::ReadLongLongInt(const string & param, int64_t * val, int64_t defaultVal) const
 {
-it = param_val.find(param);
+const map<string, string>::const_iterator it(param_val.find(param));
 // îÁÛÌÉ ÎÕÖÎÕÀ ÐÅÒÅÍÅÎÎÕÀ
 
 if (it != param_val.end())
     {
     // þÔÏ-ÔÏ ÓÔÏÉÔ
     char *res;
-    *val = strtoll(param_val[param].c_str(), &res, 10);
+    *val = strtoll(it->second.c_str(), &res, 10);
     if (*res != 0)
         {
         *val = defaultVal; //Error!
@@ -343,14 +291,14 @@ return -1;
 //---------------------------------------------------------------------------
 int CONFIGFILE::ReadULongLongInt(const string & param, uint64_t * val, uint64_t defaultVal) const
 {
-it = param_val.find(param);
+const map<string, string>::const_iterator it(param_val.find(param));
 // îÁÛÌÉ ÎÕÖÎÕÀ ÐÅÒÅÍÅÎÎÕÀ
 
 if (it != param_val.end())
     {
     // þÔÏ-ÔÏ ÓÔÏÉÔ
     char *res;
-    *val = strtoull(param_val[param].c_str(), &res, 10);
+    *val = strtoull(it->second.c_str(), &res, 10);
     if (*res != 0)
         {
         *val = defaultVal; //Error!
@@ -365,14 +313,14 @@ return -1;
 //---------------------------------------------------------------------------
 int CONFIGFILE::ReadShortInt(const string & param, short int * val, short int defaultVal) const
 {
-it = param_val.find(param);
+const map<string, string>::const_iterator it(param_val.find(param));
 // îÁÛÌÉ ÎÕÖÎÕÀ ÐÅÒÅÍÅÎÎÕÀ
 
 if (it != param_val.end())
     {
     // þÔÏ-ÔÏ ÓÔÏÉÔ
     char *res;
-    *val = (short)strtol(param_val[param].c_str(), &res, 10);
+    *val = (short)strtol(it->second.c_str(), &res, 10);
     if (*res != 0)
         {
         *val = defaultVal; //Error!
@@ -387,14 +335,14 @@ return -1;
 //---------------------------------------------------------------------------
 int CONFIGFILE::ReadUShortInt(const string & param, unsigned short int * val, unsigned short int defaultVal) const
 {
-it = param_val.find(param);
+const map<string, string>::const_iterator it(param_val.find(param));
 // îÁÛÌÉ ÎÕÖÎÕÀ ÐÅÒÅÍÅÎÎÕÀ
 
 if (it != param_val.end())
     {
     // þÔÏ-ÔÏ ÓÔÏÉÔ
     char *res;
-    *val = (short)strtoul(param_val[param].c_str(), &res, 10);
+    *val = (short)strtoul(it->second.c_str(), &res, 10);
     if (*res != 0)
         {
         *val = defaultVal; //Error!
@@ -407,49 +355,39 @@ if (it != param_val.end())
 return -1;
 }
 //---------------------------------------------------------------------------
-int CONFIGFILE::WriteInt(const string & param, int64_t val)
+void CONFIGFILE::WriteInt(const string & param, int64_t val)
 {
 string s;
-//sprintf(s, "%lld", val);
 x2str(val, s);
 param_val[param] = s;
-Flush();
-return 0;
 }
 //---------------------------------------------------------------------------
 int CONFIGFILE::ReadDouble(const string & param, double * val, double defaultVal) const
 {
-it = param_val.find(param);
+const map<string, string>::const_iterator it(param_val.find(param));
 // îÁÛÌÉ ÎÕÖÎÕÀ ÐÅÒÅÍÅÎÎÕÀ
 
 if (it != param_val.end())
     {
     // þÔÏ-ÔÏ ÓÔÏÉÔ
     char *res;
-    *val = strtod(param_val[param].c_str(), &res);
+    *val = strtod(it->second.c_str(), &res);
     if (*res != 0)
         {
-        //cout << param << "=" << param_val[param] << " Error!!!\n";
         *val = defaultVal; //Error!
         return EINVAL;
         }
     return 0;
     }
 
-//cout << "îÉÞÅÇÏ ÎÅÔ!!!\n";
-
 *val = defaultVal;
 return -1;
 }
 //---------------------------------------------------------------------------
-int CONFIGFILE::WriteDouble(const string & param, double val)
+void CONFIGFILE::WriteDouble(const string & param, double val)
 {
 char s[30];
-sprintf(s, "%f", val);
+snprintf(s, 30, "%f", val);
 param_val[param] = s;
-Flush();
-return 0;
 }
 //---------------------------------------------------------------------------
-
-