Correcting return in method GetParamValue and cycle in methods OnConnect and OnDisconnect

[stg.git] / projects / stargazer / plugins / store / postgresql / postgresql_store.cpp

diff --git a/projects/stargazer/plugins/store/postgresql/postgresql_store.cpp b/projects/stargazer/plugins/store/postgresql/postgresql_store.cpp
index e316beafb87d68d4dceb9090b2830cced8793086..dd2fbbab7a168ed159feff737cf04e63be0f4898 100644 (file)
--- a/projects/stargazer/plugins/store/postgresql/postgresql_store.cpp
+++ b/projects/stargazer/plugins/store/postgresql/postgresql_store.cpp
@@ -22,7 +22,7 @@
  *  This file contains a realization of a base postgresql-storage plugin class
  *
  *  v. 1.3
  *  This file contains a realization of a base postgresql-storage plugin class
  *
  *  v. 1.3

- *  FreeMb logging on dosconnects added
+ *  FreeMb logging on disconnects added

  *
  *  v. 1.2
  *  Reconnection on faults added
  *
  *  v. 1.2
  *  Reconnection on faults added


@@ -44,41 +44,40 @@
 
 #include <libpq-fe.h>
 
 
 #include <libpq-fe.h>
 

-#include "postgresql_store.h"
+#include "stg/module_settings.h"
+#include "stg/plugin_creator.h"

 #include "postgresql_store_utils.h"
 #include "postgresql_store_utils.h"

-#include "base_settings.h"
+#include "postgresql_store.h"

 
 

-class POSTGRESQL_STORE_CREATOR
+namespace

 {
 {

-public:
-    POSTGRESQL_STORE_CREATOR()
-        : pqStore(new POSTGRESQL_STORE())
-        {
-        };
-    ~POSTGRESQL_STORE_CREATOR()
-        {
-        delete pqStore;
-        };
-    POSTGRESQL_STORE * GetStore() { return pqStore; };
-private:
-    POSTGRESQL_STORE * pqStore;
-} pqStoreeCreator;
+PLUGIN_CREATOR<POSTGRESQL_STORE> pgsc;
+}
+
+extern "C" STORE * GetStore();

 
 //-----------------------------------------------------------------------------
 
 //-----------------------------------------------------------------------------

-BASE_STORE * GetStore()
+STORE * GetStore()

 {
 {

-return pqStoreeCreator.GetStore();
+return pgsc.GetPlugin();

 }
 
 //-----------------------------------------------------------------------------
 POSTGRESQL_STORE::POSTGRESQL_STORE()
 }
 
 //-----------------------------------------------------------------------------
 POSTGRESQL_STORE::POSTGRESQL_STORE()

-    : connection(NULL)
+    : versionString("postgresql_store v.1.3"),
+      strError(),
+      server("localhost"),
+      database("stargazer"),
+      user("stg"),
+      password("123456"),
+      clientEncoding("KOI8"),
+      settings(),
+      mutex(),
+      version(0),
+      retries(3),
+      connection(NULL),
+      logger(GetPluginLogger(GetStgLogger(), "store_postgresql"))

 {
 {

-server = "localhost";
-database = "stargazer";
-user = "stg";
-password = "123456";
-versionString = "postgresql_store v.1.3";

 pthread_mutex_init(&mutex, NULL);
 }
 //-----------------------------------------------------------------------------
 pthread_mutex_init(&mutex, NULL);
 }
 //-----------------------------------------------------------------------------


@@ -94,7 +93,7 @@ pthread_mutex_destroy(&mutex);
 int POSTGRESQL_STORE::ParseSettings()
 {
 std::vector<PARAM_VALUE>::iterator i;
 int POSTGRESQL_STORE::ParseSettings()
 {
 std::vector<PARAM_VALUE>::iterator i;

-string s;
+std::string s;

 
 for(i = settings.moduleParams.begin(); i != settings.moduleParams.end(); ++i)
     {
 
 for(i = settings.moduleParams.begin(); i != settings.moduleParams.end(); ++i)
     {


@@ -116,6 +115,15 @@ for(i = settings.moduleParams.begin(); i != settings.moduleParams.end(); ++i)
         {
         password = *(i->value.begin());
         }
         {
         password = *(i->value.begin());
         }

+    if (s == "retries")
+        {
+        if (str2x(*(i->value.begin()), retries))
+            {
+            strError = "Invalid 'retries' value";
+            printfd(__FILE__, "POSTGRESQL_STORE::ParseSettings(): '%s'\n", strError.c_str());
+            return -1;
+            }
+        }

     }
 
 clientEncoding = "KOI8";
     }
 
 clientEncoding = "KOI8";


@@ -137,7 +145,8 @@ if (PQstatus(connection) != CONNECTION_OK)
     {
     strError = PQerrorMessage(connection);
     printfd(__FILE__, "POSTGRESQL_STORE::Connect(): '%s'\n", strError.c_str());
     {
     strError = PQerrorMessage(connection);
     printfd(__FILE__, "POSTGRESQL_STORE::Connect(): '%s'\n", strError.c_str());

-    return 1;
+    // Will try to connect later
+    return 0;

     }
 
 if (PQsetClientEncoding(connection, clientEncoding.c_str()))
     }
 
 if (PQsetClientEncoding(connection, clientEncoding.c_str()))


@@ -152,7 +161,12 @@ return CheckVersion();
 //-----------------------------------------------------------------------------
 int POSTGRESQL_STORE::Reset() const
 {
 //-----------------------------------------------------------------------------
 int POSTGRESQL_STORE::Reset() const
 {

-PQreset(connection);
+for (int i = 0; i < retries && PQstatus(connection) != CONNECTION_OK; ++i)
+    {
+    struct timespec ts = {1, 0};
+    nanosleep(&ts, NULL);
+    PQreset(connection);
+    }

 
 if (PQstatus(connection) != CONNECTION_OK)
     {
 
 if (PQstatus(connection) != CONNECTION_OK)
     {


@@ -165,7 +179,7 @@ if (PQsetClientEncoding(connection, clientEncoding.c_str()))
     {
     strError = PQerrorMessage(connection);
     printfd(__FILE__, "POSTGRESQL_STORE::Reset(): '%s'\n", strError.c_str());
     {
     strError = PQerrorMessage(connection);
     printfd(__FILE__, "POSTGRESQL_STORE::Reset(): '%s'\n", strError.c_str());

-    return 1;
+    return -1;

     }
 
 return CheckVersion();
     }
 
 return CheckVersion();