Check IP in USERS_IMPL::Authorize as early as possible

[stg.git] / projects / stargazer / plugins / other / ping / ping.cpp

diff --git a/projects/stargazer/plugins/other/ping/ping.cpp b/projects/stargazer/plugins/other/ping/ping.cpp
index f9fc387aa11f27dc1810e95f89e2c4629bbbaf16..2968082ae64fe5ad44954ae86d25f699af502cb5 100644 (file)
--- a/projects/stargazer/plugins/other/ping/ping.cpp
+++ b/projects/stargazer/plugins/other/ping/ping.cpp
@@ -1,39 +1,23 @@
-#include <stdio.h>
-#include <unistd.h>
-#include <signal.h>
-
+#include <cstdio>
+#include <cassert>
+#include <csignal>
+#include <ctime>

 #include <algorithm>
 
 #include <algorithm>
 

+#include "stg/user.h"
+#include "stg/locker.h"
+#include "stg/user_property.h"
+#include "stg/plugin_creator.h"

 #include "ping.h"
 #include "ping.h"

-#include "user.h"
-#include "stg_locker.h"
-#include "user_property.h"
-#include "../../../settings.h"
-
-class PING_CREATOR
-{
-private:
-    PING * ping;
-
-public:
-    PING_CREATOR()
-        : ping(new PING())
-        {
-        };
-    ~PING_CREATOR()
-        {
-        delete ping;
-        };

 
 

-    PING * GetPlugin()
-        {
-        return ping;
-        };
-};
+PLUGIN_CREATOR<PING> pc;

 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------

-PING_CREATOR pc;
+PLUGIN * GetPlugin()
+{
+return pc.GetPlugin();
+}

 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------


@@ -53,13 +37,6 @@ private:
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------

-PLUGIN * GetPlugin()
-{
-return pc.GetPlugin();
-}
-//-----------------------------------------------------------------------------
-//-----------------------------------------------------------------------------
-//-----------------------------------------------------------------------------

 PING_SETTINGS::PING_SETTINGS()
     : pingDelay(0)
 {
 PING_SETTINGS::PING_SETTINGS()
     : pingDelay(0)
 {


@@ -88,21 +65,6 @@ if (ParseIntInRange(pvi->value[0], 5, 3600, &pingDelay))
 return 0;
 }
 //-----------------------------------------------------------------------------
 return 0;
 }
 //-----------------------------------------------------------------------------

-int PING_SETTINGS::ParseIntInRange(const std::string & str, int min, int max, int * val)
-{
-if (str2x(str.c_str(), *val))
-    {
-    errorStr = "Incorrect value \'" + str + "\'.";
-    return -1;
-    }
-if (*val < min || *val > max)
-    {
-    errorStr = "Value \'" + str + "\' out of range.";
-    return -1;
-    }
-return 0;
-}
-//-----------------------------------------------------------------------------

 PING::PING()
     : users(NULL),
       nonstop(false),
 PING::PING()
     : users(NULL),
       nonstop(false),


@@ -178,12 +140,13 @@ if (!isRunning)
 pinger.Stop();
 nonstop = false;
 //5 seconds to thread stops itself
 pinger.Stop();
 nonstop = false;
 //5 seconds to thread stops itself

+struct timespec ts = {0, 200000000};

 for (int i = 0; i < 25; i++)
     {
     if (!isRunning)
         break;
 
 for (int i = 0; i < 25; i++)
     {
     if (!isRunning)
         break;
 

-    usleep(200000);
+    nanosleep(&ts, NULL);

     }
 
 //after 5 seconds waiting thread still running. now kill it
     }
 
 //after 5 seconds waiting thread still running. now kill it


@@ -220,22 +183,22 @@ return isRunning;
 //-----------------------------------------------------------------------------
 void * PING::Run(void * d)
 {
 //-----------------------------------------------------------------------------
 void * PING::Run(void * d)
 {

-PING * ping = (PING*)d;
+PING * ping = (PING *)d;

 ping->isRunning = true;
 ping->isRunning = true;

-list<USER_PTR>::iterator iter;
-uint32_t ip;
-time_t t;

 
 

+long delay = (10000000 * ping->pingSettings.GetPingDelay()) / 3 + 50000000;
+ 

 while (ping->nonstop)
     {
 while (ping->nonstop)
     {

-    iter = ping->usersList.begin();
+    list<USER_PTR>::iterator iter = ping->usersList.begin();

         {
         STG_LOCKER lock(&ping->mutex, __FILE__, __LINE__);
         while (iter != ping->usersList.end())
             {
             if ((*iter)->GetProperty().ips.ConstData().OnlyOneIP())
                 {
         {
         STG_LOCKER lock(&ping->mutex, __FILE__, __LINE__);
         while (iter != ping->usersList.end())
             {
             if ((*iter)->GetProperty().ips.ConstData().OnlyOneIP())
                 {

-                ip = (*iter)->GetProperty().ips.ConstData()[0].ip;
+                uint32_t ip = (*iter)->GetProperty().ips.ConstData()[0].ip;
+                time_t t;

                 if (ping->pinger.GetIPTime(ip, &t) == 0)
                     {
                     if (t)
                 if (ping->pinger.GetIPTime(ip, &t) == 0)
                     {
                     if (t)


@@ -244,9 +207,10 @@ while (ping->nonstop)
                 }
             else
                 {
                 }
             else
                 {

-                ip = (*iter)->GetCurrIP();
+                uint32_t ip = (*iter)->GetCurrIP();

                 if (ip)
                     {
                 if (ip)
                     {

+                    time_t t;

                     if (ping->pinger.GetIPTime(ip, &t) == 0)
                         {
                         if (t)
                     if (ping->pinger.GetIPTime(ip, &t) == 0)
                         {
                         if (t)


@@ -257,14 +221,16 @@ while (ping->nonstop)
             ++iter;
             }
         }
             ++iter;
             }
         }

+    struct timespec ts = {delay / 1000000000, delay % 1000000000};

     for (int i = 0; i < 100; i++)
         {
         if (ping->nonstop)
             {
     for (int i = 0; i < 100; i++)
         {
         if (ping->nonstop)
             {

-            usleep((10000*ping->pingSettings.GetPingDelay())/3 + 50000);
+            nanosleep(&ts, NULL);

             }
         }
     }
             }
         }
     }

+

 ping->isRunning = false;
 return NULL;
 }
 ping->isRunning = false;
 return NULL;
 }


@@ -330,11 +296,7 @@ STG_LOCKER lock(&mutex, __FILE__, __LINE__);
 
 USER_PTR u;
 int h = users->OpenSearch();
 
 USER_PTR u;
 int h = users->OpenSearch();

-if (!h)
-    {
-    printfd(__FILE__, "users->OpenSearch() error\n");
-    return;
-    }
+assert(h && "USERS::OpenSearch is always correct");

 
 while (users->SearchNext(h, &u) == 0)
     {
 
 while (users->SearchNext(h, &u) == 0)
     {