Add missing library link.

[stg.git] / projects / sgconf / tariffs.cpp

diff --git a/projects/sgconf/tariffs.cpp b/projects/sgconf/tariffs.cpp
index c11ff4729014a15f705886c0a8adebfe6f335763..23449bb69410ca86c07c9381d3b21e8fcd13a40e 100644 (file)
--- a/projects/sgconf/tariffs.cpp
+++ b/projects/sgconf/tariffs.cpp
@@ -2,6 +2,7 @@
 
 #include "api_action.h"
 #include "options.h"
 
 #include "api_action.h"
 #include "options.h"

+#include "makeproto.h"

 #include "config.h"
 #include "utils.h"
 
 #include "config.h"
 #include "utils.h"
 


@@ -9,13 +10,14 @@
 #include "stg/servconf_types.h"
 #include "stg/tariff_conf.h"
 #include "stg/common.h"
 #include "stg/servconf_types.h"
 #include "stg/tariff_conf.h"
 #include "stg/common.h"

-#include "stg/os_int.h"

 
 #include <iostream>
 #include <algorithm>
 #include <sstream>
 #include <string>
 #include <map>
 
 #include <iostream>
 #include <algorithm>
 #include <sstream>
 #include <string>
 #include <map>

+#include <optional>
+#include <cstdint>

 #include <cassert>
 
 namespace
 #include <cassert>
 
 namespace


@@ -28,89 +30,97 @@ if (level == 0)
 return dash ? std::string(level * 4 - 2, ' ') + "- " : std::string(level * 4, ' ');
 }
 
 return dash ? std::string(level * 4 - 2, ' ') + "- " : std::string(level * 4, ' ');
 }
 

-std::string ChangePolicyToString(TARIFF::CHANGE_POLICY changePolicy)
+std::string ChangePolicyToString(STG::Tariff::ChangePolicy changePolicy)

 {
 switch (changePolicy)
     {
 {
 switch (changePolicy)
     {

-    case TARIFF::ALLOW: return "allow";
-    case TARIFF::TO_CHEAP: return "to_cheap";
-    case TARIFF::TO_EXPENSIVE: return "to_expensive";
-    case TARIFF::DENY: return "deny";
+    case STG::Tariff::ALLOW: return "allow";
+    case STG::Tariff::TO_CHEAP: return "to_cheap";
+    case STG::Tariff::TO_EXPENSIVE: return "to_expensive";
+    case STG::Tariff::DENY: return "deny";

     }
 return "unknown";
 }
 
     }
 return "unknown";
 }
 

-std::string PeriodToString(TARIFF::PERIOD period)
+std::string PeriodToString(STG::Tariff::Period period)

 {
 switch (period)
     {
 {
 switch (period)
     {

-    case TARIFF::DAY:
+    case STG::Tariff::DAY:

         return "daily";
         return "daily";

-    case TARIFF::MONTH:
+    case STG::Tariff::MONTH:

         return "monthly";
     }
 return "unknown";
 }
 
         return "monthly";
     }
 return "unknown";
 }
 

-std::string TraffTypeToString(TARIFF::TRAFF_TYPE traffType)
+std::string TraffTypeToString(STG::Tariff::TraffType traffType)

 {
 switch (traffType)
     {
 {
 switch (traffType)
     {

-    case TARIFF::TRAFF_UP:
+    case STG::Tariff::TRAFF_UP:

         return "upload";
         return "upload";

-    case TARIFF::TRAFF_DOWN:
+    case STG::Tariff::TRAFF_DOWN:

         return "download";
         return "download";

-    case TARIFF::TRAFF_UP_DOWN:
+    case STG::Tariff::TRAFF_UP_DOWN:

         return "upload + download";
         return "upload + download";

-    case TARIFF::TRAFF_MAX:
+    case STG::Tariff::TRAFF_MAX:

         return "max(upload, download)";
     }
 return "unknown";
 }
 
         return "max(upload, download)";
     }
 return "unknown";
 }
 

-void ConvPeriod(const std::string & value, RESETABLE<TARIFF::PERIOD> & res)
+void ConvPeriod(const std::string & value, std::optional<STG::Tariff::Period> & res)

 {
 std::string lowered = ToLower(value);
 if (lowered == "daily")
 {
 std::string lowered = ToLower(value);
 if (lowered == "daily")

-    res = TARIFF::DAY;
+    res = STG::Tariff::DAY;

 else if (lowered == "monthly")
 else if (lowered == "monthly")

-    res = TARIFF::MONTH;
+    res = STG::Tariff::MONTH;

 else
     throw SGCONF::ACTION::ERROR("Period should be 'daily' or 'monthly'. Got: '" + value + "'");
 }
 
 else
     throw SGCONF::ACTION::ERROR("Period should be 'daily' or 'monthly'. Got: '" + value + "'");
 }
 

-void ConvChangePolicy(const std::string & value, RESETABLE<TARIFF::CHANGE_POLICY> & res)
+void ConvChangePolicy(const std::string & value, std::optional<STG::Tariff::ChangePolicy> & res)

 {
 std::string lowered = ToLower(value);
 if (lowered == "allow")
 {
 std::string lowered = ToLower(value);
 if (lowered == "allow")

-    res = TARIFF::ALLOW;
+    res = STG::Tariff::ALLOW;

 else if (lowered == "to_cheap")
 else if (lowered == "to_cheap")

-    res = TARIFF::TO_CHEAP;
+    res = STG::Tariff::TO_CHEAP;

 else if (lowered == "to_expensive")
 else if (lowered == "to_expensive")

-    res = TARIFF::TO_EXPENSIVE;
+    res = STG::Tariff::TO_EXPENSIVE;

 else if (lowered == "deny")
 else if (lowered == "deny")

-    res = TARIFF::DENY;
+    res = STG::Tariff::DENY;

 else
     throw SGCONF::ACTION::ERROR("Change policy should be 'allow', 'to_cheap', 'to_expensive' or 'deny'. Got: '" + value + "'");
 }
 
 else
     throw SGCONF::ACTION::ERROR("Change policy should be 'allow', 'to_cheap', 'to_expensive' or 'deny'. Got: '" + value + "'");
 }
 

-void ConvTraffType(const std::string & value, RESETABLE<TARIFF::TRAFF_TYPE> & res)
+void ConvChangePolicyTimeout(const std::string & value, std::optional<time_t> & res)
+{
+struct tm brokenTime;
+if (stg_strptime(value.c_str(), "%Y-%m-%d %H:%M:%S", &brokenTime) == NULL)
+    throw SGCONF::ACTION::ERROR("Credit expiration should be in format 'YYYY-MM-DD HH:MM:SS'. Got: '" + value + "'");
+res = stg_timegm(&brokenTime);
+}
+
+void ConvTraffType(const std::string & value, std::optional<STG::Tariff::TraffType> & res)

 {
 std::string lowered = ToLower(value);
 lowered.erase(std::remove(lowered.begin(), lowered.end(), ' '), lowered.end());
 if (lowered == "upload")
 {
 std::string lowered = ToLower(value);
 lowered.erase(std::remove(lowered.begin(), lowered.end(), ' '), lowered.end());
 if (lowered == "upload")

-    res = TARIFF::TRAFF_UP;
+    res = STG::Tariff::TRAFF_UP;

 else if (lowered == "download")
 else if (lowered == "download")

-    res = TARIFF::TRAFF_DOWN;
+    res = STG::Tariff::TRAFF_DOWN;

 else if (lowered == "upload+download")
 else if (lowered == "upload+download")

-    res = TARIFF::TRAFF_UP_DOWN;
+    res = STG::Tariff::TRAFF_UP_DOWN;

 else if (lowered.substr(0, 3) == "max")
 else if (lowered.substr(0, 3) == "max")

-    res = TARIFF::TRAFF_MAX;
+    res = STG::Tariff::TRAFF_MAX;

 else
     throw SGCONF::ACTION::ERROR("Traff type should be 'upload', 'download', 'upload + download' or 'max'. Got: '" + value + "'");
 }
 
 else
     throw SGCONF::ACTION::ERROR("Traff type should be 'upload', 'download', 'upload + download' or 'max'. Got: '" + value + "'");
 }
 

-DIRPRICE_DATA_RES ConvTimeSpan(const std::string & value)
+STG::DirPriceDataOpt ConvTimeSpan(const std::string & value)

 {
 size_t dashPos = value.find_first_of('-');
 if (dashPos == std::string::npos)
 {
 size_t dashPos = value.find_first_of('-');
 if (dashPos == std::string::npos)


@@ -121,86 +131,86 @@ if (fromColon == std::string::npos || fromColon > dashPos)
 size_t toColon = value.find_first_of(':', dashPos);
 if (toColon == std::string::npos)
     throw SGCONF::ACTION::ERROR("Time span should be in format 'hh:mm-hh:mm'. Got: '" + value + "'");
 size_t toColon = value.find_first_of(':', dashPos);
 if (toColon == std::string::npos)
     throw SGCONF::ACTION::ERROR("Time span should be in format 'hh:mm-hh:mm'. Got: '" + value + "'");

-DIRPRICE_DATA_RES res;
+STG::DirPriceDataOpt res;

 res.hDay = FromString<int>(value.substr(0, fromColon));
 res.hDay = FromString<int>(value.substr(0, fromColon));

-if (res.hDay.data() < 0 || res.hDay.data() > 23)
+if (res.hDay.value() < 0 || res.hDay.value() > 23)

     throw SGCONF::ACTION::ERROR("Invalid 'from' hours. Got: '" + value.substr(0, fromColon) + "'");
 res.mDay = FromString<int>(value.substr(fromColon + 1, dashPos - fromColon - 1));
     throw SGCONF::ACTION::ERROR("Invalid 'from' hours. Got: '" + value.substr(0, fromColon) + "'");
 res.mDay = FromString<int>(value.substr(fromColon + 1, dashPos - fromColon - 1));

-if (res.mDay.data() < 0 || res.mDay.data() > 59)
+if (res.mDay.value() < 0 || res.mDay.value() > 59)

     throw SGCONF::ACTION::ERROR("Invalid 'from' minutes. Got: '" + value.substr(fromColon + 1, dashPos - fromColon - 1) + "'");
 res.hNight = FromString<int>(value.substr(dashPos + 1, toColon - dashPos - 1));
     throw SGCONF::ACTION::ERROR("Invalid 'from' minutes. Got: '" + value.substr(fromColon + 1, dashPos - fromColon - 1) + "'");
 res.hNight = FromString<int>(value.substr(dashPos + 1, toColon - dashPos - 1));

-if (res.hNight.data() < 0 || res.hNight.data() > 23)
+if (res.hNight.value() < 0 || res.hNight.value() > 23)

     throw SGCONF::ACTION::ERROR("Invalid 'to' hours. Got: '" + value.substr(dashPos + 1, toColon - dashPos - 1) + "'");
 res.mNight = FromString<int>(value.substr(toColon + 1, value.length() - toColon));
     throw SGCONF::ACTION::ERROR("Invalid 'to' hours. Got: '" + value.substr(dashPos + 1, toColon - dashPos - 1) + "'");
 res.mNight = FromString<int>(value.substr(toColon + 1, value.length() - toColon));

-if (res.mNight.data() < 0 || res.mNight.data() > 59)
+if (res.mNight.value() < 0 || res.mNight.value() > 59)

     throw SGCONF::ACTION::ERROR("Invalid 'to' minutes. Got: '" + value.substr(toColon + 1, value.length() - toColon) + "'");
 return res;
 }
 
     throw SGCONF::ACTION::ERROR("Invalid 'to' minutes. Got: '" + value.substr(toColon + 1, value.length() - toColon) + "'");
 return res;
 }
 

-void Splice(std::vector<DIRPRICE_DATA_RES> & lhs, const std::vector<DIRPRICE_DATA_RES> & rhs)
+void splice(std::vector<STG::DirPriceDataOpt> & lhs, const std::vector<STG::DirPriceDataOpt> & rhs)

 {
 for (size_t i = 0; i < lhs.size() && i < rhs.size(); ++i)
 {
 for (size_t i = 0; i < lhs.size() && i < rhs.size(); ++i)

-    lhs[i].Splice(rhs[i]);
+    lhs[i].splice(rhs[i]);

 }
 
 }
 

-void ConvTimes(std::string value, std::vector<DIRPRICE_DATA_RES> & res)
+void ConvTimes(std::string value, std::vector<STG::DirPriceDataOpt> & res)

 {
 value.erase(std::remove(value.begin(), value.end(), ' '), value.end());
 {
 value.erase(std::remove(value.begin(), value.end(), ' '), value.end());

-Splice(res, Split<std::vector<DIRPRICE_DATA_RES> >(value, ',', ConvTimeSpan));
+splice(res, Split<std::vector<STG::DirPriceDataOpt> >(value, ',', ConvTimeSpan));

 }
 
 }
 

-struct ConvPrice : public std::unary_function<std::string, DIRPRICE_DATA_RES>
+struct ConvPrice

 {
 {

-    typedef RESETABLE<double> (DIRPRICE_DATA_RES::* MemPtr);
+    using MemPtr = std::optional<double> (STG::DirPriceDataOpt::*);

     ConvPrice(MemPtr before, MemPtr after)
         : m_before(before), m_after(after)
     {}
 
     ConvPrice(MemPtr before, MemPtr after)
         : m_before(before), m_after(after)
     {}
 

-    DIRPRICE_DATA_RES operator()(const std::string & value)
+    STG::DirPriceDataOpt operator()(const std::string & value)

     {
     {

-    DIRPRICE_DATA_RES res;
-    size_t slashPos = value.find_first_of('/');
-    if (slashPos == std::string::npos)
+        STG::DirPriceDataOpt res;
+        size_t slashPos = value.find_first_of('/');
+        if (slashPos == std::string::npos)

         {
         {

-        double price = 0;
-        if (str2x(value, price) < 0)
-            throw SGCONF::ACTION::ERROR("Price should be a floating point number. Got: '" + value + "'");
-        (res.*m_before) = (res.*m_after) = price;
-        res.noDiscount = true;
+            double price = 0;
+            if (str2x(value, price) < 0)
+                throw SGCONF::ACTION::ERROR("Price should be a floating point number. Got: '" + value + "'");
+            (res.*m_before) = (res.*m_after) = price;
+            res.noDiscount = true;

         }
         }

-    else
+        else

         {
         {

-        double price = 0;
-        if (str2x(value.substr(0, slashPos), price) < 0)
-            throw SGCONF::ACTION::ERROR("Price should be a floating point number. Got: '" + value.substr(0, slashPos) + "'");
-        (res.*m_before) = price;
-        if (str2x(value.substr(slashPos + 1, value.length() - slashPos), price) < 0)
-            throw SGCONF::ACTION::ERROR("Price should be a floating point number. Got: '" + value.substr(slashPos + 1, value.length() - slashPos) + "'");
-        (res.*m_after) = price;
-        res.noDiscount = false;
+            double price = 0;
+            if (str2x(value.substr(0, slashPos), price) < 0)
+                throw SGCONF::ACTION::ERROR("Price should be a floating point number. Got: '" + value.substr(0, slashPos) + "'");
+            (res.*m_before) = price;
+            if (str2x(value.substr(slashPos + 1, value.length() - slashPos), price) < 0)
+                throw SGCONF::ACTION::ERROR("Price should be a floating point number. Got: '" + value.substr(slashPos + 1, value.length() - slashPos) + "'");
+            (res.*m_after) = price;
+            res.noDiscount = false;

         }
         }

-    return res;
+        return res;

     }
 
     MemPtr m_before;
     MemPtr m_after;
 };
 
     }
 
     MemPtr m_before;
     MemPtr m_after;
 };
 

-void ConvDayPrices(std::string value, std::vector<DIRPRICE_DATA_RES> & res)
+void ConvDayPrices(std::string value, std::vector<STG::DirPriceDataOpt> & res)

 {
 value.erase(std::remove(value.begin(), value.end(), ' '), value.end());
 {
 value.erase(std::remove(value.begin(), value.end(), ' '), value.end());

-Splice(res, Split<std::vector<DIRPRICE_DATA_RES> >(value, ',', ConvPrice(&DIRPRICE_DATA_RES::priceDayA, &DIRPRICE_DATA_RES::priceDayB)));
+splice(res, Split<std::vector<STG::DirPriceDataOpt> >(value, ',', ConvPrice(&STG::DirPriceDataOpt::priceDayA, &STG::DirPriceDataOpt::priceDayB)));

 }
 
 }
 

-void ConvNightPrices(std::string value, std::vector<DIRPRICE_DATA_RES> & res)
+void ConvNightPrices(std::string value, std::vector<STG::DirPriceDataOpt> & res)

 {
 value.erase(std::remove(value.begin(), value.end(), ' '), value.end());
 {
 value.erase(std::remove(value.begin(), value.end(), ' '), value.end());

-Splice(res, Split<std::vector<DIRPRICE_DATA_RES> >(value, ',', ConvPrice(&DIRPRICE_DATA_RES::priceNightA, &DIRPRICE_DATA_RES::priceNightB)));
+splice(res, Split<std::vector<STG::DirPriceDataOpt> >(value, ',', ConvPrice(&STG::DirPriceDataOpt::priceNightA, &STG::DirPriceDataOpt::priceNightB)));

 }
 
 }
 

-DIRPRICE_DATA_RES ConvThreshold(std::string value)
+STG::DirPriceDataOpt ConvThreshold(std::string value)

 {
 {

-DIRPRICE_DATA_RES res;
+    STG::DirPriceDataOpt res;

 double threshold = 0;
 if (str2x(value, threshold) < 0)
     throw SGCONF::ACTION::ERROR("Threshold should be a floating point value. Got: '" + value + "'");
 double threshold = 0;
 if (str2x(value, threshold) < 0)
     throw SGCONF::ACTION::ERROR("Threshold should be a floating point value. Got: '" + value + "'");


@@ -208,10 +218,10 @@ res.threshold = threshold;
 return res;
 }
 
 return res;
 }
 

-void ConvThresholds(std::string value, std::vector<DIRPRICE_DATA_RES> & res)
+void ConvThresholds(std::string value, std::vector<STG::DirPriceDataOpt> & res)

 {
 value.erase(std::remove(value.begin(), value.end(), ' '), value.end());
 {
 value.erase(std::remove(value.begin(), value.end(), ' '), value.end());

-Splice(res, Split<std::vector<DIRPRICE_DATA_RES> >(value, ',', ConvThreshold));
+splice(res, Split<std::vector<STG::DirPriceDataOpt> >(value, ',', ConvThreshold));

 }
 
 std::string TimeToString(int h, int m)
 }
 
 std::string TimeToString(int h, int m)


@@ -222,7 +232,7 @@ stream << (h < 10 ? "0" : "") << h << ":"
 return stream.str();
 }
 
 return stream.str();
 }
 

-void PrintDirPriceData(size_t dir, const DIRPRICE_DATA & data, size_t level)
+void PrintDirPriceData(size_t dir, const STG::DirPriceData & data, size_t level)

 {
 std::string night = TimeToString(data.hNight, data.mNight);
 std::string day = TimeToString(data.hDay, data.mDay);
 {
 std::string night = TimeToString(data.hNight, data.mNight);
 std::string day = TimeToString(data.hDay, data.mDay);


@@ -234,7 +244,7 @@ std::cout << Indent(level, true) << "dir: " << dir << "\n"
           << Indent(level)       << "discount: " << (data.noDiscount ? "no" : "yes") << "\n"; // Attention!
 }
 
           << Indent(level)       << "discount: " << (data.noDiscount ? "no" : "yes") << "\n"; // Attention!
 }
 

-void PrintTariffConf(const TARIFF_CONF & conf, size_t level)
+void PrintTariffConf(const STG::TariffConf & conf, size_t level)

 {
 std::cout << Indent(level, true) << "name: " << conf.name << "\n"
           << Indent(level)       << "fee: " << conf.fee << "\n"
 {
 std::cout << Indent(level, true) << "name: " << conf.name << "\n"
           << Indent(level)       << "fee: " << conf.fee << "\n"


@@ -246,7 +256,7 @@ std::cout << Indent(level, true) << "name: " << conf.name << "\n"
           << Indent(level)       << "change policy timeout: " << formatTime(conf.changePolicyTimeout) << "\n";
 }
 
           << Indent(level)       << "change policy timeout: " << formatTime(conf.changePolicyTimeout) << "\n";
 }
 

-void PrintTariff(const STG::GET_TARIFF::INFO & info, size_t level = 0)
+void PrintTariff(const STG::GetTariff::Info & info, size_t level = 0)

 {
 PrintTariffConf(info.tariffConf, level);
 std::cout << Indent(level) << "dir prices:\n";
 {
 PrintTariffConf(info.tariffConf, level);
 std::cout << Indent(level) << "dir prices:\n";


@@ -285,7 +295,7 @@ std::cout << "Success.\n";
 
 void GetTariffsCallback(bool result,
                         const std::string & reason,
 
 void GetTariffsCallback(bool result,
                         const std::string & reason,

-                        const std::vector<STG::GET_TARIFF::INFO> & info,
+                        const std::vector<STG::GetTariff::Info> & info,

                         void * /*data*/)
 {
 if (!result)
                         void * /*data*/)
 {
 if (!result)


@@ -300,7 +310,7 @@ for (size_t i = 0; i < info.size(); ++i)
 
 void GetTariffCallback(bool result,
                        const std::string & reason,
 
 void GetTariffCallback(bool result,
                        const std::string & reason,

-                       const std::vector<STG::GET_TARIFF::INFO> & info,
+                       const std::vector<STG::GetTariff::Info> & info,

                        void * data)
 {
 assert(data != NULL && "Expecting pointer to std::string with the tariff's name.");
                        void * data)
 {
 assert(data != NULL && "Expecting pointer to std::string with the tariff's name.");


@@ -319,49 +329,31 @@ bool GetTariffsFunction(const SGCONF::CONFIG & config,
                         const std::string & /*arg*/,
                         const std::map<std::string, std::string> & /*options*/)
 {
                         const std::string & /*arg*/,
                         const std::map<std::string, std::string> & /*options*/)
 {

-STG::SERVCONF proto(config.server.data(),
-                    config.port.data(),
-                    config.localAddress.data(),
-                    config.localPort.data(),
-                    config.userName.data(),
-                    config.userPass.data());
-return proto.GetTariffs(GetTariffsCallback, NULL) == STG::st_ok;
+return makeProto(config).GetTariffs(GetTariffsCallback, NULL) == STG::st_ok;

 }
 
 bool GetTariffFunction(const SGCONF::CONFIG & config,
                        const std::string & arg,
                        const std::map<std::string, std::string> & /*options*/)
 {
 }
 
 bool GetTariffFunction(const SGCONF::CONFIG & config,
                        const std::string & arg,
                        const std::map<std::string, std::string> & /*options*/)
 {

-STG::SERVCONF proto(config.server.data(),
-                    config.port.data(),
-                    config.localAddress.data(),
-                    config.localPort.data(),
-                    config.userName.data(),
-                    config.userPass.data());

 // STG currently doesn't support <GetTariff name="..."/>.
 // So get a list of tariffs and filter it. 'data' param holds a pointer to 'name'.
 std::string name(arg);
 // STG currently doesn't support <GetTariff name="..."/>.
 // So get a list of tariffs and filter it. 'data' param holds a pointer to 'name'.
 std::string name(arg);

-return proto.GetTariffs(GetTariffCallback, &name) == STG::st_ok;
+return makeProto(config).GetTariffs(GetTariffCallback, &name) == STG::st_ok;

 }
 
 bool DelTariffFunction(const SGCONF::CONFIG & config,
                        const std::string & arg,
                        const std::map<std::string, std::string> & /*options*/)
 {
 }
 
 bool DelTariffFunction(const SGCONF::CONFIG & config,
                        const std::string & arg,
                        const std::map<std::string, std::string> & /*options*/)
 {

-STG::SERVCONF proto(config.server.data(),
-                    config.port.data(),
-                    config.localAddress.data(),
-                    config.localPort.data(),
-                    config.userName.data(),
-                    config.userPass.data());
-return proto.DelTariff(arg, SimpleCallback, NULL) == STG::st_ok;
+return makeProto(config).DelTariff(arg, SimpleCallback, NULL) == STG::st_ok;

 }
 
 bool AddTariffFunction(const SGCONF::CONFIG & config,
                        const std::string & arg,
                        const std::map<std::string, std::string> & options)
 {
 }
 
 bool AddTariffFunction(const SGCONF::CONFIG & config,
                        const std::string & arg,
                        const std::map<std::string, std::string> & options)
 {

-TARIFF_DATA_RES conf;
+STG::TariffDataOpt conf;

 conf.tariffConf.name = arg;
 SGCONF::MaybeSet(options, "fee", conf.tariffConf.fee);
 SGCONF::MaybeSet(options, "free", conf.tariffConf.free);
 conf.tariffConf.name = arg;
 SGCONF::MaybeSet(options, "fee", conf.tariffConf.fee);
 SGCONF::MaybeSet(options, "free", conf.tariffConf.free);


@@ -369,34 +361,28 @@ SGCONF::MaybeSet(options, "passive-cost", conf.tariffConf.passiveCost);
 SGCONF::MaybeSet(options, "traff-type", conf.tariffConf.traffType, ConvTraffType);
 SGCONF::MaybeSet(options, "period", conf.tariffConf.period, ConvPeriod);
 SGCONF::MaybeSet(options, "change-policy", conf.tariffConf.changePolicy, ConvChangePolicy);
 SGCONF::MaybeSet(options, "traff-type", conf.tariffConf.traffType, ConvTraffType);
 SGCONF::MaybeSet(options, "period", conf.tariffConf.period, ConvPeriod);
 SGCONF::MaybeSet(options, "change-policy", conf.tariffConf.changePolicy, ConvChangePolicy);

-SGCONF::MaybeSet(options, "change-policy-timeout", conf.tariffConf.changePolicyTimeout, readTime(conf.tariffConf.changePolicyTimeout));
+SGCONF::MaybeSet(options, "change-policy-timeout", conf.tariffConf.changePolicyTimeout, ConvChangePolicyTimeout);

 SGCONF::MaybeSet(options, "times", conf.dirPrice, ConvTimes);
 SGCONF::MaybeSet(options, "day-prices", conf.dirPrice, ConvDayPrices);
 SGCONF::MaybeSet(options, "night-prices", conf.dirPrice, ConvNightPrices);
 SGCONF::MaybeSet(options, "thresholds", conf.dirPrice, ConvThresholds);
 for (size_t i = 0; i < conf.dirPrice.size(); ++i)
     {
 SGCONF::MaybeSet(options, "times", conf.dirPrice, ConvTimes);
 SGCONF::MaybeSet(options, "day-prices", conf.dirPrice, ConvDayPrices);
 SGCONF::MaybeSet(options, "night-prices", conf.dirPrice, ConvNightPrices);
 SGCONF::MaybeSet(options, "thresholds", conf.dirPrice, ConvThresholds);
 for (size_t i = 0; i < conf.dirPrice.size(); ++i)
     {

-    if (!conf.dirPrice[i].priceDayA.empty() &&
-        !conf.dirPrice[i].priceNightA.empty() &&
-        !conf.dirPrice[i].priceDayB.empty() &&
-        !conf.dirPrice[i].priceNightB.empty())
-        conf.dirPrice[i].singlePrice = conf.dirPrice[i].priceDayA.data() == conf.dirPrice[i].priceNightA.data() &&
-                                       conf.dirPrice[i].priceDayB.data() == conf.dirPrice[i].priceNightB.data();
+    if (conf.dirPrice[i].priceDayA ||
+        conf.dirPrice[i].priceNightA ||
+        conf.dirPrice[i].priceDayB ||
+        conf.dirPrice[i].priceNightB)
+        conf.dirPrice[i].singlePrice = conf.dirPrice[i].priceDayA.value() == conf.dirPrice[i].priceNightA.value() &&
+                                       conf.dirPrice[i].priceDayB.value() == conf.dirPrice[i].priceNightB.value();

     }
     }

-STG::SERVCONF proto(config.server.data(),
-                    config.port.data(),
-                    config.localAddress.data(),
-                    config.localPort.data(),
-                    config.userName.data(),
-                    config.userPass.data());
-return proto.AddTariff(arg, conf, SimpleCallback, NULL) == STG::st_ok;
+return makeProto(config).AddTariff(arg, conf, SimpleCallback, NULL) == STG::st_ok;

 }
 
 bool ChgTariffFunction(const SGCONF::CONFIG & config,
                        const std::string & arg,
                        const std::map<std::string, std::string> & options)
 {
 }
 
 bool ChgTariffFunction(const SGCONF::CONFIG & config,
                        const std::string & arg,
                        const std::map<std::string, std::string> & options)
 {

-TARIFF_DATA_RES conf;
+STG::TariffDataOpt conf;

 conf.tariffConf.name = arg;
 SGCONF::MaybeSet(options, "fee", conf.tariffConf.fee);
 SGCONF::MaybeSet(options, "free", conf.tariffConf.free);
 conf.tariffConf.name = arg;
 SGCONF::MaybeSet(options, "fee", conf.tariffConf.fee);
 SGCONF::MaybeSet(options, "free", conf.tariffConf.free);


@@ -404,26 +390,21 @@ SGCONF::MaybeSet(options, "passive-cost", conf.tariffConf.passiveCost);
 SGCONF::MaybeSet(options, "traff-type", conf.tariffConf.traffType, ConvTraffType);
 SGCONF::MaybeSet(options, "period", conf.tariffConf.period, ConvPeriod);
 SGCONF::MaybeSet(options, "change-policy", conf.tariffConf.changePolicy, ConvChangePolicy);
 SGCONF::MaybeSet(options, "traff-type", conf.tariffConf.traffType, ConvTraffType);
 SGCONF::MaybeSet(options, "period", conf.tariffConf.period, ConvPeriod);
 SGCONF::MaybeSet(options, "change-policy", conf.tariffConf.changePolicy, ConvChangePolicy);

+SGCONF::MaybeSet(options, "change-policy-timeout", conf.tariffConf.changePolicyTimeout, ConvChangePolicyTimeout);

 SGCONF::MaybeSet(options, "times", conf.dirPrice, ConvTimes);
 SGCONF::MaybeSet(options, "day-prices", conf.dirPrice, ConvDayPrices);
 SGCONF::MaybeSet(options, "night-prices", conf.dirPrice, ConvNightPrices);
 SGCONF::MaybeSet(options, "thresholds", conf.dirPrice, ConvThresholds);
 for (size_t i = 0; i < conf.dirPrice.size(); ++i)
     {
 SGCONF::MaybeSet(options, "times", conf.dirPrice, ConvTimes);
 SGCONF::MaybeSet(options, "day-prices", conf.dirPrice, ConvDayPrices);
 SGCONF::MaybeSet(options, "night-prices", conf.dirPrice, ConvNightPrices);
 SGCONF::MaybeSet(options, "thresholds", conf.dirPrice, ConvThresholds);
 for (size_t i = 0; i < conf.dirPrice.size(); ++i)
     {

-    if (!conf.dirPrice[i].priceDayA.empty() &&
-        !conf.dirPrice[i].priceNightA.empty() &&
-        !conf.dirPrice[i].priceDayB.empty() &&
-        !conf.dirPrice[i].priceNightB.empty())
-        conf.dirPrice[i].singlePrice = conf.dirPrice[i].priceDayA.data() == conf.dirPrice[i].priceNightA.data() &&
-                                       conf.dirPrice[i].priceDayB.data() == conf.dirPrice[i].priceNightB.data();
+    if (conf.dirPrice[i].priceDayA ||
+        conf.dirPrice[i].priceNightA ||
+        conf.dirPrice[i].priceDayB ||
+        conf.dirPrice[i].priceNightB)
+        conf.dirPrice[i].singlePrice = conf.dirPrice[i].priceDayA.value() == conf.dirPrice[i].priceNightA.value() &&
+                                       conf.dirPrice[i].priceDayB.value() == conf.dirPrice[i].priceNightB.value();

     }
     }

-STG::SERVCONF proto(config.server.data(),
-                    config.port.data(),
-                    config.localAddress.data(),
-                    config.localPort.data(),
-                    config.userName.data(),
-                    config.userPass.data());
-return proto.ChgTariff(conf, SimpleCallback, NULL) == STG::st_ok;
+return makeProto(config).ChgTariff(conf, SimpleCallback, NULL) == STG::st_ok;

 }
 
 } // namespace anonymous
 }
 
 } // namespace anonymous