Apply some Clang Tidy suggestions.

[stg.git] / projects / stargazer / plugins / other / smux / smux.cpp

diff --git a/projects/stargazer/plugins/other/smux/smux.cpp b/projects/stargazer/plugins/other/smux/smux.cpp
index 23d5f05fdc71bae163c9e759af08f90dd1a15f55..f79085dff1250bc3978420ac35975a06cf05e0dd 100644 (file)
--- a/projects/stargazer/plugins/other/smux/smux.cpp
+++ b/projects/stargazer/plugins/other/smux/smux.cpp
@@ -15,23 +15,12 @@
 #include <utility>
 
 #include "stg/common.h"
 #include <utility>
 
 #include "stg/common.h"

-#include "stg/plugin_creator.h"
-/*#include "stg/users.h"
-#include "stg/tariffs.h"
-#include "stg/admins.h"
-#include "stg/services.h"
-#include "stg/corporations.h"
-#include "stg/traffcounter.h"*/

 
 #include "smux.h"
 #include "utils.h"
 
 
 #include "smux.h"
 #include "utils.h"
 

-PLUGIN_CREATOR<SMUX> smc;
-
-PLUGIN * GetPlugin()
+namespace

 {
 {

-return smc.GetPlugin();
-}

 
 bool SPrefixLess(const Sensors::value_type & a,
                  const Sensors::value_type & b)
 
 bool SPrefixLess(const Sensors::value_type & a,
                  const Sensors::value_type & b)


@@ -39,36 +28,43 @@ bool SPrefixLess(const Sensors::value_type & a,
 return a.first.PrefixLess(b.first);
 }
 
 return a.first.PrefixLess(b.first);
 }
 

+}
+
+extern "C" STG::Plugin* GetPlugin()
+{
+    static SMUX plugin;
+    return &plugin;
+}
+

 SMUX_SETTINGS::SMUX_SETTINGS()
     : ip(0),
       port(0)
 {}
 
 SMUX_SETTINGS::SMUX_SETTINGS()
     : ip(0),
       port(0)
 {}
 

-int SMUX_SETTINGS::ParseSettings(const MODULE_SETTINGS & s)
+int SMUX_SETTINGS::ParseSettings(const STG::ModuleSettings & s)

 {
 {

-PARAM_VALUE pv;
-std::vector<PARAM_VALUE>::const_iterator pvi;
+STG::ParamValue pv;

 int p;
 
 pv.param = "Port";
 int p;
 
 pv.param = "Port";

-pvi = std::find(s.moduleParams.begin(), s.moduleParams.end(), pv);
-if (pvi == s.moduleParams.end())
+auto pvi = std::find(s.moduleParams.begin(), s.moduleParams.end(), pv);
+if (pvi == s.moduleParams.end() || pvi->value.empty())

     {
     errorStr = "Parameter \'Port\' not found.";
     printfd(__FILE__, "Parameter 'Port' not found\n");
     return -1;
     }
     {
     errorStr = "Parameter \'Port\' not found.";
     printfd(__FILE__, "Parameter 'Port' not found\n");
     return -1;
     }

-if (ParseIntInRange(pvi->value[0], 2, 65535, &p))
+if (ParseIntInRange(pvi->value[0], 2, 65535, &p) != 0)

     {
     errorStr = "Cannot parse parameter \'Port\': " + errorStr;
     printfd(__FILE__, "Cannot parse parameter 'Port'\n");
     return -1;
     }
     {
     errorStr = "Cannot parse parameter \'Port\': " + errorStr;
     printfd(__FILE__, "Cannot parse parameter 'Port'\n");
     return -1;
     }

-port = p;
+port = static_cast<uint16_t>(p);

 
 pv.param = "Password";
 pvi = std::find(s.moduleParams.begin(), s.moduleParams.end(), pv);
 
 pv.param = "Password";
 pvi = std::find(s.moduleParams.begin(), s.moduleParams.end(), pv);

-if (pvi == s.moduleParams.end())
+if (pvi == s.moduleParams.end() || pvi->value.empty())

     {
     errorStr = "Parameter \'Password\' not found.";
     printfd(__FILE__, "Parameter 'Password' not found\n");
     {
     errorStr = "Parameter \'Password\' not found.";
     printfd(__FILE__, "Parameter 'Password' not found\n");


@@ -81,7 +77,7 @@ else
 
 pv.param = "Server";
 pvi = std::find(s.moduleParams.begin(), s.moduleParams.end(), pv);
 
 pv.param = "Server";
 pvi = std::find(s.moduleParams.begin(), s.moduleParams.end(), pv);

-if (pvi == s.moduleParams.end())
+if (pvi == s.moduleParams.end() || pvi->value.empty())

     {
     errorStr = "Parameter \'Server\' not found.";
     printfd(__FILE__, "Parameter 'Server' not found\n");
     {
     errorStr = "Parameter \'Server\' not found.";
     printfd(__FILE__, "Parameter 'Server' not found\n");


@@ -93,25 +89,22 @@ return 0;
 }
 
 SMUX::SMUX()
 }
 
 SMUX::SMUX()

-    : PLUGIN(),
-      users(NULL),
-      tariffs(NULL),
-      admins(NULL),
-      services(NULL),
-      corporations(NULL),
-      traffcounter(NULL),
-      running(false),
+    : users(nullptr),
+      tariffs(nullptr),
+      admins(nullptr),
+      services(nullptr),
+      corporations(nullptr),
+      traffcounter(nullptr),

       stopped(true),
       stopped(true),

+      needReconnect(false),
+      lastReconnectTry(0),
+      reconnectTimeout(1),

       sock(-1),
       sock(-1),

-      smuxHandlers(),
-      pdusHandlers(),
-      sensors(),
-      tables(),
-      notifiers(),
-      addDelNotifier(*this)
+      addUserNotifier(*this),
+      delUserNotifier(*this),
+      addDelTariffNotifier(*this),
+      logger(STG::PluginLogger::get("smux"))

 {
 {

-pthread_mutex_init(&mutex, NULL);
-

 smuxHandlers[SMUX_PDUs_PR_close] = &SMUX::CloseHandler;
 smuxHandlers[SMUX_PDUs_PR_registerResponse] = &SMUX::RegisterResponseHandler;
 smuxHandlers[SMUX_PDUs_PR_pdus] = &SMUX::PDUsRequestHandler;
 smuxHandlers[SMUX_PDUs_PR_close] = &SMUX::CloseHandler;
 smuxHandlers[SMUX_PDUs_PR_registerResponse] = &SMUX::RegisterResponseHandler;
 smuxHandlers[SMUX_PDUs_PR_pdus] = &SMUX::PDUsRequestHandler;


@@ -124,18 +117,11 @@ pdusHandlers[PDUs_PR_set_request] = &SMUX::SetRequestHandler;
 
 SMUX::~SMUX()
 {
 
 SMUX::~SMUX()
 {

-    {
-    Sensors::iterator it;
-    for (it = sensors.begin(); it != sensors.end(); ++it)
-        delete it->second;
-    }
-    {
-    Tables::iterator it;
-    for (it = tables.begin(); it != tables.end(); ++it)
-        delete it->second;
-    }
-printfd(__FILE__, "SMUX::~SMUX()\n");
-pthread_mutex_destroy(&mutex);
+    for (auto& kv : sensors)
+        delete kv.second;
+    for (auto& kv : tables)
+        delete kv.second;
+    printfd(__FILE__, "SMUX::~SMUX()\n");

 }
 
 int SMUX::ParseSettings()
 }
 
 int SMUX::ParseSettings()


@@ -145,15 +131,15 @@ return smuxSettings.ParseSettings(settings);
 
 int SMUX::Start()
 {
 
 int SMUX::Start()
 {

-assert(users != NULL && "users must not be NULL");
-assert(tariffs != NULL && "tariffs must not be NULL");
-assert(admins != NULL && "admins must not be NULL");
-assert(services != NULL && "services must not be NULL");
-assert(corporations != NULL && "corporations must not be NULL");
-assert(traffcounter != NULL && "traffcounter must not be NULL");
+assert(users != nullptr && "users must not be NULL");
+assert(tariffs != nullptr && "tariffs must not be NULL");
+assert(admins != nullptr && "admins must not be NULL");
+assert(services != nullptr && "services must not be NULL");
+assert(corporations != nullptr && "corporations must not be NULL");
+assert(traffcounter != nullptr && "traffcounter must not be NULL");

 
 if (PrepareNet())
 
 if (PrepareNet())

-    return -1;
+    needReconnect = true;

 
 // Users
 sensors[OID(".1.3.6.1.4.1.38313.1.1.1")] = new TotalUsersSensor(*users);
 
 // Users
 sensors[OID(".1.3.6.1.4.1.38313.1.1.1")] = new TotalUsersSensor(*users);


@@ -161,12 +147,13 @@ sensors[OID(".1.3.6.1.4.1.38313.1.1.2")] = new ConnectedUsersSensor(*users);
 sensors[OID(".1.3.6.1.4.1.38313.1.1.3")] = new AuthorizedUsersSensor(*users);
 sensors[OID(".1.3.6.1.4.1.38313.1.1.4")] = new AlwaysOnlineUsersSensor(*users);
 sensors[OID(".1.3.6.1.4.1.38313.1.1.5")] = new NoCashUsersSensor(*users);
 sensors[OID(".1.3.6.1.4.1.38313.1.1.3")] = new AuthorizedUsersSensor(*users);
 sensors[OID(".1.3.6.1.4.1.38313.1.1.4")] = new AlwaysOnlineUsersSensor(*users);
 sensors[OID(".1.3.6.1.4.1.38313.1.1.5")] = new NoCashUsersSensor(*users);

-sensors[OID(".1.3.6.1.4.1.38313.1.1.7")] = new DisabledDetailStatsUsersSensor(*users);
-sensors[OID(".1.3.6.1.4.1.38313.1.1.8")] = new DisabledUsersSensor(*users);
-sensors[OID(".1.3.6.1.4.1.38313.1.1.9")] = new PassiveUsersSensor(*users);
-sensors[OID(".1.3.6.1.4.1.38313.1.1.10")] = new CreditUsersSensor(*users);
-sensors[OID(".1.3.6.1.4.1.38313.1.1.11")] = new FreeMbUsersSensor(*users);
-sensors[OID(".1.3.6.1.4.1.38313.1.1.12")] = new TariffChangeUsersSensor(*users);
+sensors[OID(".1.3.6.1.4.1.38313.1.1.6")] = new DisabledDetailStatsUsersSensor(*users);
+sensors[OID(".1.3.6.1.4.1.38313.1.1.7")] = new DisabledUsersSensor(*users);
+sensors[OID(".1.3.6.1.4.1.38313.1.1.8")] = new PassiveUsersSensor(*users);
+sensors[OID(".1.3.6.1.4.1.38313.1.1.9")] = new CreditUsersSensor(*users);
+sensors[OID(".1.3.6.1.4.1.38313.1.1.10")] = new FreeMbUsersSensor(*users);
+sensors[OID(".1.3.6.1.4.1.38313.1.1.11")] = new TariffChangeUsersSensor(*users);
+sensors[OID(".1.3.6.1.4.1.38313.1.1.12")] = new ActiveUsersSensor(*users);

 // Tariffs
 sensors[OID(".1.3.6.1.4.1.38313.1.2.1")] = new TotalTariffsSensor(*tariffs);
 // Admins
 // Tariffs
 sensors[OID(".1.3.6.1.4.1.38313.1.2.1")] = new TotalTariffsSensor(*tariffs);
 // Admins


@@ -179,15 +166,13 @@ sensors[OID(".1.3.6.1.4.1.38313.1.5.1")] = new TotalCorporationsSensor(*corporat
 sensors[OID(".1.3.6.1.4.1.38313.1.6.1")] = new TotalRulesSensor(*traffcounter);
 
 // Table data
 sensors[OID(".1.3.6.1.4.1.38313.1.6.1")] = new TotalRulesSensor(*traffcounter);
 
 // Table data

-tables[".1.3.6.1.4.1.38313.1.1.6"] = new TariffUsersTable(".1.3.6.1.4.1.38313.1.1.6", *tariffs, *users);
+tables[".1.3.6.1.4.1.38313.1.2.2"] = new TariffUsersTable(".1.3.6.1.4.1.38313.1.2.2", *tariffs, *users);

 
 UpdateTables();
 SetNotifiers();
 
 UpdateTables();
 SetNotifiers();

-users->AddNotifierUserAdd(&addDelNotifier);
-users->AddNotifierUserDel(&addDelNotifier);

 
 

-#ifdef DEBUG
-Sensors::const_iterator it(sensors.begin());
+#ifdef SMUX_DEBUG
+auto it = sensors.begin();

 while (it != sensors.end())
     {
     printfd(__FILE__, "%s = %s\n",
 while (it != sensors.end())
     {
     printfd(__FILE__, "%s = %s\n",


@@ -197,15 +182,8 @@ while (it != sensors.end())
     }
 #endif
 
     }
 #endif
 

-if (!running)
-    {
-    if (pthread_create(&thread, NULL, Runner, this))
-        {
-        errorStr = "Cannot create thread.";
-        printfd(__FILE__, "Cannot create thread\n");
-        return -1;
-        }
-    }
+if (!m_thread.joinable())
+    m_thread = std::jthread([this](auto token){ Run(std::move(token)); });

 
 return 0;
 }
 
 return 0;
 }


@@ -213,11 +191,7 @@ return 0;
 int SMUX::Stop()
 {
 printfd(__FILE__, "SMUX::Stop() - Before\n");
 int SMUX::Stop()
 {
 printfd(__FILE__, "SMUX::Stop() - Before\n");

-running = false;
-
-users->DelNotifierUserDel(&addDelNotifier);
-users->DelNotifierUserAdd(&addDelNotifier);
-ResetNotifiers();
+m_thread.request_stop();

 
 if (!stopped)
     {
 
 if (!stopped)
     {


@@ -225,59 +199,75 @@ if (!stopped)
     for (int i = 0; i < 25 && !stopped; i++)
         {
         struct timespec ts = {0, 200000000};
     for (int i = 0; i < 25 && !stopped; i++)
         {
         struct timespec ts = {0, 200000000};

-        nanosleep(&ts, NULL);
-        }
-
-    //after 5 seconds waiting thread still running. now killing it
-    if (!stopped)
-        {
-        printfd(__FILE__, "SMUX::Stop() - failed to stop thread, killing it\n");
-        if (pthread_kill(thread, SIGINT))
-            {
-            errorStr = "Cannot kill thread.";
-            printfd(__FILE__, "SMUX::Stop() - Cannot kill thread\n");
-            return -1;
-            }
-        printfd(__FILE__, "SMUX::Stop() -  killed Run\n");
+        nanosleep(&ts, nullptr);

         }
     }
 
         }
     }
 

-pthread_join(thread, NULL);
+if (!stopped)
+    m_thread.detach();
+else
+    m_thread.join();
+
+ResetNotifiers();
+
+for (auto& kv : sensors)
+    delete kv.second;
+for (auto& kv : tables)
+    delete kv.second;
+
+tables.erase(tables.begin(), tables.end());
+sensors.erase(sensors.begin(), sensors.end());

 
 close(sock);
 
 
 close(sock);
 

+if (!stopped)
+    {
+    return -1;
+    }
+

 printfd(__FILE__, "SMUX::Stop() - After\n");
 return 0;
 }
 
 printfd(__FILE__, "SMUX::Stop() - After\n");
 return 0;
 }
 

-void * SMUX::Runner(void * d)
+int SMUX::Reload(const STG::ModuleSettings & /*ms*/)

 {
 {

-SMUX * smux = static_cast<SMUX *>(d);
-
-smux->Run();
-
-return NULL;
+if (Stop() != 0)
+    return -1;
+if (Start() != 0)
+    return -1;
+if (!needReconnect)
+    {
+    printfd(__FILE__, "SMUX reconnected succesfully.\n");
+    logger("Reconnected successfully.");
+    }
+return 0;

 }
 
 }
 

-void SMUX::Run()
+void SMUX::Run(std::stop_token token)

 {
 {

-SendOpenPDU(sock);
-SendRReqPDU(sock);
-running = true;
+stopped = true;
+if (!SendOpenPDU(sock))
+    needReconnect = true;
+if (!SendRReqPDU(sock))
+    needReconnect = true;

 stopped = false;
 
 stopped = false;
 

-while(running)
+while (!token.stop_requested())

     {
     {

-    if (WaitPackets(sock))
+    if (WaitPackets(sock) && !needReconnect)

         {
         {

-        SMUX_PDUs_t * pdus = RecvSMUXPDUs(sock);
-        if (pdus)
+        auto* pdus = RecvSMUXPDUs(sock);
+        if (pdus != nullptr)

             {
             DispatchPDUs(pdus);
             ASN_STRUCT_FREE(asn_DEF_SMUX_PDUs, pdus);
             }
             {
             DispatchPDUs(pdus);
             ASN_STRUCT_FREE(asn_DEF_SMUX_PDUs, pdus);
             }

+        else if (!token.stop_requested())
+            Reconnect();

         }
         }

-    if (!running)
+    else if (!token.stop_requested() && needReconnect)
+        Reconnect();
+    if (token.stop_requested())

         break;
     }
 SendClosePDU(sock);
         break;
     }
 SendClosePDU(sock);


@@ -291,6 +281,7 @@ sock = socket(AF_INET, SOCK_STREAM, 0);
 if (sock < 0)
     {
     errorStr = "Cannot create socket.";
 if (sock < 0)
     {
     errorStr = "Cannot create socket.";

+    logger("Cannot create a socket: %s", strerror(errno));

     printfd(__FILE__, "Cannot create socket\n");
     return true;
     }
     printfd(__FILE__, "Cannot create socket\n");
     return true;
     }


@@ -301,9 +292,10 @@ addr.sin_family = AF_INET;
 addr.sin_port = htons(smuxSettings.GetPort());
 addr.sin_addr.s_addr = smuxSettings.GetIP();
 
 addr.sin_port = htons(smuxSettings.GetPort());
 addr.sin_addr.s_addr = smuxSettings.GetIP();
 

-if (connect(sock, reinterpret_cast<struct sockaddr *>(&addr), sizeof(addr)))
+if (connect(sock, reinterpret_cast<struct sockaddr *>(&addr), sizeof(addr)) != 0)

     {
     errorStr = "Cannot connect.";
     {
     errorStr = "Cannot connect.";

+    logger("Cannot connect the socket: %s", strerror(errno));

     printfd(__FILE__, "Cannot connect. Message: '%s'\n", strerror(errno));
     return true;
     }
     printfd(__FILE__, "Cannot connect. Message: '%s'\n", strerror(errno));
     return true;
     }


@@ -311,14 +303,39 @@ if (connect(sock, reinterpret_cast<struct sockaddr *>(&addr), sizeof(addr)))
 return false;
 }
 
 return false;
 }
 

+bool SMUX::Reconnect()
+{
+if (needReconnect && difftime(time(nullptr), lastReconnectTry) < reconnectTimeout)
+    return true;
+
+time(&lastReconnectTry);
+SendClosePDU(sock);
+close(sock);
+if (!PrepareNet())
+    if (SendOpenPDU(sock))
+        if (SendRReqPDU(sock))
+            {
+            reconnectTimeout = 1;
+            needReconnect = false;
+            logger("Connected successfully");
+            printfd(__FILE__, "Connected successfully\n");
+            return false;
+            }
+
+if (needReconnect)
+    if (reconnectTimeout < 60)
+        reconnectTimeout *= 2;
+
+needReconnect = true;
+return true;
+}
+

 bool SMUX::DispatchPDUs(const SMUX_PDUs_t * pdus)
 {
 bool SMUX::DispatchPDUs(const SMUX_PDUs_t * pdus)
 {

-SMUXHandlers::iterator it;
-it = smuxHandlers.find(pdus->present);
+auto it = smuxHandlers.find(pdus->present);

 if (it != smuxHandlers.end())
 if (it != smuxHandlers.end())

-    {

     return (this->*(it->second))(pdus);
     return (this->*(it->second))(pdus);

-    }
+#ifdef SMUX_DEBUG

 else
     {
     switch (pdus->present)
 else
     {
     switch (pdus->present)


@@ -337,6 +354,7 @@ else
         }
     asn_fprint(stderr, &asn_DEF_SMUX_PDUs, pdus);
     }
         }
     asn_fprint(stderr, &asn_DEF_SMUX_PDUs, pdus);
     }

+#endif

 return false;
 }
 
 return false;
 }
 


@@ -344,7 +362,7 @@ bool SMUX::UpdateTables()
 {
 Sensors newSensors;
 bool done = true;
 {
 Sensors newSensors;
 bool done = true;

-Tables::iterator it(tables.begin());
+auto it = tables.begin();

 while (it != tables.end())
     {
     try
 while (it != tables.end())
     {
     try


@@ -363,11 +381,11 @@ while (it != tables.end())
     }
 if (!done)
     {
     }
 if (!done)
     {

-    Sensors::iterator it(newSensors.begin());
-    while (it != newSensors.end())
+    auto sit = newSensors.begin();
+    while (sit != newSensors.end())

         {
         {

-        delete it->second;
-        ++it;
+        delete sit->second;
+        ++sit;

         }
     return false;
     }
         }
     return false;
     }


@@ -375,12 +393,11 @@ if (!done)
 it = tables.begin();
 while (it != tables.end())
     {
 it = tables.begin();
 while (it != tables.end())
     {

-    std::pair<Sensors::iterator, Sensors::iterator> res;
-    res = std::equal_range(sensors.begin(),
-                           sensors.end(),
-                           std::pair<OID, Sensor *>(OID(it->first), NULL),
-                           SPrefixLess);
-    Sensors::iterator sit(res.first);
+    auto res = std::equal_range(sensors.begin(),
+                                sensors.end(),
+                                std::pair<OID, Sensor *>(OID(it->first), nullptr),
+                                SPrefixLess);
+    auto sit = res.first;

     while (sit != res.second)
         {
         delete sit->second;
     while (sit != res.second)
         {
         delete sit->second;


@@ -395,37 +412,58 @@ sensors.insert(newSensors.begin(), newSensors.end());
 return true;
 }
 
 return true;
 }
 

+void SMUX::SetNotifier(UserPtr userPtr)
+{
+notifiers.emplace_back(*this, userPtr);
+userPtr->GetProperties().tariffName.AddAfterNotifier(&notifiers.back());
+}
+
+void SMUX::UnsetNotifier(UserPtr userPtr)
+{
+auto it = notifiers.begin();
+while (it != notifiers.end())
+    {
+    if (it->GetUserPtr() == userPtr)
+        {
+        userPtr->GetProperties().tariffName.DelAfterNotifier(&(*it));
+        notifiers.erase(it);
+        break;
+        }
+    ++it;
+    }
+}
+

 void SMUX::SetNotifiers()
 {
 void SMUX::SetNotifiers()
 {

-USER_PTR u;

 int h = users->OpenSearch();
 assert(h && "USERS::OpenSearch is always correct");
 
 int h = users->OpenSearch();
 assert(h && "USERS::OpenSearch is always correct");
 

-while (!users->SearchNext(h, &u))
-    {
-    notifiers.push_back(CHG_AFTER_NOTIFIER(*this, u));
-    u->GetProperty().tariffName.AddAfterNotifier(&notifiers.back());
-    }
+UserPtr u;
+while (users->SearchNext(h, &u) == 0)
+    SetNotifier(u);

 
 users->CloseSearch(h);
 
 users->CloseSearch(h);

+
+users->AddNotifierUserAdd(&addUserNotifier);
+users->AddNotifierUserDel(&delUserNotifier);
+
+tariffs->AddNotifierAdd(&addDelTariffNotifier);
+tariffs->AddNotifierDel(&addDelTariffNotifier);

 }
 
 void SMUX::ResetNotifiers()
 {
 }
 
 void SMUX::ResetNotifiers()
 {

-std::list<CHG_AFTER_NOTIFIER>::iterator it = notifiers.begin();
+tariffs->DelNotifierDel(&addDelTariffNotifier);
+tariffs->DelNotifierAdd(&addDelTariffNotifier);
+
+users->DelNotifierUserDel(&delUserNotifier);
+users->DelNotifierUserAdd(&addUserNotifier);
+
+auto it = notifiers.begin();

 while (it != notifiers.end())
     {
 while (it != notifiers.end())
     {

-    it->GetUserPtr()->GetProperty().tariffName.DelAfterNotifier(&(*it));
+    it->GetUserPtr()->GetProperties().tariffName.DelAfterNotifier(&(*it));

     ++it;
     }
     ++it;
     }

-}
-
-void CHG_AFTER_NOTIFIER::Notify(const std::string &, const std::string &)
-{
-smux.UpdateTables();
-}
-
-void ADD_DEL_USER_NOTIFIER::Notify(const USER_PTR &)
-{
-smux.UpdateTables();
+notifiers.clear();

 }
 }