lastScanMessages = 0;
-writeFreeMbTraffCost = settings->GetWriteFreeMbTraffCost();
-
pthread_mutexattr_t attr;
pthread_mutexattr_init(&attr);
pthread_mutexattr_settype(&attr, PTHREAD_MUTEX_RECURSIVE);
lastScanMessages = 0;
-writeFreeMbTraffCost = settings->GetWriteFreeMbTraffCost();
-
property.SetProperties(u.property);
pthread_mutexattr_t attr;
{
STG_LOCKER lock(&mutex, __FILE__, __LINE__);
time_t tt = stgTime - 3600;
-struct tm * t1 = localtime(&tt);
+struct tm t1;
+localtime_r(&tt, &t1);
USER_STAT stat(property.GetStat());
-if (store->SaveMonthStat(stat, t1->tm_mon, t1->tm_year, login))
+if (store->SaveMonthStat(stat, t1.tm_mon, t1.tm_year, login))
{
WriteServLog("Cannot write month stat for user %s.", login.c_str());
WriteServLog("%s", store->GetStrError().c_str());
{
STG_LOCKER lock(&mutex, __FILE__, __LINE__);
-if (stgTime - lastWriteStat > settings->GetStatWritePeriod())
+if (stgTime > static_cast<time_t>(lastWriteStat + settings->GetStatWritePeriod()))
{
printfd(__FILE__, "USER::WriteStat user=%s\n", GetLogin().c_str());
WriteStat();
//Add detailed stat
-if (!writeFreeMbTraffCost && freeMb.ConstData() >= 0)
+if (!settings->GetWriteFreeMbTraffCost() &&
+ freeMb.ConstData() >= 0)
cost = 0;
#ifdef TRAFF_STAT_WITH_PORTS
//Add detailed stat
-if (!writeFreeMbTraffCost && freeMb.ConstData() >= 0)
+if (!settings->GetWriteFreeMbTraffCost() &&
+ freeMb.ConstData() >= 0)
cost = 0;
#ifdef TRAFF_STAT_WITH_PORTS
static int daysInMonth[12] =
{31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31};
-struct tm * tms;
+struct tm tms;
time_t t = stgTime;
-tms = localtime(&t);
+localtime_r(&t, &tms);
-time_t secMonth = daysInMonth[(tms->tm_mon + 11) % 12] * 24 * 3600; // Previous month
+time_t secMonth = daysInMonth[(tms.tm_mon + 11) % 12] * 24 * 3600; // Previous month
-if (tms->tm_year % 4 == 0 && tms->tm_mon == 1)
+if (tms.tm_year % 4 == 0 && tms.tm_mon == 1)
{
// Leap year
secMonth += 24 * 3600;
{
STG_LOCKER lock(&mutex, __FILE__, __LINE__);
-time_t t;
-struct tm * tm;
-t = stgTime;
-tm = localtime(&t);
+time_t t = stgTime;
+struct tm tm;
+localtime_r(&t, &tm);
int daysCurrMon = DaysInCurrentMonth();
-double pt = (tm->tm_mday - 1) / (double)daysCurrMon;
+double pt = (tm.tm_mday - 1) / (double)daysCurrMon;
passiveTime = (time_t)(pt * 24 * 3600 * daysCurrMon);
}
{
STG_LOCKER lock(&mutex, __FILE__, __LINE__);
-if (SendMessage(*msg) == 0)
+if (SendMessage(*msg))
+ {
+ if (store->AddMessage(msg, login))
+ {
+ errorStr = store->GetStrError();
+ WriteServLog("Error adding message: '%s'", errorStr.c_str());
+ printfd(__FILE__, "Error adding message: '%s'\n", errorStr.c_str());
+ return -1;
+ }
+ messages.push_back(*msg);
+ }
+else
{
if (msg->header.repeat > 0)
{
if (store->AddMessage(msg, login))
{
errorStr = store->GetStrError();
- STG_LOGGER & WriteServLog = GetStgLogger();
- WriteServLog("Error adding message %s", errorStr.c_str());
- WriteServLog("%s", store->GetStrError().c_str());
+ WriteServLog("Error adding repeatable message: '%s'", errorStr.c_str());
+ printfd(__FILE__, "Error adding repeatable message: '%s'\n", errorStr.c_str());
return -1;
}
messages.push_back(*msg);
}
}
-else
- {
- if (store->AddMessage(msg, login))
- {
- errorStr = store->GetStrError();
- STG_LOGGER & WriteServLog = GetStgLogger();
- WriteServLog("Error adding message %s", errorStr.c_str());
- WriteServLog("%s", store->GetStrError().c_str());
- return -1;
- }
- messages.push_back(*msg);
- }
return 0;
}
//-----------------------------------------------------------------------------
-int USER::SendMessage(const STG_MSG & msg)
+int USER::SendMessage(STG_MSG & msg) const
{
-STG_LOCKER lock(&mutex, __FILE__, __LINE__);
-
-if (authorizedBy.empty())
- {
- return -1;
- }
-
+// No lock `cause we are already locked from caller
int ret = -1;
-set<const BASE_AUTH*>::iterator it;
-
-it = authorizedBy.begin();
+set<const BASE_AUTH*>::iterator it(authorizedBy.begin());
while (it != authorizedBy.end())
{
- if ((*it)->SendMessage(msg, currIP) == 0)
+ if (!(*it++)->SendMessage(msg, currIP))
ret = 0;
- ++it;
+ }
+if (!ret)
+ {
+#ifndef DEBUG
+ //TODO: gcc v. 4.x generate ICE on x86_64
+ msg.header.lastSendTime = time(NULL);
+#else
+ msg.header.lastSendTime = stgTime;
+#endif
+ msg.header.repeat--;
}
return ret;
}
//-----------------------------------------------------------------------------
-int USER::ScanMessage()
+void USER::ScanMessage()
{
-STG_LOCKER lock(&mutex, __FILE__, __LINE__);
-
-/*vector<STG_MSG_HDR> hdrsList;
-
-if (store->GetMessageHdrs(&hdrsList, login))
- {
- printfd(__FILE__, "Error GetMessageHdrs %s\n", store->GetStrError().c_str());
- return -1;
- }
-
-for (unsigned i = 0; i < hdrsList.size(); i++)
- {
-
- if (hdrsList[i].lastSendTime + hdrsList[i].repeatPeriod * 60 < (unsigned)stgTime)
- {
- STG_MSG msg;
- if (store->GetMessage(hdrsList[i].id, &msg, login) == 0)
- {
- if (SendMessage(msg) == 0)
- {
- msg.header.repeat--;
- if (msg.header.repeat < 0)
- {
- printfd(__FILE__, "DelMessage\n");
- store->DelMessage(hdrsList[i].id, login);
- }
- else
- {
- #ifndef DEBUG
- //TODO: gcc v. 4.x generate ICE on x86_64
- msg.header.lastSendTime = time(NULL);
- #else
- msg.header.lastSendTime = stgTime;
- #endif
- if (store->EditMessage(msg, login))
- {
- printfd(__FILE__, "EditMessage Error %s\n", store->GetStrError().c_str());
- }
- }
- }
- }
- else
- {
- WriteServLog("Cannot get message for user %s.", login.c_str());
- WriteServLog("%s", store->GetStrError().c_str());
- }
- }
- }*/
+// No lock `cause we are already locked from caller
+// We need not check for the authorizedBy `cause it has already checked by caller
std::list<STG_MSG>::iterator it(messages.begin());
while (it != messages.end())
{
- if (SendMessage(*it))
- {
- break;
- }
- it->header.repeat--;
- if (it->header.repeat < 0)
+ if (settings->GetMessageTimeout() > 0 &&
+ difftime(stgTime, it->header.creationTime) > settings->GetMessageTimeout())
{
- printfd(__FILE__, "DelMessage\n");
- store->DelMessage(it->id, login);
+ // Timeout exceeded
+ if (store->DelMessage(it->header.id, login))
+ {
+ WriteServLog("Error deleting message: '%s'", store->GetStrError().c_str());
+ printfd(__FILE__, "Error deleting message: '%s'\n", store->GetStrError().c_str());
+ }
messages.erase(it++);
+ continue;
}
- else
+ if (it->GetNextSendTime() <= stgTime)
{
- #ifndef DEBUG
- //TODO: gcc v. 4.x generate ICE on x86_64
- it->header.lastSendTime = time(NULL);
- #else
- it->header.lastSendTime = stgTime;
- #endif
- if (store->EditMessage(*it, login))
+ if (SendMessage(*it))
+ {
+ // We need to check all messages in queue for timeout
+ ++it;
+ continue;
+ }
+ if (it->header.repeat < 0)
{
- printfd(__FILE__, "EditMessage Error %s\n", store->GetStrError().c_str());
+ if (store->DelMessage(it->header.id, login))
+ {
+ WriteServLog("Error deleting message: '%s'", store->GetStrError().c_str());
+ printfd(__FILE__, "Error deleting message: '%s'\n", store->GetStrError().c_str());
+ }
+ messages.erase(it++);
+ }
+ else
+ {
+ if (store->EditMessage(*it, login))
+ {
+ WriteServLog("Error modifying message: '%s'", store->GetStrError().c_str());
+ printfd(__FILE__, "Error modifying message: '%s'\n", store->GetStrError().c_str());
+ }
+ ++it;
}
- ++it;
}
}
-
-return 0;
}
//-----------------------------------------------------------------------------
//-----------------------------------------------------------------------------
git.stg.codes / stg.git / blobdiff