From bb0603410f7b548d52f2556cc8be734913088443 Mon Sep 17 00:00:00 2001 From: Maxim Mamontov Date: Wed, 14 Sep 2011 17:36:19 +0300 Subject: [PATCH 1/1] Initialize class members for SMUX_SETTINGS in constructor Hide copy constructor and assignement operator for SMUX --- .../stargazer/plugins/other/smux/smux.cpp | 11 +++++-- projects/stargazer/plugins/other/smux/smux.h | 30 +++++++++++-------- 2 files changed, 27 insertions(+), 14 deletions(-) diff --git a/projects/stargazer/plugins/other/smux/smux.cpp b/projects/stargazer/plugins/other/smux/smux.cpp index fdcaaf02..61ed8026 100644 --- a/projects/stargazer/plugins/other/smux/smux.cpp +++ b/projects/stargazer/plugins/other/smux/smux.cpp @@ -34,8 +34,10 @@ return a.first.PrefixLess(b.first); } SMUX_SETTINGS::SMUX_SETTINGS() - : ip(0), - port(0) + : errorStr(), + ip(0), + port(0), + password() {} int SMUX_SETTINGS::ParseSettings(const MODULE_SETTINGS & s) @@ -94,6 +96,11 @@ SMUX::SMUX() services(NULL), corporations(NULL), traffcounter(NULL), + errorStr(), + smuxSettings(), + settings(), + thread(), + mutex(), running(false), stopped(true), sock(-1), diff --git a/projects/stargazer/plugins/other/smux/smux.h b/projects/stargazer/plugins/other/smux/smux.h index e16ae5f2..7337deaf 100644 --- a/projects/stargazer/plugins/other/smux/smux.h +++ b/projects/stargazer/plugins/other/smux/smux.h @@ -14,6 +14,7 @@ #include "stg/plugin.h" #include "stg/module_settings.h" #include "stg/notifer.h" +#include "stg/noncopyable.h" #include "sensors.h" #include "tables.h" @@ -56,38 +57,40 @@ private: //----------------------------------------------------------------------------- class CHG_AFTER_NOTIFIER : public PROPERTY_NOTIFIER_BASE { public: - CHG_AFTER_NOTIFIER(SMUX & s, const USER_PTR & u) : smux(s), userPtr(u) {} - void Notify(const std::string &, const std::string &); + CHG_AFTER_NOTIFIER(SMUX & s, const USER_PTR & u) : smux(s), userPtr(u) {} + CHG_AFTER_NOTIFIER(const CHG_AFTER_NOTIFIER & rvalue) : smux(rvalue.smux), userPtr(rvalue.userPtr) {} + void Notify(const std::string &, const std::string &); - USER_PTR GetUserPtr() { return userPtr; } + USER_PTR GetUserPtr() { return userPtr; } private: + CHG_AFTER_NOTIFIER & operator=(const CHG_AFTER_NOTIFIER & rvalue); SMUX & smux; USER_PTR userPtr; }; //----------------------------------------------------------------------------- -class ADD_DEL_TARIFF_NOTIFIER : public NOTIFIER_BASE { +class ADD_DEL_TARIFF_NOTIFIER : public NOTIFIER_BASE, private NONCOPYABLE { public: - ADD_DEL_TARIFF_NOTIFIER(SMUX & s) : smux(s) {} - void Notify(const TARIFF_DATA &); + ADD_DEL_TARIFF_NOTIFIER(SMUX & s) : smux(s) {} + void Notify(const TARIFF_DATA &); private: SMUX & smux; }; //----------------------------------------------------------------------------- -class ADD_USER_NOTIFIER : public NOTIFIER_BASE { +class ADD_USER_NOTIFIER : public NOTIFIER_BASE, private NONCOPYABLE { public: - ADD_USER_NOTIFIER(SMUX & s) : smux(s) {} - void Notify(const USER_PTR &); + ADD_USER_NOTIFIER(SMUX & s) : smux(s) {} + void Notify(const USER_PTR &); private: SMUX & smux; }; //----------------------------------------------------------------------------- -class DEL_USER_NOTIFIER : public NOTIFIER_BASE { +class DEL_USER_NOTIFIER : public NOTIFIER_BASE, private NONCOPYABLE { public: - DEL_USER_NOTIFIER(SMUX & s) : smux(s) {} - void Notify(const USER_PTR &); + DEL_USER_NOTIFIER(SMUX & s) : smux(s) {} + void Notify(const USER_PTR &); private: SMUX & smux; @@ -123,6 +126,9 @@ public: void UnsetNotifier(USER_PTR userPtr); private: + SMUX(const SMUX & rvalue); + SMUX & operator=(const SMUX & rvalue); + static void * Runner(void * d); void Run(); bool PrepareNet(); -- 2.44.2