From: Elena Mamontova <helenh463@gmail.com>
Date: Mon, 12 Dec 2016 13:18:05 +0000 (+0200)
Subject: Ticket 37. In the TariffChangeIsAllowed() function return "" added and
X-Git-Tag: 2.409~40
X-Git-Url: https://git.stg.codes/stg.git/commitdiff_plain/04af0b0b4df91a7a1f579edf17f49a81d10db592?ds=sidebyside

Ticket 37. In the TariffChangeIsAllowed() function return "" added and
unnecessary brackets removed in the if (currentTime > timeout && timeout != 0).
---

diff --git a/projects/stargazer/tariff_impl.cpp b/projects/stargazer/tariff_impl.cpp
index 2daaeeb3..7dbae0da 100644
--- a/projects/stargazer/tariff_impl.cpp
+++ b/projects/stargazer/tariff_impl.cpp
@@ -148,7 +148,7 @@ else
 std::string TARIFF_IMPL::TariffChangeIsAllowed(const TARIFF & to, time_t currentTime) const
 {
 time_t timeout = GetChangePolicyTimeout();
-if ((currentTime > timeout) && (timeout != 0))
+if (currentTime > timeout && timeout != 0)
     return "";
 switch (GetChangePolicy())
     {
@@ -167,5 +167,6 @@ switch (GetChangePolicy())
     case TARIFF::DENY:
         return "Current tariff '" + GetName() + "', new tariff '" + to.GetName() + "'. The policy is '" + TARIFF::ChangePolicyToString(GetChangePolicy()) + "'.";
     }
+return "";
 }
 //-----------------------------------------------------------------------------