В консольном авторизаторе в классе отвечающем за WEB-интерфейс проведен

рефакторинг кода, добавлена инициализация некоторых членов, уменьшена
область видимости переменных

diff --git a/projects/sgauth/web.cpp b/projects/sgauth/web.cpp
index caec33a00391cf0ff2b5e61810d36982391a3f17..ffab862b76882df51600c8b7ef158b594ed3705a 100644 (file)
--- a/projects/sgauth/web.cpp
+++ b/projects/sgauth/web.cpp
@@ -56,8 +56,7 @@ WEB::WEB()
       listenSocket(0),
       outerSocket(0),
       refreshPeriod(0),
       listenSocket(0),
       outerSocket(0),
       refreshPeriod(0),

-      listenWebAddr(0),
-      outerAddrLen(0)
+      listenWebAddr(0)

 {
 #ifdef WIN32
 res = WSAStartup(MAKEWORD(2,0), &wsaData);
 {
 #ifdef WIN32
 res = WSAStartup(MAKEWORD(2,0), &wsaData);


@@ -89,6 +88,8 @@ pthread_create(&thread, NULL, RunWeb, NULL);
 void WEB::PrepareNet()
 {
 listenSocket = socket(PF_INET, SOCK_STREAM, 0);
 void WEB::PrepareNet()
 {
 listenSocket = socket(PF_INET, SOCK_STREAM, 0);

+
+struct sockaddr_in listenAddr;

 listenAddr.sin_family = AF_INET;
 listenAddr.sin_port = htons(LISTEN_PORT);
 listenAddr.sin_addr.s_addr = listenWebAddr;
 listenAddr.sin_family = AF_INET;
 listenAddr.sin_port = htons(LISTEN_PORT);
 listenAddr.sin_addr.s_addr = listenWebAddr;


@@ -120,8 +121,6 @@ if (res == -1)
     printf("Listen failed.\n");
     exit(0);
     }
     printf("Listen failed.\n");
     exit(0);
     }

-
-outerAddrLen = sizeof(outerAddr);

 }
 //---------------------------------------------------------------------------
 void WEB::SetRefreshPagePeriod(int p)
 }
 //---------------------------------------------------------------------------
 void WEB::SetRefreshPagePeriod(int p)


@@ -142,6 +141,14 @@ PrepareNet();
 char recvBuffer[4096];
 while (1)
     {
 char recvBuffer[4096];
 while (1)
     {

+    struct sockaddr_in outerAddr;
+
+    #ifndef WIN32
+    socklen_t outerAddrLen = sizeof(outerAddr);
+    #else
+    int outerAddrLen = sizeof(outerAddr);
+    #endif
+

     outerSocket = accept(listenSocket, (struct sockaddr*)&outerAddr, &outerAddrLen);
     if (outerSocket == -1)
         {
     outerSocket = accept(listenSocket, (struct sockaddr*)&outerAddr, &outerAddrLen);
     if (outerSocket == -1)
         {

diff --git a/projects/sgauth/web.h b/projects/sgauth/web.h
index b734f16be9ca9f2ad4cd7e0acd680aef61a98c70..be9e158dcfe1da5a6f2aa143966b856aaebb6bd5 100644 (file)
--- a/projects/sgauth/web.h
+++ b/projects/sgauth/web.h
@@ -65,8 +65,10 @@ public:
     void UpdateStat(const LOADSTAT & ls);
     void Start();
 private:
     void UpdateStat(const LOADSTAT & ls);
     void Start();
 private:

-

     void PrepareNet();
     void PrepareNet();

+    int SendReply();
+    int SendCSS();
+    int Redirect(const char * url);

 
     #ifdef WIN32
     WSADATA wsaData;
 
     #ifdef WIN32
     WSADATA wsaData;


@@ -74,28 +76,15 @@ private:
     pthread_t thread;
     #endif
 
     pthread_t thread;
     #endif
 

-    int         SendReply();
-    int         SendCSS();
-    int         Redirect(const char * url);
-
-    string      dirName[DIR_NUM];
-    int         res;
-    int         listenSocket;
-    int         outerSocket;
-    struct sockaddr_in listenAddr;
-    struct sockaddr_in outerAddr;
-    int         refreshPeriod;
+    string dirName[DIR_NUM];
+    int res;
+    int listenSocket;
+    int outerSocket;
+    int refreshPeriod;

 
 

-    uint32_t    listenWebAddr;
-    LOADSTAT    ls;
+    uint32_t listenWebAddr;
+    LOADSTAT ls;

 
     list<STG_MESSAGE> messages;
 
     list<STG_MESSAGE> messages;

-
-    #ifndef WIN32
-    socklen_t   outerAddrLen;
-    #else
-    int         outerAddrLen;
-    #endif

 };
 //-----------------------------------------------------------------------------
 };
 //-----------------------------------------------------------------------------

-