Hide or add proper copy ctor and assignement operator, initialize

members via initialization lists in radius code

diff --git a/projects/stargazer/plugins/other/radius/radius.cpp b/projects/stargazer/plugins/other/radius/radius.cpp
index efa995704ad0baad95a33c7f2523767730d9dc50..62c9305ca84ca5c9ac52099e9ab42a5b1ea3fd9d 100644 (file)
--- a/projects/stargazer/plugins/other/radius/radius.cpp
+++ b/projects/stargazer/plugins/other/radius/radius.cpp
@@ -121,36 +121,26 @@ return 0;
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 RADIUS::RADIUS()
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 RADIUS::RADIUS()

-    : nonstop(false),
+    : ctx(),
+      errorStr(),
+      radSettings(),
+      settings(),
+      authServices(),
+      acctServices(),
+      sessions(),
+      nonstop(false),

       isRunning(false),
       users(NULL),
       stgSettings(NULL),
       store(NULL),
       isRunning(false),
       users(NULL),
       stgSettings(NULL),
       store(NULL),

-      sock(-1)
+      thread(),
+      mutex(),
+      sock(-1),
+      packet()

 {
 InitEncrypt(&ctx, "");
 }
 //-----------------------------------------------------------------------------
 {
 InitEncrypt(&ctx, "");
 }
 //-----------------------------------------------------------------------------

-void RADIUS::SetUsers(USERS * u)
-{
-users = u;
-}
-//-----------------------------------------------------------------------------
-void RADIUS::SetStgSettings(const SETTINGS * s)
-{
-stgSettings = s;
-}
-//-----------------------------------------------------------------------------
-void RADIUS::SetSettings(const MODULE_SETTINGS & s)
-{
-settings = s;
-}
-//-----------------------------------------------------------------------------
-void RADIUS::SetStore(STORE * s)
-{
-store = s;
-}
-//-----------------------------------------------------------------------------

 int RADIUS::ParseSettings()
 {
 int ret = radSettings.ParseSettings(settings);
 int RADIUS::ParseSettings()
 {
 int ret = radSettings.ParseSettings(settings);


@@ -159,27 +149,6 @@ if (ret)
 return ret;
 }
 //-----------------------------------------------------------------------------
 return ret;
 }
 //-----------------------------------------------------------------------------

-bool RADIUS::IsRunning()
-{
-return isRunning;
-}
-//-----------------------------------------------------------------------------
-const std::string RADIUS::GetVersion() const
-{
-return "RADIUS data access plugin v 0.6";
-}
-//-----------------------------------------------------------------------------
-uint16_t RADIUS::GetStartPosition() const
-{
-// Start before any authorizers!!!
-return 20;
-}
-//-----------------------------------------------------------------------------
-uint16_t RADIUS::GetStopPosition() const
-{
-return 20;
-}
-//-----------------------------------------------------------------------------

 int RADIUS::PrepareNet()
 {
 sock = socket(AF_INET, SOCK_DGRAM, 0);
 int RADIUS::PrepareNet()
 {
 sock = socket(AF_INET, SOCK_DGRAM, 0);

diff --git a/projects/stargazer/plugins/other/radius/radius.h b/projects/stargazer/plugins/other/radius/radius.h
index 434849076bd3c099f8c0cc8f3c6a55fe10777b61..731753a01596a9b0582e905ab1f7196d4757176f 100644 (file)
--- a/projects/stargazer/plugins/other/radius/radius.h
+++ b/projects/stargazer/plugins/other/radius/radius.h
@@ -56,7 +56,10 @@ class RADIUS;
 //-----------------------------------------------------------------------------
 class RAD_SETTINGS {
 public:
 //-----------------------------------------------------------------------------
 class RAD_SETTINGS {
 public:

-    RAD_SETTINGS() : port(0) {}
+    RAD_SETTINGS()
+        : port(0), errorStr(), password(),
+          authServices(), acctServices()
+    {}

     virtual ~RAD_SETTINGS() {}
     const string & GetStrError() const { return errorStr; }
     int ParseSettings(const MODULE_SETTINGS & s);
     virtual ~RAD_SETTINGS() {}
     const string & GetStrError() const { return errorStr; }
     int ParseSettings(const MODULE_SETTINGS & s);


@@ -76,6 +79,7 @@ private:
 };
 //-----------------------------------------------------------------------------
 struct RAD_SESSION {
 };
 //-----------------------------------------------------------------------------
 struct RAD_SESSION {

+    RAD_SESSION() : userName(), serviceType() {}

     std::string userName;
     std::string serviceType;
 };
     std::string userName;
     std::string serviceType;
 };


@@ -83,27 +87,30 @@ struct RAD_SESSION {
 class RADIUS :public AUTH {
 public:
                         RADIUS();
 class RADIUS :public AUTH {
 public:
                         RADIUS();

-    virtual             ~RADIUS() {};
+    virtual             ~RADIUS() {}

 
 

-    void                SetUsers(USERS * u);
-    void                SetStore(STORE * );
-    void                SetStgSettings(const SETTINGS * s);
-    void                SetSettings(const MODULE_SETTINGS & s);
+    void                SetUsers(USERS * u) { users = u; }
+    void                SetStore(STORE * s) { store = s; }
+    void                SetStgSettings(const SETTINGS *) {}
+    void                SetSettings(const MODULE_SETTINGS & s) { settings = s; }

     int                 ParseSettings();
 
     int                 Start();
     int                 Stop();
     int                 Reload() { return 0; }
     int                 ParseSettings();
 
     int                 Start();
     int                 Stop();
     int                 Reload() { return 0; }

-    bool                IsRunning();
+    bool                IsRunning() { return isRunning; }

 
     const std::string & GetStrError() const { return errorStr; }
 
     const std::string & GetStrError() const { return errorStr; }

-    const std::string   GetVersion() const;
-    uint16_t            GetStartPosition() const;
-    uint16_t            GetStopPosition() const;
+    const std::string   GetVersion() const { return "RADIUS data access plugin v 0.6"; }
+    uint16_t            GetStartPosition() const { return 20; }
+    uint16_t            GetStopPosition() const { return 20; }

 
     int SendMessage(const STG_MSG &, uint32_t) const { return 0; }
 
 private:
 
     int SendMessage(const STG_MSG &, uint32_t) const { return 0; }
 
 private:

+    RADIUS(const RADIUS & rvalue);
+    RADIUS & operator=(const RADIUS & rvalue);
+

     static void *       Run(void *);
     int                 PrepareNet();
     int                 FinalizeNet();
     static void *       Run(void *);
     int                 PrepareNet();
     int                 FinalizeNet();