X-Git-Url: https://git.stg.codes/stg.git/blobdiff_plain/e19060886ea59cbcb0c97e1712a954f729ef47b3..0d3126b51031578f051af3f38ed73b8e4e6a18bf:/projects/stargazer/plugins/other/smux/sensors.h

diff --git a/projects/stargazer/plugins/other/smux/sensors.h b/projects/stargazer/plugins/other/smux/sensors.h
index 7c11751e..35de996c 100644
--- a/projects/stargazer/plugins/other/smux/sensors.h
+++ b/projects/stargazer/plugins/other/smux/sensors.h
@@ -18,6 +18,7 @@
 
 class Sensor {
     public:
+        virtual ~Sensor() {}
         virtual bool GetValue(ObjectSyntax_t * objectSyntax) const = 0;
 #ifdef DEBUG
         virtual std::string ToString() const = 0;
@@ -28,7 +29,7 @@ typedef std::map<OID, Sensor *> Sensors;
 
 class TotalUsersSensor : public Sensor {
     public:
-        TotalUsersSensor(const USERS & u) : users(u) {}
+        explicit TotalUsersSensor(const USERS & u) : users(u) {}
         virtual ~TotalUsersSensor() {}
 
         bool GetValue(ObjectSyntax_t * objectSyntax) const
@@ -48,7 +49,7 @@ class TotalUsersSensor : public Sensor {
 
 class UsersSensor : public Sensor {
     public:
-        UsersSensor(USERS & u) : users(u) {}
+        explicit UsersSensor(USERS & u) : users(u) {}
         virtual ~UsersSensor() {}
 
         bool GetValue(ObjectSyntax_t * objectSyntax) const;
@@ -64,7 +65,7 @@ class UsersSensor : public Sensor {
 
 class ConnectedUsersSensor : public UsersSensor {
     public:
-        ConnectedUsersSensor(USERS & u) : UsersSensor(u) {}
+        explicit ConnectedUsersSensor(USERS & u) : UsersSensor(u) {}
         virtual ~ConnectedUsersSensor() {}
 
     private:
@@ -74,7 +75,7 @@ class ConnectedUsersSensor : public UsersSensor {
 
 class AuthorizedUsersSensor : public UsersSensor {
     public:
-        AuthorizedUsersSensor(USERS & u) : UsersSensor(u) {}
+        explicit AuthorizedUsersSensor(USERS & u) : UsersSensor(u) {}
         virtual ~AuthorizedUsersSensor() {}
 
     private:
@@ -84,7 +85,7 @@ class AuthorizedUsersSensor : public UsersSensor {
 
 class AlwaysOnlineUsersSensor : public UsersSensor {
     public:
-        AlwaysOnlineUsersSensor(USERS & u) : UsersSensor(u) {}
+        explicit AlwaysOnlineUsersSensor(USERS & u) : UsersSensor(u) {}
         virtual ~AlwaysOnlineUsersSensor() {}
 
     private:
@@ -94,7 +95,7 @@ class AlwaysOnlineUsersSensor : public UsersSensor {
 
 class NoCashUsersSensor : public UsersSensor {
     public:
-        NoCashUsersSensor(USERS & u) : UsersSensor(u) {}
+        explicit NoCashUsersSensor(USERS & u) : UsersSensor(u) {}
         virtual ~NoCashUsersSensor() {}
 
     private:
@@ -104,7 +105,7 @@ class NoCashUsersSensor : public UsersSensor {
 
 class DisabledDetailStatsUsersSensor : public UsersSensor {
     public:
-        DisabledDetailStatsUsersSensor(USERS & u) : UsersSensor(u) {}
+        explicit DisabledDetailStatsUsersSensor(USERS & u) : UsersSensor(u) {}
         virtual ~DisabledDetailStatsUsersSensor() {}
 
     private:
@@ -114,7 +115,7 @@ class DisabledDetailStatsUsersSensor : public UsersSensor {
 
 class DisabledUsersSensor : public UsersSensor {
     public:
-        DisabledUsersSensor(USERS & u) : UsersSensor(u) {}
+        explicit DisabledUsersSensor(USERS & u) : UsersSensor(u) {}
         virtual ~DisabledUsersSensor() {}
 
     private:
@@ -124,7 +125,7 @@ class DisabledUsersSensor : public UsersSensor {
 
 class PassiveUsersSensor : public UsersSensor {
     public:
-        PassiveUsersSensor(USERS & u) : UsersSensor(u) {}
+        explicit PassiveUsersSensor(USERS & u) : UsersSensor(u) {}
         virtual ~PassiveUsersSensor() {}
 
     private:
@@ -134,7 +135,7 @@ class PassiveUsersSensor : public UsersSensor {
 
 class CreditUsersSensor : public UsersSensor {
     public:
-        CreditUsersSensor(USERS & u) : UsersSensor(u) {}
+        explicit CreditUsersSensor(USERS & u) : UsersSensor(u) {}
         virtual ~CreditUsersSensor() {}
 
     private:
@@ -144,7 +145,7 @@ class CreditUsersSensor : public UsersSensor {
 
 class FreeMbUsersSensor : public UsersSensor {
     public:
-        FreeMbUsersSensor(USERS & u) : UsersSensor(u) {}
+        explicit FreeMbUsersSensor(USERS & u) : UsersSensor(u) {}
         virtual ~FreeMbUsersSensor() {}
 
     private:
@@ -154,17 +155,26 @@ class FreeMbUsersSensor : public UsersSensor {
 
 class TariffChangeUsersSensor : public UsersSensor {
     public:
-        TariffChangeUsersSensor(USERS & u) : UsersSensor(u) {}
+        explicit TariffChangeUsersSensor(USERS & u) : UsersSensor(u) {}
         virtual ~TariffChangeUsersSensor() {}
 
     private:
         bool UserPredicate(USER_PTR userPtr) const
-        { return userPtr->GetProperty().nextTariff.ConstData().empty(); }
+        { return !userPtr->GetProperty().nextTariff.ConstData().empty(); }
+};
+
+class ActiveUsersSensor : public UsersSensor {
+    public:
+        explicit ActiveUsersSensor(USERS & u) : UsersSensor(u) {}
+        virtual ~ActiveUsersSensor() {}
+
+    private:
+        bool UserPredicate(USER_PTR userPtr) const;
 };
 
 class TotalTariffsSensor : public Sensor {
     public:
-        TotalTariffsSensor(const TARIFFS & t) : tariffs(t) {}
+        explicit TotalTariffsSensor(const TARIFFS & t) : tariffs(t) {}
         virtual ~TotalTariffsSensor() {}
 
         bool GetValue(ObjectSyntax_t * objectSyntax) const
@@ -184,7 +194,7 @@ class TotalTariffsSensor : public Sensor {
 
 class TotalAdminsSensor : public Sensor {
     public:
-        TotalAdminsSensor(const ADMINS & a) : admins(a) {}
+        explicit TotalAdminsSensor(const ADMINS & a) : admins(a) {}
         virtual ~TotalAdminsSensor() {}
 
         bool GetValue(ObjectSyntax_t * objectSyntax) const
@@ -204,7 +214,7 @@ class TotalAdminsSensor : public Sensor {
 
 class TotalServicesSensor : public Sensor {
     public:
-        TotalServicesSensor(const SERVICES & s) : services(s) {}
+        explicit TotalServicesSensor(const SERVICES & s) : services(s) {}
         virtual ~TotalServicesSensor() {}
 
         bool GetValue(ObjectSyntax_t * objectSyntax) const
@@ -224,7 +234,7 @@ class TotalServicesSensor : public Sensor {
 
 class TotalCorporationsSensor : public Sensor {
     public:
-        TotalCorporationsSensor(const CORPORATIONS & c) : corporations(c) {}
+        explicit TotalCorporationsSensor(const CORPORATIONS & c) : corporations(c) {}
         virtual ~TotalCorporationsSensor() {}
 
         bool GetValue(ObjectSyntax_t * objectSyntax) const
@@ -244,7 +254,7 @@ class TotalCorporationsSensor : public Sensor {
 
 class TotalRulesSensor : public Sensor {
     public:
-        TotalRulesSensor(const TRAFFCOUNTER & t) : traffcounter(t) {}
+        explicit TotalRulesSensor(const TRAFFCOUNTER & t) : traffcounter(t) {}
         virtual ~TotalRulesSensor() {}
 
         bool GetValue(ObjectSyntax_t * objectSyntax) const
@@ -265,7 +275,7 @@ class TotalRulesSensor : public Sensor {
 template <typename T>
 class ConstSensor : public Sensor {
     public:
-        ConstSensor(const T & v) : value(v) {}
+        explicit ConstSensor(const T & v) : value(v) {}
         virtual ~ConstSensor() {}
 
         bool GetValue(ObjectSyntax * objectSyntax) const
@@ -280,11 +290,13 @@ class ConstSensor : public Sensor {
         T value;
 };
 
+#ifdef DEBUG
 template <>
 inline
 std::string ConstSensor<std::string>::ToString() const
 {
 return value;
 }
+#endif
 
 #endif