Fix resource leak in file_store

[stg.git] / stglibs / conffiles.lib / conffiles.cpp

diff --git a/stglibs/conffiles.lib/conffiles.cpp b/stglibs/conffiles.lib/conffiles.cpp
index 9c8c46e8809719bab9b012f25505dfd52fb6935a..ea51939aeea458ff19ebe83b5ef2aaabb518e3ca 100644 (file)
--- a/stglibs/conffiles.lib/conffiles.cpp
+++ b/stglibs/conffiles.lib/conffiles.cpp
@@ -28,14 +28,20 @@
  */
 
 //---------------------------------------------------------------------------
  */
 
 //---------------------------------------------------------------------------

-#include <cerrno>
+
+// getpid
+#include <sys/types.h>
+#include <unistd.h>
+
+#include <cerrno> // E*

 #include <cstring>
 #include <cstdlib>
 #include <cstring>
 #include <cstdlib>

+#include <cstdio>

 
 #include <fstream>
 
 #include "conffiles.h"
 
 #include <fstream>
 
 #include "conffiles.h"

-#include "common.h"
+#include "stg/common.h"

 
 using namespace std;
 
 
 using namespace std;
 


@@ -45,32 +51,24 @@ bool StringCaseCmp(const string & str1, const string & str2)
 return (strcasecmp(str1.c_str(), str2.c_str()) < 0);
 }
 //---------------------------------------------------------------------------
 return (strcasecmp(str1.c_str(), str2.c_str()) < 0);
 }
 //---------------------------------------------------------------------------

-CONFIGFILE::CONFIGFILE(const string & fn)
+CONFIGFILE::CONFIGFILE(const string & fn, bool nook)

     : param_val(StringCaseCmp),
       fileName(fn),
     : param_val(StringCaseCmp),
       fileName(fn),

-      error(0)
+      error(0),
+      changed(false)

 {
 ifstream f(fileName.c_str());
 {
 ifstream f(fileName.c_str());

-//FILE * f = fopen(fileName.c_str(), "rt");

 
 if (!f)
     {
 
 if (!f)
     {

-    error = -1;
+    if (!nook)
+        error = -1;

     return;
     }
 
 string line;
 while (getline(f, line))
     {
     return;
     }
 
 string line;
 while (getline(f, line))
     {

-    /*unsigned char c = fgetc(f);
-    while (!feof(f))
-        {
-        if (c == '\n')
-            break;
-        line.push_back(c);
-        c = fgetc(f);
-        }*/
-

     size_t pos = line.find('#');
     if (pos != string::npos)
         line.resize(pos);
     size_t pos = line.find('#');
     if (pos != string::npos)
         line.resize(pos);


@@ -78,20 +76,6 @@ while (getline(f, line))
     if (line.find_first_not_of(" \t\r") == string::npos)
         continue;
 
     if (line.find_first_not_of(" \t\r") == string::npos)
         continue;
 

-    /*bool emptyLine = true;
-    for (unsigned int i = 0; i < line.size(); i++)
-        {
-        if (line[i] != ' ' && line[i] != '\t' && line[i] != '\n' && line[i] != '\r')
-            {
-            emptyLine = false;
-            break;
-            }
-        }
-    if (emptyLine)
-        {
-        continue;
-        }*/
-

     pos = line.find_first_of('=');
     if (pos == string::npos)
         {
     pos = line.find_first_of('=');
     if (pos == string::npos)
         {


@@ -107,6 +91,7 @@ while (getline(f, line))
 //---------------------------------------------------------------------------
 CONFIGFILE::~CONFIGFILE()
 {
 //---------------------------------------------------------------------------
 CONFIGFILE::~CONFIGFILE()
 {

+Flush();

 }
 //---------------------------------------------------------------------------
 const string & CONFIGFILE::GetFileName() const
 }
 //---------------------------------------------------------------------------
 const string & CONFIGFILE::GetFileName() const


@@ -114,33 +99,12 @@ const string & CONFIGFILE::GetFileName() const
 return fileName;
 }
 //---------------------------------------------------------------------------
 return fileName;
 }
 //---------------------------------------------------------------------------

-int CONFIGFILE::Error()
+int CONFIGFILE::Error() const

 {
 int e = error;
 error = 0;
 return e;
 }
 {
 int e = error;
 error = 0;
 return e;
 }

-//---------------------------------------------------------------------------
-int CONFIGFILE::Flush()
-{
-ofstream f(fileName.c_str());
-if (!f.is_open())
-    {
-    error = EIO;
-    return EIO;
-    }
-
-map<string, string>::const_iterator it = param_val.begin();
-while (it != param_val.end())
-    {
-    f << it->first << "=" << it->second << endl;
-    it++;
-    }
-
-f.close();
-
-return 0;
-}

 /*//---------------------------------------------------------------------------
 int CONFIGFILE::ReadString(const string & param, char * str, int * maxLen, const char * defaultVal) const
 {
 /*//---------------------------------------------------------------------------
 int CONFIGFILE::ReadString(const string & param, char * str, int * maxLen, const char * defaultVal) const
 {


@@ -175,18 +139,11 @@ if (it != param_val.end())
 *val = defaultVal;
 return -1;
 }
 *val = defaultVal;
 return -1;
 }

-/*//---------------------------------------------------------------------------
-int CONFIGFILE::WriteString(const string & param, const char * val)
-{
-WriteString(param, string(val));
-return 0;
-}*/

 //---------------------------------------------------------------------------
 //---------------------------------------------------------------------------

-int CONFIGFILE::WriteString(const string & param, const string &val)
+void CONFIGFILE::WriteString(const string & param, const string &val)

 {
 param_val[param] = val;
 {
 param_val[param] = val;

-Flush();
-return 0;
+changed = true;

 }
 //---------------------------------------------------------------------------
 int CONFIGFILE::ReadTime(const string & param, time_t * val, time_t defaultVal) const
 }
 //---------------------------------------------------------------------------
 int CONFIGFILE::ReadTime(const string & param, time_t * val, time_t defaultVal) const


@@ -385,14 +342,12 @@ if (it != param_val.end())
 return -1;
 }
 //---------------------------------------------------------------------------
 return -1;
 }
 //---------------------------------------------------------------------------

-int CONFIGFILE::WriteInt(const string & param, int64_t val)
+void CONFIGFILE::WriteInt(const string & param, int64_t val)

 {
 string s;
 {
 string s;

-//sprintf(s, "%lld", val);

 x2str(val, s);
 param_val[param] = s;
 x2str(val, s);
 param_val[param] = s;

-Flush();
-return 0;
+changed = true;

 }
 //---------------------------------------------------------------------------
 int CONFIGFILE::ReadDouble(const string & param, double * val, double defaultVal) const
 }
 //---------------------------------------------------------------------------
 int CONFIGFILE::ReadDouble(const string & param, double * val, double defaultVal) const


@@ -417,12 +372,50 @@ if (it != param_val.end())
 return -1;
 }
 //---------------------------------------------------------------------------
 return -1;
 }
 //---------------------------------------------------------------------------

-int CONFIGFILE::WriteDouble(const string & param, double val)
+void CONFIGFILE::WriteDouble(const string & param, double val)

 {
 char s[30];
 {
 char s[30];

-sprintf(s, "%f", val);
+snprintf(s, 30, "%f", val);

 param_val[param] = s;
 param_val[param] = s;

-Flush();
+changed = true;
+}
+//---------------------------------------------------------------------------
+int CONFIGFILE::Flush(const std::string & path) const
+{
+ofstream f(path.c_str());
+if (!f.is_open())
+    {
+    error = EIO;
+    return EIO;
+    }
+
+map<string, string>::const_iterator it = param_val.begin();
+while (it != param_val.end())
+    {
+    f << it->first << "=" << it->second << "\n";
+    ++it;
+    }
+
+f.close();
+return 0;
+}
+//---------------------------------------------------------------------------
+int CONFIGFILE::Flush() const
+{
+if (!changed)
+    return 0;
+
+std::string pid;
+x2str(getpid(), pid);
+
+if (Flush(fileName + "." + pid))
+    return -1;
+
+if (rename((fileName + "." + pid).c_str(), fileName.c_str()))
+    return -1;
+
+changed = false;
+

 return 0;
 }
 //---------------------------------------------------------------------------
 return 0;
 }
 //---------------------------------------------------------------------------