Apply some Clang Tidy suggestions.

[stg.git] / projects / stargazer / plugins / store / firebird / firebird_store.cpp

diff --git a/projects/stargazer/plugins/store/firebird/firebird_store.cpp b/projects/stargazer/plugins/store/firebird/firebird_store.cpp
index e5c7b0b16343ee2655b39f2a670bda0063f88a8a..c11b442be93e390e37a31fafa9dc1a7eb351fd70 100644 (file)
--- a/projects/stargazer/plugins/store/firebird/firebird_store.cpp
+++ b/projects/stargazer/plugins/store/firebird/firebird_store.cpp
@@ -26,38 +26,31 @@
  *
  */
 
-#include <string>
-#include <vector>
-#include <algorithm>
-
-#include "stg/ibpp.h"
-#include "stg/plugin_creator.h"
 #include "firebird_store.h"
 
-using namespace std;
+#include "stg/common.h"
 
-PLUGIN_CREATOR<FIREBIRD_STORE> frsc;
-//-----------------------------------------------------------------------------
-STORE * GetStore()
+#include <string>
+#include <vector>
+
+extern "C" STG::Store* GetStore()
 {
-return frsc.GetPlugin();
+    static FIREBIRD_STORE plugin;
+    return &plugin;
 }
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 //-----------------------------------------------------------------------------
 FIREBIRD_STORE::FIREBIRD_STORE()
     : version("firebird_store v.1.4"),
-      strError(),
       db_server("localhost"),
       db_database("/var/stg/stargazer.fdb"),
       db_user("stg"),
       db_password("123456"),
-      settings(),
-      db(),
-      mutex(),
       til(IBPP::ilConcurrency),
       tlr(IBPP::lrWait),
-      logger(GetPluginLogger(GetStgLogger(), "store_firebird"))
+      schemaVersion(0),
+      logger(STG::PluginLogger::get("store_firebird"))
 {
 pthread_mutex_init(&mutex, NULL);
 }
@@ -69,61 +62,47 @@ db->Disconnect();
 //-----------------------------------------------------------------------------
 int FIREBIRD_STORE::ParseSettings()
 {
-vector<PARAM_VALUE>::iterator i;
-string s;
+std::vector<STG::ParamValue>::iterator i;
+std::string s;
 
 for(i = settings.moduleParams.begin(); i != settings.moduleParams.end(); ++i)
     {
-    s = i->param;
-    transform(s.begin(), s.end(), s.begin(), ToLower());
+    if (i->value.empty())
+        continue;
+    s = ToLower(i->param);
+
     if (s == "server")
-        {
-        db_server = *(i->value.begin());
-        }
+        db_server = i->value.front();
+
     if (s == "database")
-        {
-        db_database = *(i->value.begin());
-        }
+        db_database = i->value.front();
+
     if (s == "user")
-        {
-        db_user = *(i->value.begin());
-        }
+        db_user = i->value.front();
+
     if (s == "password")
-        {
-        db_password = *(i->value.begin());
-        }
+        db_password = i->value.front();
 
     // Advanced settings block
 
     if (s == "isolationLevel")
         {
-        if (*(i->value.begin()) == "Concurrency")
-            {
+        if (i->value.front() == "Concurrency")
             til = IBPP::ilConcurrency;
-            }
-        else if (*(i->value.begin()) == "DirtyRead")
-            {
+        else if (i->value.front() == "DirtyRead")
             til = IBPP::ilReadDirty;
-            }
-        else if (*(i->value.begin()) == "ReadCommitted")
-            {
+        else if (i->value.front() == "ReadCommitted")
             til = IBPP::ilReadCommitted;
-            }
-        else if (*(i->value.begin()) == "Consistency")
-            {
+        else if (i->value.front() == "Consistency")
             til = IBPP::ilConsistency;
-            }
         }
+
     if (s == "lockResolution")
         {
-        if (*(i->value.begin()) == "Wait")
-            {
+        if (i->value.front() == "Wait")
             tlr = IBPP::lrWait;
-            }
-        else if (*(i->value.begin()) == "NoWait")
-            {
+        else if (i->value.front() == "NoWait")
             tlr = IBPP::lrNoWait;
-            }
         }
     }
 
@@ -131,6 +110,7 @@ try
     {
     db = IBPP::DatabaseFactory(db_server, db_database, db_user, db_password, "", "KOI8U", "");
     db->Connect();
+    return CheckVersion();
     }
 catch (IBPP::Exception & ex)
     {
@@ -142,3 +122,37 @@ catch (IBPP::Exception & ex)
 return 0;
 }
 //-----------------------------------------------------------------------------
+int FIREBIRD_STORE::CheckVersion()
+{
+IBPP::Transaction tr = IBPP::TransactionFactory(db, IBPP::amRead, til, tlr);
+IBPP::Statement st = IBPP::StatementFactory(db, tr);
+
+try
+    {
+    tr->Start();
+    st->Execute("SELECT RDB$RELATION_NAME FROM RDB$RELATIONS WHERE RDB$SYSTEM_FLAG=0 AND RDB$RELATION_NAME = 'TB_INFO'");
+    if (!st->Fetch())
+        {
+        schemaVersion = 0;
+        }
+    else
+        {
+        st->Execute("SELECT version FROM tb_info");
+        while (st->Fetch())
+            st->Get(1, schemaVersion);
+        }
+    tr->Commit();
+    logger("FIREBIRD_STORE: Current DB schema version: %d", schemaVersion);
+    }
+
+catch (IBPP::Exception & ex)
+    {
+    tr->Rollback();
+    strError = "IBPP exception";
+    printfd(__FILE__, ex.what());
+    return -1;
+    }
+
+return 0;
+}
+//-----------------------------------------------------------------------------