Disable cppcheck for foreign libs by default.

[stg.git] / projects / stargazer / plugins / configuration / rpcconfig / rpcconfig.cpp

diff --git a/projects/stargazer/plugins/configuration/rpcconfig/rpcconfig.cpp b/projects/stargazer/plugins/configuration/rpcconfig/rpcconfig.cpp
index 837c86496dcabfbbfd56c59228477eb5015ec7dc..df5ae9e4df34540d0da0ea269d1379a03e3d3f83 100644 (file)
--- a/projects/stargazer/plugins/configuration/rpcconfig/rpcconfig.cpp
+++ b/projects/stargazer/plugins/configuration/rpcconfig/rpcconfig.cpp
@@ -1,56 +1,62 @@
-#include <cstdlib>
-#include <csignal>
-
-#include <vector>
-#include <algorithm>
-
-#include "stg/common.h"
-#include "stg/admin.h"
-#include "stg/module_settings.h"
-#include "stg/settings.h"
-#include "stg/plugin_creator.h"
-

 #include "rpcconfig.h"
 #include "rpcconfig.h"

+

 #include "info_methods.h"
 #include "users_methods.h"
 #include "tariffs_methods.h"
 #include "admins_methods.h"
 #include "messages_methods.h"
 
 #include "info_methods.h"
 #include "users_methods.h"
 #include "tariffs_methods.h"
 #include "admins_methods.h"
 #include "messages_methods.h"
 

-PLUGIN_CREATOR<RPC_CONFIG> rpcc;
+#include "stg/admins.h"
+#include "stg/admin.h"
+#include "stg/module_settings.h"
+#include "stg/settings.h"
+#include "stg/common.h"
+#include "stg/const.h"
+
+#include <algorithm>
+#include <vector>
+#include <ostream> // xmlrpc-c devs have missed something :)
+#include <cstdlib>
+#include <csignal>
+#include <cerrno>
+#include <cstring>
+
+#include <sys/types.h>
+#include <sys/socket.h>
+#include <netinet/in.h>
+#include <arpa/inet.h>
+#include <unistd.h>

 
 RPC_CONFIG_SETTINGS::RPC_CONFIG_SETTINGS()
 
 RPC_CONFIG_SETTINGS::RPC_CONFIG_SETTINGS()

-    : errorStr(),
-      port(0),
+    : port(0),

       cookieTimeout(0)
 {
 }
 
       cookieTimeout(0)
 {
 }
 

-int RPC_CONFIG_SETTINGS::ParseSettings(const MODULE_SETTINGS & s)
+int RPC_CONFIG_SETTINGS::ParseSettings(const STG::ModuleSettings & s)

 {
 {

-int p;
-PARAM_VALUE pv;
-std::vector<PARAM_VALUE>::const_iterator pvi;
-
+STG::ParamValue pv;

 pv.param = "Port";
 pv.param = "Port";

+std::vector<STG::ParamValue>::const_iterator pvi;

 pvi = std::find(s.moduleParams.begin(), s.moduleParams.end(), pv);
 pvi = std::find(s.moduleParams.begin(), s.moduleParams.end(), pv);

-if (pvi == s.moduleParams.end())
+if (pvi == s.moduleParams.end() || pvi->value.empty())

     {
     errorStr = "Parameter \'Port\' not found.";
     printfd(__FILE__, "Parameter 'Port' not found\n");
     return -1;
     }
     {
     errorStr = "Parameter \'Port\' not found.";
     printfd(__FILE__, "Parameter 'Port' not found\n");
     return -1;
     }

+int p;

 if (ParseIntInRange(pvi->value[0], 2, 65535, &p))
     {
     errorStr = "Cannot parse parameter \'Port\': " + errorStr;
     printfd(__FILE__, "Cannot parse parameter 'Port'\n");
     return -1;
     }
 if (ParseIntInRange(pvi->value[0], 2, 65535, &p))
     {
     errorStr = "Cannot parse parameter \'Port\': " + errorStr;
     printfd(__FILE__, "Cannot parse parameter 'Port'\n");
     return -1;
     }

-port = p;
+port = static_cast<uint16_t>(p);

 
 pv.param = "CookieTimeout";
 pvi = std::find(s.moduleParams.begin(), s.moduleParams.end(), pv);
 
 pv.param = "CookieTimeout";
 pvi = std::find(s.moduleParams.begin(), s.moduleParams.end(), pv);

-if (pvi == s.moduleParams.end())
+if (pvi == s.moduleParams.end() || pvi->value.empty())

     {
     cookieTimeout = 1800; // 30 * 60
     }
     {
     cookieTimeout = 1800; // 30 * 60
     }


@@ -67,27 +73,22 @@ else
 return 0;
 }
 
 return 0;
 }
 

-PLUGIN * GetPlugin()
+extern "C" STG::Plugin* GetPlugin()

 {
 {

-return rpcc.GetPlugin();
+    static RPC_CONFIG plugin;
+    return &plugin;

 }
 
 RPC_CONFIG::RPC_CONFIG()
 }
 
 RPC_CONFIG::RPC_CONFIG()

-    : errorStr(),
-      rpcConfigSettings(),
-      users(NULL),
+    : users(NULL),

       admins(NULL),
       tariffs(NULL),
       store(NULL),
       admins(NULL),
       tariffs(NULL),
       store(NULL),

-      settings(),
-      rpcRegistry(),
+      fd(-1),

       rpcServer(NULL),
       rpcServer(NULL),

-      running(false),

       stopped(true),
       stopped(true),

-      tid(),
-      cookies(),

       dayFee(0),
       dayFee(0),

-      dirNames()
+      logger(STG::PluginLogger::get("conf_rpc"))

 {
 }
 
 {
 }
 


@@ -107,80 +108,109 @@ if (ret)
 return ret;
 }
 
 return ret;
 }
 

-void RPC_CONFIG::SetStgSettings(const SETTINGS * settings)
+void RPC_CONFIG::SetStgSettings(const STG::Settings * s)

 {
 {

-    dayFee = settings->GetDayFee();
+    dayFee = s->GetDayFee();

     dirNames.erase(dirNames.begin(), dirNames.end());
     for (size_t i = 0; i < DIR_NUM; ++i) {
     dirNames.erase(dirNames.begin(), dirNames.end());
     for (size_t i = 0; i < DIR_NUM; ++i) {

-        dirNames.push_back(settings->GetDirName(i));
+        dirNames.push_back(s->GetDirName(i));

     }
 }
 
 int RPC_CONFIG::Start()
 {
 InitiateRegistry();
     }
 }
 
 int RPC_CONFIG::Start()
 {
 InitiateRegistry();

-running = true;
-rpcServer = new xmlrpc_c::serverAbyss(
-        rpcRegistry,
-        rpcConfigSettings.GetPort(),
-        "/var/log/stargazer_rpc.log"
-        );
-if (pthread_create(&tid, NULL, Run, this))
+
+fd = socket(AF_INET, SOCK_STREAM, 0);
+if (fd < 0)
+    {
+    errorStr = "Failed to create socket";
+    logger("Cannot create a socket: %s", strerror(errno));
+    printfd(__FILE__, "Failed to create listening socket: %s\n", strerror(errno));
+    return -1;
+    }
+
+int flag = 1;
+
+if (setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, &flag, sizeof(flag)))

     {
     {

-    errorStr = "Failed to create RPC thread";
-    printfd(__FILE__, "Failed to crate RPC thread\n");
+    errorStr = "Setsockopt failed.";
+    logger("setsockopt error: %s", strerror(errno));
+    printfd(__FILE__, "Setsockopt failed: %s\n", strerror(errno));

     return -1;
     }
     return -1;
     }

+
+struct sockaddr_in addr;
+addr.sin_family = AF_INET;
+addr.sin_port = htons(rpcConfigSettings.GetPort());
+addr.sin_addr.s_addr = inet_addr("0.0.0.0");
+
+if (bind(fd, reinterpret_cast<sockaddr *>(&addr), sizeof(addr)))
+    {
+    logger("Cannot bind the socket: %s", strerror(errno));
+    errorStr = "Failed to bind socket";
+    printfd(__FILE__, "Failed to bind listening socket: %s\n", strerror(errno));
+    return -1;
+    }
+
+if (listen(fd, 10))
+    {
+    logger("Cannot listen the socket: %s", strerror(errno));
+    errorStr = "Failed to listen socket";
+    printfd(__FILE__, "Failed to listen listening socket: %s\n", strerror(errno));
+    return -1;
+    }
+
+rpcServer = new xmlrpc_c::serverAbyss(
+        xmlrpc_c::serverAbyss::constrOpt()
+        .registryP(&rpcRegistry)
+        .logFileName("/var/log/stargazer_rpc.log")
+        .socketFd(fd)
+        );
+
+m_thread = std::jthread([this](auto token){ Run(std::move(token)); });
+

 return 0;
 }
 
 int RPC_CONFIG::Stop()
 {
 return 0;
 }
 
 int RPC_CONFIG::Stop()
 {

-running = false;
+m_thread.request_stop();

 for (int i = 0; i < 5 && !stopped; ++i)
     {
     struct timespec ts = {0, 200000000};
     nanosleep(&ts, NULL);
     }
 for (int i = 0; i < 5 && !stopped; ++i)
     {
     struct timespec ts = {0, 200000000};
     nanosleep(&ts, NULL);
     }

-//rpcServer->terminate();
+

 if (!stopped)
     {
 if (!stopped)
     {

-    if (pthread_kill(tid, SIGTERM))
-        {
-        errorStr = "Failed to kill thread";
-        printfd(__FILE__, "Failed to kill thread\n");
-        }
-    for (int i = 0; i < 25 && !stopped; ++i)
-        {
-        struct timespec ts = {0, 200000000};
-        nanosleep(&ts, NULL);
-        }
-    if (!stopped)
-        {
-        printfd(__FILE__, "Failed to stop RPC thread\n");
-        errorStr = "Failed to stop RPC thread";
-        return -1;
-        }
-    else
-        {
-        pthread_join(tid, NULL);
-        }
+    m_thread.detach();
+    logger("Cannot stop RPC thread.");
+    printfd(__FILE__, "Failed to stop RPC thread\n");
+    errorStr = "Failed to stop RPC thread";
+    return -1;

     }
     }

+else
+    m_thread.join();
+
+close(fd);
+

 return 0;
 }
 
 return 0;
 }
 

-void * RPC_CONFIG::Run(void * rc)
+void RPC_CONFIG::Run(std::stop_token token)

 {
 {

-RPC_CONFIG * config = static_cast<RPC_CONFIG *>(rc);
+sigset_t signalSet;
+sigfillset(&signalSet);
+pthread_sigmask(SIG_BLOCK, &signalSet, NULL);

 
 

-config->stopped = false;
-while (config->running)
+stopped = false;
+while (!token.stop_requested())

     {
     {

-    config->rpcServer->runOnce();
+    if (WaitPackets(fd))
+        rpcServer->runOnce();

     }
     }

-config->stopped = true;
-
-return NULL;
+stopped = true;

 }
 
 bool RPC_CONFIG::GetAdminInfo(const std::string & cookie,
 }
 
 bool RPC_CONFIG::GetAdminInfo(const std::string & cookie,


@@ -213,17 +243,18 @@ bool RPC_CONFIG::CheckAdmin(const std::string & login,
                             const std::string & password,
                             std::string * cookie)
 {
                             const std::string & password,
                             std::string * cookie)
 {

-ADMIN * admin = NULL;
+STG::Admin * admin = NULL;

 
 

-if (!admins->Correct(login, password, &admin))
+if (!admins->correct(login, password, &admin))

     {
     {

+    logger("Attempt to connect with invalid credentials. Login: %s", login.c_str());

     return true;
     }
 
 ADMIN_INFO info;
 time(&info.accessTime);
 info.admin = login;
     return true;
     }
 
 ADMIN_INFO info;
 time(&info.accessTime);
 info.admin = login;

-info.priviledges = *admin->GetPriv();
+info.priviledges = admin->priv();

 *cookie = GetCookie();
 cookies[*cookie] = info;
 
 *cookie = GetCookie();
 cookies[*cookie] = info;
 


@@ -416,5 +447,11 @@ xmlrpc_c::methodPtr const methodGetOnlinIPsPtr(new METHOD_GET_ONLINE_IPS(
             users
             ));
 rpcRegistry.addMethod("stargazer.get_online_ips", methodGetOnlinIPsPtr);
             users
             ));
 rpcRegistry.addMethod("stargazer.get_online_ips", methodGetOnlinIPsPtr);

+
+xmlrpc_c::methodPtr const methodGetUserAuthByPtr(new METHOD_GET_USER_AUTH_BY(
+            this,
+            users
+            ));
+rpcRegistry.addMethod("stargazer.get_user_auth_by", methodGetUserAuthByPtr);

 }
 
 }