Paranoid Pdu clearing

[ssmd.git] / src / switch.cpp

diff --git a/src/switch.cpp b/src/switch.cpp
index bf18aa3e227dd1e2006b1d9474bea0e83d47cb58..1fb0d66457bc2b3f84f9e977fb7dcaadfb77b3ce 100644 (file)
--- a/src/switch.cpp
+++ b/src/switch.cpp
@@ -26,7 +26,8 @@ Switch::Switch(const Settings & settings,
       _writeCommunity(writeCommunity),
       _uplinkPort(uplinkPort),
       _nextUpACL(1),
       _writeCommunity(writeCommunity),
       _uplinkPort(uplinkPort),
       _nextUpACL(1),

-      _nextDownACL(1)
+      _nextDownACL(1),
+      _aclsCreated(false)

 {
 }
 
 {
 }
 


@@ -39,12 +40,38 @@ Switch::Switch(const Switch & rvalue)
       _uplinkPort(rvalue._uplinkPort),
       _nextUpACL(rvalue._nextUpACL),
       _nextDownACL(rvalue._nextDownACL),
       _uplinkPort(rvalue._uplinkPort),
       _nextUpACL(rvalue._nextUpACL),
       _nextDownACL(rvalue._nextDownACL),

-      _acls(rvalue._acls)
+      _acls(rvalue._acls),
+      _aclsCreated(rvalue._aclsCreated)

 {
 }
 
 Switch::~Switch()
 {
 {
 }
 
 Switch::~Switch()
 {

+    if (_aclsCreated) {
+        IpAddress addr(_ip.c_str());
+        if (!addr.valid()) {
+            logger << "Switch::~Switch() - ivalid switch ip: '" << _ip << "'" << std::endl;
+            return;
+        }
+
+        CTarget target(addr, _readCommunity.c_str(), _writeCommunity.c_str());
+        if (!target.valid()) {
+            logger << "Switch::~Switch() - failed to create target for the switch '" << _ip << "'" << std::endl;
+            return;
+        }
+
+        target.set_version(version2c);
+
+        if (!checkProfiles(target)) {
+            logger << "Switch::~Switch() - no upload and download profiles defined for the switch '" << _ip << "'" << std::endl;
+            return;
+        }
+
+        if (!dropACLs(target)) {
+            logger << "Switch::~Switch() - failed to drop ACLs for the switch '" << _ip << "'" << std::endl;
+            return;
+        }
+    }

 }
 
 Switch & Switch::operator=(const Switch & rvalue)
 }
 
 Switch & Switch::operator=(const Switch & rvalue)


@@ -56,6 +83,7 @@ Switch & Switch::operator=(const Switch & rvalue)
     _nextUpACL = rvalue._nextUpACL;
     _nextDownACL = rvalue._nextDownACL;
     _acls = rvalue._acls;
     _nextUpACL = rvalue._nextUpACL;
     _nextDownACL = rvalue._nextDownACL;
     _acls = rvalue._acls;

+    _aclsCreated = rvalue._aclsCreated;

 
     return *this;
 }
 
     return *this;
 }


@@ -106,6 +134,7 @@ void Switch::sync()
 
     if (!createACLs(target)) {
         logger << "Switch::sync() - failed to create ACLs for the switch '" << _ip << "'" << std::endl;
 
     if (!createACLs(target)) {
         logger << "Switch::sync() - failed to create ACLs for the switch '" << _ip << "'" << std::endl;

+        return;

     }
 
     if (_settings.isDebug()) {
     }
 
     if (_settings.isDebug()) {


@@ -192,8 +221,10 @@ bool Switch::dropACLsByTable(const CTarget & target, unsigned profileId, const S
             pdu += vb;
         }
         if (int c = _snmp.set(pdu, target) != SNMP_CLASS_SUCCESS) {
             pdu += vb;
         }
         if (int c = _snmp.set(pdu, target) != SNMP_CLASS_SUCCESS) {

-            logger << "Switch::dropACLsByTable() - failed to invoke Snmp::set for the switch '" << _ip << "'. Error message: '" << Snmp::error_msg(c) << "'" << std::endl;
-            return false;
+            if (c != SNMP_ERROR_TOO_BIG) {
+                logger << "Switch::dropACLsByTable() - failed to invoke Snmp::set for the switch '" << _ip << "'. Error message: '" << Snmp::error_msg(c) << "'" << std::endl;
+                return false;
+            }

         }
     }
     return true;
         }
     }
     return true;


@@ -202,13 +233,20 @@ bool Switch::dropACLsByTable(const CTarget & target, unsigned profileId, const S
 bool Switch::createACLs(const CTarget & target)
 {
     std::vector<ACL>::const_iterator it;
 bool Switch::createACLs(const CTarget & target)
 {
     std::vector<ACL>::const_iterator it;

+    size_t pos = 0;

     for (it = _acls.begin(); it != _acls.end(); ++it) {
         Pdu pdu;
         it->appendPdu(pdu);
         if (int c = _snmp.set(pdu, target) != SNMP_CLASS_SUCCESS) {
     for (it = _acls.begin(); it != _acls.end(); ++it) {
         Pdu pdu;
         it->appendPdu(pdu);
         if (int c = _snmp.set(pdu, target) != SNMP_CLASS_SUCCESS) {

-            logger << "Switch::createACLs() - failed to invoke Snmp::set for the switch '" << _ip << "'. Error message: '" << Snmp::error_msg(c) << "'" << std::endl;
-            return false;
+            if (c != SNMP_ERROR_TOO_BIG) {
+                logger << "Switch::createACLs() - failed to invoke Snmp::set for the switch '" << _ip << "'. Error message: '" << Snmp::error_msg(c) << "'. Error occured at creation of " << (pos + 1) << " from " << _acls.size() << " ACL's" << std::endl;
+                logger << "Switch::createACLs() - ACL dump: " << *it << std::endl;
+                return false;
+            }

         }
         }

+        pdu.clear();
+        _aclsCreated = true;
+        ++pos;

     }
     return true;
 }
     }
     return true;
 }